[PATCH] devtmpfs: Annotate devtmpfsd as __init

[PATCH] devtmpfs: Annotate devtmpfsd as __init

[Fabio Estevam]

This fixes the following:

WARNING: vmlinux.o(.text+0x1ed41c): Section mismatch in reference from the function devtmpfsd() to the (unknown reference) .init.data:(unknown)
The function devtmpfsd() references
the (unknown reference) __initdata (unknown).
This is often because devtmpfsd lacks a __initdata 
annotation or the annotation of (unknown) is wrong.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/base/devtmpfs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c
index 33e1bed..7bd4860 100644
--- a/drivers/base/devtmpfs.c
+++ b/drivers/base/devtmpfs.c
@@ -386,7 +386,7 @@ static int handle(const char *name, mode_t mode, struct device *dev)
 		return handle_remove(name, dev);
 }
 
-static int devtmpfsd(void *p)
+static __init int devtmpfsd(void *p)
 {
 	char options[] = "mode=0755";
 	int *err = p;
-- 
1.6.0.4

Re: [PATCH] devtmpfs: Annotate devtmpfsd as __init

[Arnaud Lacombe]

Hi,

On Tue, Aug 16, 2011 at 1:22 PM, Fabio Estevam
<fabio.estevam@freescale.com> wrote:
> This fixes the following:
>
> WARNING: vmlinux.o(.text+0x1ed41c): Section mismatch in reference from the function devtmpfsd() to the (unknown reference) .init.data:(unknown)
> The function devtmpfsd() references
> the (unknown reference) __initdata (unknown).
> This is often because devtmpfsd lacks a __initdata
> annotation or the annotation of (unknown) is wrong.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
I already submitted a patch for that https://patchwork.kernel.org/patch/996132/

> ---
>  drivers/base/devtmpfs.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c
> index 33e1bed..7bd4860 100644
> --- a/drivers/base/devtmpfs.c
> +++ b/drivers/base/devtmpfs.c
> @@ -386,7 +386,7 @@ static int handle(const char *name, mode_t mode, struct device *dev)
>                return handle_remove(name, dev);
>  }
>
> -static int devtmpfsd(void *p)
> +static __init int devtmpfsd(void *p)
>  {
I think this is wrong. `devtmpfsd' is the main loop of the
process/thread, you certainly don't want to whip it after boot.

 - Arnaud

>        char options[] = "mode=0755";
>        int *err = p;
> --
> 1.6.0.4
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Re: [PATCH] devtmpfs: Annotate devtmpfsd as __init

[Greg KH]

On Tue, Aug 16, 2011 at 01:30:06PM -0400, Arnaud Lacombe wrote:
> Hi,
> 
> On Tue, Aug 16, 2011 at 1:22 PM, Fabio Estevam
> <fabio.estevam@freescale.com> wrote:
> > This fixes the following:
> >
> > WARNING: vmlinux.o(.text+0x1ed41c): Section mismatch in reference from the function devtmpfsd() to the (unknown reference) .init.data:(unknown)
> > The function devtmpfsd() references
> > the (unknown reference) __initdata (unknown).
> > This is often because devtmpfsd lacks a __initdata
> > annotation or the annotation of (unknown) is wrong.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> >
> I already submitted a patch for that https://patchwork.kernel.org/patch/996132/

And it's in linux-next, right?

thanks,

greg k-h

Re: [PATCH] devtmpfs: Annotate devtmpfsd as __init

[Arnaud Lacombe]

Hi,

On Tue, Aug 16, 2011 at 1:57 PM, Greg KH <gregkh@suse.de> wrote:
> On Tue, Aug 16, 2011 at 01:30:06PM -0400, Arnaud Lacombe wrote:
>> Hi,
>>
>> On Tue, Aug 16, 2011 at 1:22 PM, Fabio Estevam
>> <fabio.estevam@freescale.com> wrote:
>> > This fixes the following:
>> >
>> > WARNING: vmlinux.o(.text+0x1ed41c): Section mismatch in reference from the function devtmpfsd() to the (unknown reference) .init.data:(unknown)
>> > The function devtmpfsd() references
>> > the (unknown reference) __initdata (unknown).
>> > This is often because devtmpfsd lacks a __initdata
>> > annotation or the annotation of (unknown) is wrong.
>> >
>> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> >
>> I already submitted a patch for that https://patchwork.kernel.org/patch/996132/
>
> And it's in linux-next, right?
>
Yes.

commit f9e0b159dbff693bacb64a929e04f442df985b50
Author: Arnaud Lacombe <lacombar@gmail.com>
Date:   Thu Jul 21 13:16:19 2011 -0400

    drivers/base/devtmpfs.c: correct annotation of `setup_done'

    This fixes the following section mismatch issue:

    WARNING: vmlinux.o(.text+0x1192bf): Section mismatch in reference
from the function devtmpfsd() to the variable .init.data:setup_done
    The function devtmpfsd() references the variable __initdata setup_done.
    This is often because devtmpfsd lacks a __initdata annotation or
the annotation of setup_done is wrong.

    WARNING: vmlinux.o(.text+0x119342): Section mismatch in reference
from the function devtmpfsd() to the variable .init.data:setup_done
    The function devtmpfsd() references the variable __initdata setup_done.
    This is often because devtmpfsd lacks a __initdata annotation or
the annotation of setup_done is wrong.

    Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

 - Arnaud

> thanks,
>
> greg k-h
>