From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Banajit Goswami <banajit.goswami@gmail.com>
Cc: Banajit Goswami <banajit.g@samsung.com>,
linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
ben-linux@fluff.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: S3C64XX: Remove un-used code
Date: Fri, 19 Aug 2011 13:53:47 +0900 [thread overview]
Message-ID: <20110819045346.GA26979@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CABK8_vR6bB_0TfQtbA7F9+w9dSXajMdd1SS5o+LscMrDcCY1tg@mail.gmail.com>
On Fri, Aug 19, 2011 at 09:40:29AM +0530, Banajit Goswami wrote:
> On Fri, Aug 19, 2011 at 7:29 AM, Mark Brown
> <broonie@opensource.wolfsonmicro.com> wrote:
> > On Tue, Aug 16, 2011 at 06:11:28PM +0530, Banajit Goswami wrote:
> >> Remove un-used backlight code for SMDK6410 board
> > Is the data actually wrong? If not it'd seem better to finish hooking
> > it up properly than to remove it.
> No, this code is no longer needed, as we are having a common backlight
> infrastructure , which serves the same purpose.
Ideally your commit log should make this clear - it looks like you're
just deleting unreferenced code.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: S3C64XX: Remove un-used code
Date: Fri, 19 Aug 2011 13:53:47 +0900 [thread overview]
Message-ID: <20110819045346.GA26979@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CABK8_vR6bB_0TfQtbA7F9+w9dSXajMdd1SS5o+LscMrDcCY1tg@mail.gmail.com>
On Fri, Aug 19, 2011 at 09:40:29AM +0530, Banajit Goswami wrote:
> On Fri, Aug 19, 2011 at 7:29 AM, Mark Brown
> <broonie@opensource.wolfsonmicro.com> wrote:
> > On Tue, Aug 16, 2011 at 06:11:28PM +0530, Banajit Goswami wrote:
> >> Remove un-used backlight code for SMDK6410 board
> > Is the data actually wrong? ?If not it'd seem better to finish hooking
> > it up properly than to remove it.
> No, this code is no longer needed, as we are having a common backlight
> infrastructure , which serves the same purpose.
Ideally your commit log should make this clear - it looks like you're
just deleting unreferenced code.
next prev parent reply other threads:[~2011-08-19 4:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 12:41 [PATCH] ARM: S3C64XX: Remove un-used code Banajit Goswami
2011-08-16 12:41 ` Banajit Goswami
2011-08-19 1:59 ` Mark Brown
2011-08-19 1:59 ` Mark Brown
2011-08-19 4:10 ` Banajit Goswami
2011-08-19 4:10 ` Banajit Goswami
2011-08-19 4:53 ` Mark Brown [this message]
2011-08-19 4:53 ` Mark Brown
2011-08-19 5:29 ` Kukjin Kim
2011-08-19 5:29 ` Kukjin Kim
2011-08-19 5:39 ` Banajit Goswami
2011-08-19 5:39 ` Banajit Goswami
2011-08-19 6:59 ` Banajit Goswami
2011-08-19 6:59 ` Banajit Goswami
2011-08-19 5:24 ` Kukjin Kim
2011-08-19 5:24 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110819045346.GA26979@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=banajit.g@samsung.com \
--cc=banajit.goswami@gmail.com \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.