[PATCH] MIPS: Octeon: Select CONFIG_HOLES_IN_ZONE

[PATCH] MIPS: Octeon: Select CONFIG_HOLES_IN_ZONE

[David Daney]

Current Octeon systems do in fact have holes in their memory zones.
We need to select HOLES_IN_ZONE.  If we do not, some memory
configurations will result in crashes at boot time like this:

.
.
.
CPU 6 Unable to handle kernel paging request at virtual address 0000000000700000, epc == ffffffff8118fe00, ra == ffffffff8118fe9c
Oops[#1]:
Cpu 6
.
.
.
        ...
Call Trace:
[<ffffffff8118fe00>] setup_per_zone_wmarks+0x1b0/0x338
[<ffffffff815cd738>] init_per_zone_wmark_min+0x64/0xd0
[<ffffffff81100438>] do_one_initcall+0x38/0x160
.
.
.

Reported-by: Jason Kwon <jason.kwon@ericsson.com>
Signed-off-by: David Daney <david.daney@cavium.com>
Cc: Jason Kwon <jason.kwon@ericsson.com>
---
Jason, can you test this patch?

Ralf, if Jason reports that it fixes his problem, it probably is
needed for 3.0 and 3.1.

 arch/mips/Kconfig |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index d300c2b..b122adc 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -723,6 +723,7 @@ config CAVIUM_OCTEON_SIMULATOR
 	select SYS_SUPPORTS_HIGHMEM
 	select SYS_SUPPORTS_HOTPLUG_CPU
 	select SYS_HAS_CPU_CAVIUM_OCTEON
+	select HOLES_IN_ZONE
 	help
 	  The Octeon simulator is software performance model of the Cavium
 	  Octeon Processor. It supports simulating Octeon processors on x86
@@ -745,6 +746,7 @@ config CAVIUM_OCTEON_REFERENCE_BOARD
 	select ZONE_DMA32
 	select USB_ARCH_HAS_OHCI
 	select USB_ARCH_HAS_EHCI
+	select HOLES_IN_ZONE
 	help
 	  This option supports all of the Octeon reference boards from Cavium
 	  Networks. It builds a kernel that dynamically determines the Octeon
@@ -974,6 +976,9 @@ config ISA_DMA_API
 config GENERIC_GPIO
 	bool
 
+config HOLES_IN_ZONE
+	bool
+
 #
 # Endianess selection.  Sufficiently obscure so many users don't know what to
 # answer,so we try hard to limit the available choices.  Also the use of a
-- 
1.7.2.3

Re: [PATCH] MIPS: Octeon: Select CONFIG_HOLES_IN_ZONE

[Guenter Roeck]

On Fri, 2011-08-19 at 14:44 -0400, David Daney wrote:
> Current Octeon systems do in fact have holes in their memory zones.
> We need to select HOLES_IN_ZONE.  If we do not, some memory
> configurations will result in crashes at boot time like this:
> 
> .
> .
> .
> CPU 6 Unable to handle kernel paging request at virtual address 0000000000700000, epc == ffffffff8118fe00, ra == ffffffff8118fe9c
> Oops[#1]:
> Cpu 6
> .
> .
> .
>         ...
> Call Trace:
> [<ffffffff8118fe00>] setup_per_zone_wmarks+0x1b0/0x338
> [<ffffffff815cd738>] init_per_zone_wmark_min+0x64/0xd0
> [<ffffffff81100438>] do_one_initcall+0x38/0x160
> .
> .
> .
> 
> Reported-by: Jason Kwon <jason.kwon@ericsson.com>
> Signed-off-by: David Daney <david.daney@cavium.com>
> Cc: Jason Kwon <jason.kwon@ericsson.com>
> ---
> Jason, can you test this patch?
> 
> Ralf, if Jason reports that it fixes his problem, it probably is
> needed for 3.0 and 3.1.
> 

Your patch fixes the problem for the board with CN38xx and 2GB RAM that
crashed previously.

Tested-by: Guenter Roeck <guenter.roeck@ericsson.com>

Thanks a lot for looking into this.

Guenter

Re: [PATCH] MIPS: Octeon: Select CONFIG_HOLES_IN_ZONE

[Jason Kwon]

On 08/19/2011 12:13 PM, Guenter Roeck wrote:
> On Fri, 2011-08-19 at 14:44 -0400, David Daney wrote:
>> Current Octeon systems do in fact have holes in their memory zones.
>> We need to select HOLES_IN_ZONE.  If we do not, some memory
>> configurations will result in crashes at boot time like this:
>>
>> .
>> .
>> .
>> CPU 6 Unable to handle kernel paging request at virtual address 0000000000700000, epc == ffffffff8118fe00, ra == ffffffff8118fe9c
>> Oops[#1]:
>> Cpu 6
>> .
>> .
>> .
>>          ...
>> Call Trace:
>> [<ffffffff8118fe00>] setup_per_zone_wmarks+0x1b0/0x338
>> [<ffffffff815cd738>] init_per_zone_wmark_min+0x64/0xd0
>> [<ffffffff81100438>] do_one_initcall+0x38/0x160
>> .
>> .
>> .
>>
>> Reported-by: Jason Kwon<jason.kwon@ericsson.com>
>> Signed-off-by: David Daney<david.daney@cavium.com>
>> Cc: Jason Kwon<jason.kwon@ericsson.com>
>> ---
>> Jason, can you test this patch?
>>
>> Ralf, if Jason reports that it fixes his problem, it probably is
>> needed for 3.0 and 3.1.
>>
> Your patch fixes the problem for the board with CN38xx and 2GB RAM that
> crashed previously.
>
> Tested-by: Guenter Roeck<guenter.roeck@ericsson.com>
>
> Thanks a lot for looking into this.
>
> Guenter
>
>

I applied the patch to 3.0.3 and was able to boot the CN58XX system 
without any memory restrictions.  The same patched kernel booted on 
CN38XX ran into a different problem, which I'm looking into.

Thanks,

Jason

Re: [PATCH] MIPS: Octeon: Select CONFIG_HOLES_IN_ZONE

[Ralf Baechle]

On Fri, Aug 19, 2011 at 02:26:13PM -0700, Jason Kwon wrote:
> Date:   Fri, 19 Aug 2011 14:26:13 -0700
> From: Jason Kwon <jason.kwon@ericsson.com>
> To: Guenter Roeck <guenter.roeck@ericsson.com>
> CC: David Daney <david.daney@cavium.com>, "linux-mips@linux-mips.org"
>  <linux-mips@linux-mips.org>, "ralf@linux-mips.org" <ralf@linux-mips.org>
> Subject: Re: [PATCH] MIPS: Octeon: Select CONFIG_HOLES_IN_ZONE
> Content-Type: text/plain; charset="UTF-8"; format=flowed
> 
> On 08/19/2011 12:13 PM, Guenter Roeck wrote:
> >On Fri, 2011-08-19 at 14:44 -0400, David Daney wrote:
> >>Current Octeon systems do in fact have holes in their memory zones.
> >>We need to select HOLES_IN_ZONE.  If we do not, some memory
> >>configurations will result in crashes at boot time like this:
> >>
> >>.
> >>.
> >>.
> >>CPU 6 Unable to handle kernel paging request at virtual address 0000000000700000, epc == ffffffff8118fe00, ra == ffffffff8118fe9c
> >>Oops[#1]:
> >>Cpu 6
> >>.
> >>.
> >>.
> >>         ...
> >>Call Trace:
> >>[<ffffffff8118fe00>] setup_per_zone_wmarks+0x1b0/0x338
> >>[<ffffffff815cd738>] init_per_zone_wmark_min+0x64/0xd0
> >>[<ffffffff81100438>] do_one_initcall+0x38/0x160
> >>.
> >>.
> >>.
> >>
> >>Reported-by: Jason Kwon<jason.kwon@ericsson.com>
> >>Signed-off-by: David Daney<david.daney@cavium.com>
> >>Cc: Jason Kwon<jason.kwon@ericsson.com>
> >>---
> >>Jason, can you test this patch?
> >>
> >>Ralf, if Jason reports that it fixes his problem, it probably is
> >>needed for 3.0 and 3.1.
> >>
> >Your patch fixes the problem for the board with CN38xx and 2GB RAM that
> >crashed previously.
> >
> >Tested-by: Guenter Roeck<guenter.roeck@ericsson.com>
> >
> >Thanks a lot for looking into this.
> >
> >Guenter
> >
> >
> 
> I applied the patch to 3.0.3 and was able to boot the CN58XX system
> without any memory restrictions.  The same patched kernel booted on
> CN38XX ran into a different problem, which I'm looking into.

Applied.  Thanks, folks!

  Ralf