[U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available

[Marek Vasut <marek.vasut@gmail.com>]

On Monday, August 22, 2011 05:51:05 PM Helmut Raiger wrote:
> On 08/22/2011 05:02 PM, Marek Vasut wrote:
> >> Masks are not defined for i.MX31 (imx-regs.h), so I simply followed the
> >> code, which was in the file. The generic.c file for MX35 however is a
> >> different story.
> >> 
> >> To keep things simple, I suggest we leave it at that for now.
> > 
> > And noone's gonna fix it later. No please, define the proper constants
> > please.
> 
> Do you really expect me to fix code in all the arch/arm/cpu/arm1136/mx31
> files (2000+ lines) that use that kind of access, because I add 15 lines
> to one of them? There are some 50 other drivers and boards etc. that
> depend on imx-regs.h, which probably use these access methods as-well!

Hey, calm down, I didn't say anything about fixing gazilion of crap (even though 
that'd be nice of you !).

Actually, I did a quick look and see arch/arm/include/arch-mx35/crm_regs.h 
containing PDR0 definitions. Though they don't match your constants. It's either 
bug in the crm_regs.h or your code.

> 
> I'm not prepared to take this effort, sorry. After all this is
> _COSMETIC_, while this new mx3fb driver really works nicely ;-)

Oh my sense for metrosexuality of code really kicks in here ;-)

> If anyone out there modifies these files, I'll definitely rebase the
> driver to it.

It has nothing to do with your driver, the problem I have is with these few 
magic numbers you use in 1/2 (make HSP clock ...). You can use constants from 
crm_regs.h, see above.
> 
> Helmut

Cheers!
> 
> 
> --
> Scanned by MailScanner.