All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available
Date: Mon, 22 Aug 2011 18:39:08 +0200	[thread overview]
Message-ID: <201108221839.09008.marek.vasut@gmail.com> (raw)
In-Reply-To: <201108221802.10566.marek.vasut@gmail.com>

On Monday, August 22, 2011 06:02:10 PM Marek Vasut wrote:
> On Monday, August 22, 2011 05:51:05 PM Helmut Raiger wrote:
> > On 08/22/2011 05:02 PM, Marek Vasut wrote:
> > >> Masks are not defined for i.MX31 (imx-regs.h), so I simply followed
> > >> the code, which was in the file. The generic.c file for MX35 however
> > >> is a different story.
> > >> 
> > >> To keep things simple, I suggest we leave it at that for now.
> > > 
> > > And noone's gonna fix it later. No please, define the proper constants
> > > please.
> > 
> > Do you really expect me to fix code in all the arch/arm/cpu/arm1136/mx31
> > files (2000+ lines) that use that kind of access, because I add 15 lines
> > to one of them? There are some 50 other drivers and boards etc. that
> > depend on imx-regs.h, which probably use these access methods as-well!
> 
> Hey, calm down, I didn't say anything about fixing gazilion of crap (even
> though that'd be nice of you !).
> 
> Actually, I did a quick look and see arch/arm/include/arch-mx35/crm_regs.h
> containing PDR0 definitions. Though they don't match your constants. It's
> either bug in the crm_regs.h or your code.

Ah sorry, it's mx31. Right, the defines are missing. Do what Stefano said then. 
And really ... noone wants you to modify gazilions of lines, just your few :)

Cheers and sorry for misguiding you about mx35.

  reply	other threads:[~2011-08-22 16:39 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-22 13:41 [U-Boot] Moving mx3fb.c to CONFIG_VIDEO Helmut Raiger
2011-08-22 13:41 ` [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available Helmut Raiger
2011-08-22 14:00   ` Marek Vasut
2011-08-22 15:00     ` Helmut Raiger
2011-08-22 15:02       ` Marek Vasut
2011-08-22 15:51         ` Helmut Raiger
2011-08-22 16:02           ` Marek Vasut
2011-08-22 16:39             ` Marek Vasut [this message]
2011-08-24  6:55             ` Helmut Raiger
2011-08-24 12:35               ` Marek Vasut
2011-08-22 16:22           ` Stefano Babic
2011-08-22 13:41 ` [U-Boot] [PATCH 2/2] mx3fb: move to CONFIG_VIDEO to support videomodes Helmut Raiger
2011-08-22 17:13   ` Stefano Babic
2011-08-24 11:53     ` Helmut Raiger
2011-08-24 15:34       ` Helmut Raiger
2011-08-24 15:45         ` Stefano Babic
     [not found]     ` <4E549AC3.3060909@hale.at>
2011-08-24 11:57       ` Helmut Raiger
2011-08-22 16:04 ` [U-Boot] Moving mx3fb.c to CONFIG_VIDEO Stefano Babic
2011-09-05 11:47 ` [U-Boot] Version 2 of 'Moving mx3fb to CONFIG_VIDEO' Helmut Raiger
2011-09-05 11:47   ` [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available Helmut Raiger
2011-09-05 13:10     ` Marek Vasut
2011-09-05 11:47   ` [U-Boot] [PATCH 2/2] Moving mx3fb.c to CONFIG_VIDEO Helmut Raiger
2011-09-20 11:44     ` Stefano Babic
2011-09-20 12:36       ` Anatolij Gustschin
2011-09-20 13:09         ` Stefano Babic
2011-09-21  8:02           ` Helmut Raiger
2011-09-21 14:58             ` Stefano Babic
2011-09-28 17:24           ` Anatolij Gustschin
2011-10-13  9:16   ` [U-Boot] [PATCH v3 1/2] mx31: make HSP clock for mx3fb driver available Anatolij Gustschin
2011-10-13  9:23     ` Anatolij Gustschin
2011-10-13  9:40       ` Stefano Babic
2011-10-14  7:02     ` Anatolij Gustschin
2011-10-13  9:16   ` [U-Boot] [PATCH v3 2/2] video: Moving mx3fb.c to CONFIG_VIDEO Anatolij Gustschin
2011-10-14  6:37     ` Helmut Raiger
2011-10-14  7:00       ` Anatolij Gustschin
2011-10-14  7:04     ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108221839.09008.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.