From: Konstantin Khlebnikov <khlebnikov@openvz.org>
To: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Oleg Nesterov <oleg@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>
Subject: [PATCH] oom: skip frozen tasks
Date: Tue, 23 Aug 2011 11:31:01 +0300 [thread overview]
Message-ID: <20110823073101.6426.77745.stgit@zurg> (raw)
All frozen tasks are unkillable, and if one of them has TIF_MEMDIE
we must kill something else to avoid deadlock. After this patch
select_bad_process() will skip frozen task before checking TIF_MEMDIE.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
---
mm/oom_kill.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index 626303b..931ab20 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -138,6 +138,8 @@ static bool oom_unkillable_task(struct task_struct *p,
return true;
if (p->flags & PF_KTHREAD)
return true;
+ if (p->flags & PF_FROZEN)
+ return true;
/* When mem_cgroup_out_of_memory() and p is not member of the group */
if (mem && !task_in_mem_cgroup(p, mem))
WARNING: multiple messages have this Message-ID (diff)
From: Konstantin Khlebnikov <khlebnikov@openvz.org>
To: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Oleg Nesterov <oleg@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
David Rientjes <rientjes@google.com>
Subject: [PATCH] oom: skip frozen tasks
Date: Tue, 23 Aug 2011 11:31:01 +0300 [thread overview]
Message-ID: <20110823073101.6426.77745.stgit@zurg> (raw)
All frozen tasks are unkillable, and if one of them has TIF_MEMDIE
we must kill something else to avoid deadlock. After this patch
select_bad_process() will skip frozen task before checking TIF_MEMDIE.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
---
mm/oom_kill.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index 626303b..931ab20 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -138,6 +138,8 @@ static bool oom_unkillable_task(struct task_struct *p,
return true;
if (p->flags & PF_KTHREAD)
return true;
+ if (p->flags & PF_FROZEN)
+ return true;
/* When mem_cgroup_out_of_memory() and p is not member of the group */
if (mem && !task_in_mem_cgroup(p, mem))
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2011-08-23 7:31 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 8:31 Konstantin Khlebnikov [this message]
2011-08-23 8:31 ` [PATCH] oom: skip frozen tasks Konstantin Khlebnikov
2011-08-23 9:15 ` KAMEZAWA Hiroyuki
2011-08-23 9:15 ` KAMEZAWA Hiroyuki
2011-08-23 13:46 ` Michal Hocko
2011-08-23 13:46 ` Michal Hocko
2011-08-23 20:18 ` David Rientjes
2011-08-23 20:18 ` David Rientjes
2011-08-24 10:19 ` Michal Hocko
2011-08-24 10:19 ` Michal Hocko
2011-08-24 19:31 ` David Rientjes
2011-08-24 19:31 ` David Rientjes
2011-08-25 9:19 ` Michal Hocko
2011-08-25 9:19 ` Michal Hocko
2011-08-25 15:18 ` Oleg Nesterov
2011-08-25 15:18 ` Oleg Nesterov
2011-08-25 16:47 ` Michal Hocko
2011-08-25 16:47 ` Michal Hocko
2011-08-25 21:14 ` David Rientjes
2011-08-25 21:14 ` David Rientjes
2011-08-26 7:09 ` Michal Hocko
2011-08-26 7:09 ` Michal Hocko
2011-08-26 8:56 ` Michal Hocko
2011-08-26 8:56 ` Michal Hocko
2011-08-26 9:21 ` David Rientjes
2011-08-26 9:21 ` David Rientjes
2011-08-26 9:53 ` Michal Hocko
2011-08-26 9:53 ` Michal Hocko
2011-08-26 11:01 ` Michal Hocko
2011-08-26 11:01 ` Michal Hocko
2011-08-26 18:13 ` David Rientjes
2011-08-26 18:13 ` David Rientjes
2011-09-26 8:28 ` [PATCH 1/2] oom: do not live lock on " Michal Hocko
2011-09-26 8:28 ` Michal Hocko
2011-09-26 8:56 ` David Rientjes
2011-09-26 8:56 ` David Rientjes
2011-09-26 9:14 ` Michal Hocko
2011-09-26 9:14 ` Michal Hocko
2011-09-26 9:25 ` KAMEZAWA Hiroyuki
2011-09-26 9:25 ` KAMEZAWA Hiroyuki
2011-09-26 9:32 ` Michal Hocko
2011-09-26 9:32 ` Michal Hocko
2011-09-26 15:51 ` Rafael J. Wysocki
2011-09-26 15:51 ` Rafael J. Wysocki
2011-09-26 18:28 ` Michal Hocko
2011-09-26 18:28 ` Michal Hocko
2011-09-27 1:03 ` David Rientjes
2011-09-27 1:03 ` David Rientjes
2011-09-27 7:52 ` Michal Hocko
2011-09-27 7:52 ` Michal Hocko
2011-09-27 18:30 ` David Rientjes
2011-09-27 18:30 ` David Rientjes
2011-09-26 10:28 ` Rusty Russell
2011-09-26 10:28 ` Rusty Russell
2011-09-26 11:05 ` Michal Hocko
2011-09-26 11:05 ` Michal Hocko
2011-09-27 2:21 ` Rusty Russell
2011-09-27 2:21 ` Rusty Russell
2011-09-27 7:03 ` [PATCH] lguest: move process freezing before pending signals check Michal Hocko
2011-09-27 7:03 ` Michal Hocko
2011-09-26 8:35 ` [PATCH 2/2] oom: give bonus to frozen processes Michal Hocko
2011-09-26 8:35 ` Michal Hocko
2011-09-26 9:02 ` David Rientjes
2011-09-26 9:02 ` David Rientjes
2011-09-26 9:31 ` KAMEZAWA Hiroyuki
2011-09-26 9:31 ` KAMEZAWA Hiroyuki
2011-09-26 9:54 ` Michal Hocko
2011-09-26 9:54 ` Michal Hocko
2011-08-26 21:03 ` [PATCH] oom: skip frozen tasks Rafael J. Wysocki
2011-08-26 21:03 ` Rafael J. Wysocki
2011-08-26 10:03 ` Konstantin Khlebnikov
2011-08-26 10:03 ` Konstantin Khlebnikov
2011-08-26 10:48 ` Michal Hocko
2011-08-26 10:48 ` Michal Hocko
2011-08-26 12:44 ` Konstantin Khlebnikov
2011-08-26 12:44 ` Konstantin Khlebnikov
2011-08-26 12:59 ` Michal Hocko
2011-08-26 12:59 ` Michal Hocko
2011-08-26 7:35 ` Konstantin Khlebnikov
2011-08-26 7:35 ` Konstantin Khlebnikov
2011-08-26 9:09 ` David Rientjes
2011-08-26 9:09 ` David Rientjes
2011-08-26 9:59 ` Konstantin Khlebnikov
2011-08-26 9:59 ` Konstantin Khlebnikov
2011-08-26 18:09 ` David Rientjes
2011-08-26 18:09 ` David Rientjes
2011-08-25 21:03 ` Rafael J. Wysocki
2011-08-25 21:03 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110823073101.6426.77745.stgit@zurg \
--to=khlebnikov@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oleg@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.