From: John W. Linville <linville@tuxdriver.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [RFC/RFT] ath9k_htc: Fix memory leak
Date: Tue, 23 Aug 2011 15:45:46 -0400 [thread overview]
Message-ID: <20110823194545.GF9770@tuxdriver.com> (raw)
In-Reply-To: <CAD2nsn2sO+Lj+DntbFVa8QMYq8eTtFqdX06aQGHtNEbnbVTJzQ@mail.gmail.com>
On Mon, Aug 15, 2011 at 05:56:33PM +0530, Mohammed Shafi wrote:
> On Sun, Aug 14, 2011 at 7:04 AM, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> > Kmemleak shows the following kind of memory leak for ath9k_htc:
> >
> > unreferenced object 0xffff88004542f200 (size 512):
> > ?comm "khubd", pid 977, jiffies 4317632516 (age 16855.868s)
> > ?hex dump (first 32 bytes):
> > ? ?00 00 00 0a 00 00 00 00 00 02 01 05 00 00 02 01 ?................
> > ? ?00 00 00 00 00 00 81 38 02 00 00 00 33 33 30 30 ?.......8....3300
> > ?backtrace:
> > ? ?[<ffffffff81122d77>] create_object+0x127/0x2b0
> > ? ?[<ffffffff813580b1>] kmemleak_alloc+0x21/0x50
> > ? ?[<ffffffff8111f383>] __kmalloc_node_track_caller+0x153/0x220
> > ? ?[<ffffffff812b703e>] __alloc_skb+0x7e/0x170
> > ? ?[<ffffffffa0833331>] htc_connect_service+0x111/0x200 [ath9k_htc]
> > ? ?[<ffffffffa083bb90>] ath9k_init_htc_services+0x240/0x2b0 [ath9k_htc]
> > ? ?[<ffffffffa083c1ca>] ath9k_htc_probe_device+0xea/0xa50 [ath9k_htc]
> > ? ?[<ffffffffa08338dc>] ath9k_htc_hw_init+0xc/0x30 [ath9k_htc]
> > ? ?[<ffffffffa08356ba>] ath9k_hif_usb_probe+0x1ca/0x420 [ath9k_htc]
> > ? ?[<ffffffffa00a2279>] usb_probe_interface+0xb9/0x160 [usbcore]
> > ? ?[<ffffffff81279379>] driver_probe_device+0x89/0x1a0
> > ? ?[<ffffffff8127958b>] __device_attach+0x4b/0x60
> > ? ?[<ffffffff81278024>] bus_for_each_drv+0x64/0x90
> > ? ?[<ffffffff81279231>] device_attach+0xa1/0xb0
> > ? ?[<ffffffff81278a25>] bus_probe_device+0x25/0x40
> > ? ?[<ffffffff81276d2a>] device_add+0x55a/0x630
> >
> > The device is a TP-Link TL-WN722N. The output from lsusb is "ID 0cf3:9271
> > Atheros Communications, Inc. AR9271 802.11n".
> >
> > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> > Cc: Stable <stable@kernel.org>
> > ---
> >
> > This patch certainly fixes a leak. I'm testing to see if there are
> > others.
>
> Hi Larry,
>
> thanks for finding this.
> I remember seeing this memleaks sometime back and thought this patch
> might help(i think same as yours with some more corner cases)
> https://patchwork.kernel.org/patch/1016752/
> but I found there were still some memory leaks, I was unsure where I
> am missing. if you are sure that this addresses the issue, we can send
> a patch.
Ping? Is this the patch we want? Or something else?
John
--
John W. Linville Someday the world will need a hero, and you
linville at tuxdriver.com might be all we have. Be ready.
WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville@tuxdriver.com>
To: Mohammed Shafi <shafi.wireless@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
lrodriguez@atheros.com, vasanth@atheros.com,
senthilkumar@atheros.com, ath9k-devel@venema.h4ckr.net,
linux-wireless@vger.kernel.org, rmanohar@qca.qualcomm.com
Subject: Re: [RFC/RFT] ath9k_htc: Fix memory leak
Date: Tue, 23 Aug 2011 15:45:46 -0400 [thread overview]
Message-ID: <20110823194545.GF9770@tuxdriver.com> (raw)
In-Reply-To: <CAD2nsn2sO+Lj+DntbFVa8QMYq8eTtFqdX06aQGHtNEbnbVTJzQ@mail.gmail.com>
On Mon, Aug 15, 2011 at 05:56:33PM +0530, Mohammed Shafi wrote:
> On Sun, Aug 14, 2011 at 7:04 AM, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> > Kmemleak shows the following kind of memory leak for ath9k_htc:
> >
> > unreferenced object 0xffff88004542f200 (size 512):
> > comm "khubd", pid 977, jiffies 4317632516 (age 16855.868s)
> > hex dump (first 32 bytes):
> > 00 00 00 0a 00 00 00 00 00 02 01 05 00 00 02 01 ................
> > 00 00 00 00 00 00 81 38 02 00 00 00 33 33 30 30 .......8....3300
> > backtrace:
> > [<ffffffff81122d77>] create_object+0x127/0x2b0
> > [<ffffffff813580b1>] kmemleak_alloc+0x21/0x50
> > [<ffffffff8111f383>] __kmalloc_node_track_caller+0x153/0x220
> > [<ffffffff812b703e>] __alloc_skb+0x7e/0x170
> > [<ffffffffa0833331>] htc_connect_service+0x111/0x200 [ath9k_htc]
> > [<ffffffffa083bb90>] ath9k_init_htc_services+0x240/0x2b0 [ath9k_htc]
> > [<ffffffffa083c1ca>] ath9k_htc_probe_device+0xea/0xa50 [ath9k_htc]
> > [<ffffffffa08338dc>] ath9k_htc_hw_init+0xc/0x30 [ath9k_htc]
> > [<ffffffffa08356ba>] ath9k_hif_usb_probe+0x1ca/0x420 [ath9k_htc]
> > [<ffffffffa00a2279>] usb_probe_interface+0xb9/0x160 [usbcore]
> > [<ffffffff81279379>] driver_probe_device+0x89/0x1a0
> > [<ffffffff8127958b>] __device_attach+0x4b/0x60
> > [<ffffffff81278024>] bus_for_each_drv+0x64/0x90
> > [<ffffffff81279231>] device_attach+0xa1/0xb0
> > [<ffffffff81278a25>] bus_probe_device+0x25/0x40
> > [<ffffffff81276d2a>] device_add+0x55a/0x630
> >
> > The device is a TP-Link TL-WN722N. The output from lsusb is "ID 0cf3:9271
> > Atheros Communications, Inc. AR9271 802.11n".
> >
> > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> > Cc: Stable <stable@kernel.org>
> > ---
> >
> > This patch certainly fixes a leak. I'm testing to see if there are
> > others.
>
> Hi Larry,
>
> thanks for finding this.
> I remember seeing this memleaks sometime back and thought this patch
> might help(i think same as yours with some more corner cases)
> https://patchwork.kernel.org/patch/1016752/
> but I found there were still some memory leaks, I was unsure where I
> am missing. if you are sure that this addresses the issue, we can send
> a patch.
Ping? Is this the patch we want? Or something else?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-08-23 19:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-14 1:34 [ath9k-devel] [RFC/RFT] ath9k_htc: Fix memory leak Larry Finger
2011-08-14 1:34 ` Larry Finger
2011-08-15 12:26 ` [ath9k-devel] " Mohammed Shafi
2011-08-15 12:26 ` Mohammed Shafi
2011-08-23 19:45 ` John W. Linville [this message]
2011-08-23 19:45 ` John W. Linville
2011-08-24 15:53 ` [ath9k-devel] " Mohammed Shafi
2011-08-24 15:53 ` Mohammed Shafi
2011-08-24 16:49 ` [ath9k-devel] " Larry Finger
2011-08-24 16:49 ` Larry Finger
2011-08-24 16:55 ` [ath9k-devel] " Mohammed Shafi
2011-08-24 16:55 ` Mohammed Shafi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110823194545.GF9770@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.