From: Andrew Morton <akpm@linux-foundation.org>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH -v2] debug-pagealloc: add support for highmem pages
Date: Thu, 25 Aug 2011 17:03:02 -0700 [thread overview]
Message-ID: <20110825170302.81ed210c.akpm@linux-foundation.org> (raw)
In-Reply-To: <1314281649-21508-1-git-send-email-akinobu.mita@gmail.com>
On Thu, 25 Aug 2011 23:14:09 +0900
Akinobu Mita <akinobu.mita@gmail.com> wrote:
> This adds support for highmem pages poisoning and verification to the
> debug-pagealloc feature for no-architecture support.
>
Sorry, I had a brainfart. kmap_atomic() internally does the
preempt_disable() (actually pagefault_disable()).
--- a/mm/debug-pagealloc.c~debug-pagealloc-add-support-for-highmem-pages-fix
+++ a/mm/debug-pagealloc.c
@@ -23,14 +23,11 @@ static inline bool page_poison(struct pa
static void poison_page(struct page *page)
{
- void *addr;
+ void *addr = kmap_atomic(page);
- preempt_disable();
- addr = kmap_atomic(page);
set_page_poison(page);
memset(addr, PAGE_POISON, PAGE_SIZE);
kunmap_atomic(addr);
- preempt_enable();
}
static void poison_pages(struct page *page, int n)
@@ -82,12 +79,10 @@ static void unpoison_page(struct page *p
if (!page_poison(page))
return;
- preempt_disable();
addr = kmap_atomic(page);
check_poison_mem(addr, PAGE_SIZE);
clear_page_poison(page);
kunmap_atomic(addr);
- preempt_enable();
}
static void unpoison_pages(struct page *page, int n)
_
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH -v2] debug-pagealloc: add support for highmem pages
Date: Thu, 25 Aug 2011 17:03:02 -0700 [thread overview]
Message-ID: <20110825170302.81ed210c.akpm@linux-foundation.org> (raw)
In-Reply-To: <1314281649-21508-1-git-send-email-akinobu.mita@gmail.com>
On Thu, 25 Aug 2011 23:14:09 +0900
Akinobu Mita <akinobu.mita@gmail.com> wrote:
> This adds support for highmem pages poisoning and verification to the
> debug-pagealloc feature for no-architecture support.
>
Sorry, I had a brainfart. kmap_atomic() internally does the
preempt_disable() (actually pagefault_disable()).
--- a/mm/debug-pagealloc.c~debug-pagealloc-add-support-for-highmem-pages-fix
+++ a/mm/debug-pagealloc.c
@@ -23,14 +23,11 @@ static inline bool page_poison(struct pa
static void poison_page(struct page *page)
{
- void *addr;
+ void *addr = kmap_atomic(page);
- preempt_disable();
- addr = kmap_atomic(page);
set_page_poison(page);
memset(addr, PAGE_POISON, PAGE_SIZE);
kunmap_atomic(addr);
- preempt_enable();
}
static void poison_pages(struct page *page, int n)
@@ -82,12 +79,10 @@ static void unpoison_page(struct page *p
if (!page_poison(page))
return;
- preempt_disable();
addr = kmap_atomic(page);
check_poison_mem(addr, PAGE_SIZE);
clear_page_poison(page);
kunmap_atomic(addr);
- preempt_enable();
}
static void unpoison_pages(struct page *page, int n)
_
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-08-26 0:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 14:14 [PATCH -v2] debug-pagealloc: add support for highmem pages Akinobu Mita
2011-08-25 14:14 ` Akinobu Mita
2011-08-26 0:03 ` Andrew Morton [this message]
2011-08-26 0:03 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110825170302.81ed210c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=akinobu.mita@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.