All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/8] net: emaclite: Use dynamic allocation
Date: Fri, 26 Aug 2011 15:22:37 -0400	[thread overview]
Message-ID: <201108261522.38474.vapier@gentoo.org> (raw)
In-Reply-To: <1314362843-18214-5-git-send-email-monstr@monstr.eu>

On Friday, August 26, 2011 08:47:20 Michal Simek wrote:
>  	dev = calloc(1, sizeof(*dev));
>  	if (dev == NULL)
>  		return -1;
> 
> +	emaclite = calloc(1, sizeof(struct xemaclite));
> +	if (emaclite == NULL)
> +		return -1;

and you just leaked the dev alloc :)
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110826/57baf421/attachment.pgp 

  parent reply	other threads:[~2011-08-26 19:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-26 12:47 [U-Boot] [PATCH 1/8] net: emaclite: Change driver name and add address Michal Simek
2011-08-26 12:47 ` [U-Boot] [PATCH 2/8] net: emaclite: Remove deviceid property Michal Simek
2011-08-26 12:47   ` [U-Boot] [PATCH 3/8] net: emaclite: Use calloc instead of malloc Michal Simek
2011-08-26 12:47     ` [U-Boot] [PATCH 4/8] net: emaclite: Remove baseaddress from xemaclite Michal Simek
2011-08-26 12:47       ` [U-Boot] [PATCH 5/8] net: emaclite: Use dynamic allocation Michal Simek
2011-08-26 12:47         ` [U-Boot] [PATCH 6/8] net: emaclite: Setup RX/TX ping pong for every instance Michal Simek
2011-08-26 12:47           ` [U-Boot] [PATCH 7/8] net: emaclite: Free allocated space for device Michal Simek
2011-08-26 12:47             ` [U-Boot] [PATCH 8/8] net: emaclite: Move RX/TX ping pong initialization to board Michal Simek
2011-08-26 19:25             ` [U-Boot] [PATCH 7/8] net: emaclite: Free allocated space for device Mike Frysinger
2011-08-29  5:50               ` Michal Simek
2011-08-26 19:22         ` Mike Frysinger [this message]
2011-09-07 20:26       ` [U-Boot] [PATCH 4/8] net: emaclite: Remove baseaddress from xemaclite Wolfgang Denk
2011-08-26 19:24 ` [U-Boot] [PATCH 1/8] net: emaclite: Change driver name and add address Mike Frysinger
2011-08-29  5:49   ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108261522.38474.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.