From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/8] net: emaclite: Change driver name and add address
Date: Mon, 29 Aug 2011 07:49:37 +0200 [thread overview]
Message-ID: <4E5B2871.9000801@monstr.eu> (raw)
In-Reply-To: <201108261524.20308.vapier@gentoo.org>
Mike Frysinger wrote:
> On Friday, August 26, 2011 08:47:16 Michal Simek wrote:
>> - sprintf(dev->name, "Xilinx_Emaclite");
>> + sprintf(dev->name, "Xelite.%x", base_addr);
>
> you calculated this down to the byte huh ;). i see it uses the full 16.
Yes, I had to because eth_device has 16 chars array for it.
>
> do we have to worry about people who specify the device in their envs ? i'm
> guessing not if the current driver only supports one instance.
The whole point is to support several instances that's why I need to add
base address to name and fit to 16 chars.
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
prev parent reply other threads:[~2011-08-29 5:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 12:47 [U-Boot] [PATCH 1/8] net: emaclite: Change driver name and add address Michal Simek
2011-08-26 12:47 ` [U-Boot] [PATCH 2/8] net: emaclite: Remove deviceid property Michal Simek
2011-08-26 12:47 ` [U-Boot] [PATCH 3/8] net: emaclite: Use calloc instead of malloc Michal Simek
2011-08-26 12:47 ` [U-Boot] [PATCH 4/8] net: emaclite: Remove baseaddress from xemaclite Michal Simek
2011-08-26 12:47 ` [U-Boot] [PATCH 5/8] net: emaclite: Use dynamic allocation Michal Simek
2011-08-26 12:47 ` [U-Boot] [PATCH 6/8] net: emaclite: Setup RX/TX ping pong for every instance Michal Simek
2011-08-26 12:47 ` [U-Boot] [PATCH 7/8] net: emaclite: Free allocated space for device Michal Simek
2011-08-26 12:47 ` [U-Boot] [PATCH 8/8] net: emaclite: Move RX/TX ping pong initialization to board Michal Simek
2011-08-26 19:25 ` [U-Boot] [PATCH 7/8] net: emaclite: Free allocated space for device Mike Frysinger
2011-08-29 5:50 ` Michal Simek
2011-08-26 19:22 ` [U-Boot] [PATCH 5/8] net: emaclite: Use dynamic allocation Mike Frysinger
2011-09-07 20:26 ` [U-Boot] [PATCH 4/8] net: emaclite: Remove baseaddress from xemaclite Wolfgang Denk
2011-08-26 19:24 ` [U-Boot] [PATCH 1/8] net: emaclite: Change driver name and add address Mike Frysinger
2011-08-29 5:49 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5B2871.9000801@monstr.eu \
--to=monstr@monstr.eu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.