All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
To: Ben Hutchings <ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
Cc: Linus Torvalds
	<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	Neil Brown <neilb-l3A5Bk7waGM@public.gmane.org>,
	linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] All Arch: remove linkage for sys_nfsservctl system call
Date: Fri, 26 Aug 2011 19:52:01 -0400	[thread overview]
Message-ID: <20110826235201.GD18699@fieldses.org> (raw)
In-Reply-To: <20110826233258.GE24107-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>

On Sat, Aug 27, 2011 at 12:32:58AM +0100, Ben Hutchings wrote:
> On Fri, Aug 26, 2011 at 06:03:11PM -0400, J. Bruce Fields wrote:
> [...]
> > diff --git a/arch/sparc/kernel/systbls_64.S b/arch/sparc/kernel/systbls_64.S
> > index f566518..c9296ab 100644
> > --- a/arch/sparc/kernel/systbls_64.S
> > +++ b/arch/sparc/kernel/systbls_64.S
> > @@ -145,7 +145,7 @@ sys_call_table:
> >  	.word sys_fstatfs64, sys_llseek, sys_mlock, sys_munlock, sys_mlockall
> >  /*240*/	.word sys_munlockall, sys_sched_setparam, sys_sched_getparam, sys_sched_setscheduler, sys_sched_getscheduler
> >  	.word sys_sched_yield, sys_sched_get_priority_max, sys_sched_get_priority_min, sys_sched_rr_get_interval, sys_nanosleep
> > -/*250*/	.word sys_64_mremap, sys_sysctl, sys_getsid, sys_fdatasync, sys_nfsservctl
> > +/*250*/	.word sys_64_mremap, sys_sysctl, sys_getsid, sys_fdatasync, sys_nis_syscall
> [...]
>           	                                                                  ^
> This seems to be a typo for 'sys_ni_syscall'.

Is it?  On a quick skim, both seem to occur.  sys_nis_syscall seems to
point to c_sys_nis_syscall(), which prints a warning and returns
-ENOSYS.  I can't tell what sys_ni_syscall does.

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Neil Brown <neilb@suse.de>,
	linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org
Subject: Re: [PATCH] All Arch: remove linkage for sys_nfsservctl system call
Date: Fri, 26 Aug 2011 19:52:01 -0400	[thread overview]
Message-ID: <20110826235201.GD18699@fieldses.org> (raw)
Message-ID: <20110826235201.qWfpp09jP_MzeyOD0Ee1uDOKG-NraQdPEnrele6Eg6Y@z> (raw)
In-Reply-To: <20110826233258.GE24107@decadent.org.uk>

On Sat, Aug 27, 2011 at 12:32:58AM +0100, Ben Hutchings wrote:
> On Fri, Aug 26, 2011 at 06:03:11PM -0400, J. Bruce Fields wrote:
> [...]
> > diff --git a/arch/sparc/kernel/systbls_64.S b/arch/sparc/kernel/systbls_64.S
> > index f566518..c9296ab 100644
> > --- a/arch/sparc/kernel/systbls_64.S
> > +++ b/arch/sparc/kernel/systbls_64.S
> > @@ -145,7 +145,7 @@ sys_call_table:
> >  	.word sys_fstatfs64, sys_llseek, sys_mlock, sys_munlock, sys_mlockall
> >  /*240*/	.word sys_munlockall, sys_sched_setparam, sys_sched_getparam, sys_sched_setscheduler, sys_sched_getscheduler
> >  	.word sys_sched_yield, sys_sched_get_priority_max, sys_sched_get_priority_min, sys_sched_rr_get_interval, sys_nanosleep
> > -/*250*/	.word sys_64_mremap, sys_sysctl, sys_getsid, sys_fdatasync, sys_nfsservctl
> > +/*250*/	.word sys_64_mremap, sys_sysctl, sys_getsid, sys_fdatasync, sys_nis_syscall
> [...]
>           	                                                                  ^
> This seems to be a typo for 'sys_ni_syscall'.

Is it?  On a quick skim, both seem to occur.  sys_nis_syscall seems to
point to c_sys_nis_syscall(), which prints a warning and returns
-ENOSYS.  I can't tell what sys_ni_syscall does.

--b.

  parent reply	other threads:[~2011-08-26 23:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-08 13:29 [PATCH] headers, nfsd: Add missing #includes to <linux/nfsd/syscall.h> Ben Hutchings
2011-08-08 15:55 ` J. Bruce Fields
2011-08-08 18:06   ` Ben Hutchings
     [not found]     ` <20110808180658.GC29924-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
2011-08-26 22:03       ` [PATCH] All Arch: remove linkage for sys_nfsservctl system call J. Bruce Fields
2011-08-26 22:03         ` J. Bruce Fields
2011-08-26 23:32         ` Ben Hutchings
     [not found]           ` <20110826233258.GE24107-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>
2011-08-26 23:52             ` J. Bruce Fields [this message]
2011-08-26 23:52               ` J. Bruce Fields
2011-08-27  0:01           ` David Miller
2011-08-27 14:39         ` Mike Frysinger
2011-08-27 14:39           ` Mike Frysinger
2011-08-28 21:12         ` David Miller
2011-08-28 23:50         ` Tony Breeds
     [not found]         ` <20110826220311.GA18140-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2011-08-29 22:57           ` Stephen Rothwell
2011-08-29 22:57             ` Stephen Rothwell
2011-08-29 23:11             ` NeilBrown
     [not found]               ` <20110830091150.176cd08c-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2011-08-31 13:46                 ` J. Bruce Fields
2011-08-31 13:46                   ` J. Bruce Fields
2011-08-31 10:15         ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110826235201.GD18699@fieldses.org \
    --to=bfields-uc3wqj2krung9huczpvpmw@public.gmane.org \
    --cc=ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org \
    --cc=linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=neilb-l3A5Bk7waGM@public.gmane.org \
    --cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.