All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/85xx: Add workaround for erratum CPU-A011 on e500mc cores
Date: Sat, 27 Aug 2011 15:41:55 +0200	[thread overview]
Message-ID: <20110827134155.4D30211F9E69@gemini.denx.de> (raw)
In-Reply-To: <8D21ECF0-CB7E-4DDE-9F18-E1828FF5E8C2@kernel.crashing.org>

Dear Kumar Gala,

In message <8D21ECF0-CB7E-4DDE-9F18-E1828FF5E8C2@kernel.crashing.org> you wrote:
> 
> Any suggestions on how to do this? - comment it out?
> 
> /* #define CONFIG_SYS_FSL_ERRATUM_CPU_E500MC_A011 */

That would be dead code.

You don't want to add all possible #defines to your config files, do
you?  This is not a good weay to document your code.

Apropos documentation - I did not see that you explain
CONFIG_SYS_FSL_ERRATUM_CPU_E500MC_A011 (or any other of the ton of
CONFIG_SYS_FSL_ERRATUM_* you have) in the readme, or elsewehere.

_This_ is what you should fix.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The universe, they said, depended for its operation on the balance of
four forces which they identified as charm,  persuasion,  uncertainty
and bloody-mindedness.      -- Terry Pratchett, "The Light Fantastic"

  reply	other threads:[~2011-08-27 13:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-27 11:03 [U-Boot] [PATCH] powerpc/85xx: Add workaround for erratum CPU-A011 on e500mc cores Kumar Gala
2011-08-27 11:36 ` Wolfgang Denk
2011-08-27 12:01   ` Kumar Gala
2011-08-27 13:41     ` Wolfgang Denk [this message]
2011-08-27 16:09       ` Kumar Gala
2011-08-27 17:08         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110827134155.4D30211F9E69@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.