Re: [Qemu-devel] [PATCH 00/17] onenand, omap_gpmc fixes, features

["Edgar E. Iglesias" <edgar.iglesias@gmail.com>]

On Thu, Aug 25, 2011 at 09:04:54PM +0100, Peter Maydell wrote:
> This patchset is primarily features and bugfixes for the
> omap_gpmc device from the Meego tree.
> 
> We start by adding a new sysbus function to get the MemoryRegion*
> for a sysbus MMIO region. This was discussed in
>  http://www.mail-archive.com/kvm@vger.kernel.org/msg59535.html
> and as noted there can also be used to clean up other things,
> so it's not just an omap_gpmc thing.
> 
> The bulk of the onenand qdevification patch was in an earlier series
> I posted; this update makes it work with MemoryRegions.
> 
> The patches from "omap_gpmc: Take omap_mpu_state* in omap_gpmc_init"
> onwards are omap3 preparation; the features they add aren't used in
> the omap2 models currently in master. However I'd rather get things
> reviewed in more manageable chunks than save them all up for when I
> have omap3.c ready for commit...


This looks good to me except for some minor questions on:
[PATCH 02/17] hw/onenand: Qdevify

Cheers