From: Vasiliy Kulikov <segoon@openwall.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
kernel-hardening@lists.openwall.com,
Al Viro <viro@zeniv.linux.org.uk>,
David Rientjes <rientjes@google.com>,
Stephen Wilson <wilsons@start.ca>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, security@kernel.org
Subject: [kernel-hardening] Re: [PATCH v2] proc: fix races against execve() of /proc/PID/fd**
Date: Sun, 28 Aug 2011 13:31:56 +0400 [thread overview]
Message-ID: <20110828093156.GA6291@albatros> (raw)
In-Reply-To: <20110828092520.GA8537@sun>
Hi Cyrill,
On Sun, Aug 28, 2011 at 13:25 +0400, Cyrill Gorcunov wrote:
> On Sat, Aug 27, 2011 at 11:01:47PM +0400, Vasiliy Kulikov wrote:
> ...
> >
> > +static int proc_pid_fd_link_getattr(struct vfsmount *mnt, struct dentry *dentry,
> > + struct kstat *stat)
> > +{
> > + struct inode *inode = dentry->d_inode;
> > + struct task_struct *task = get_proc_task(inode);
> > + int rc;
> > +
>
> Are we sure if the task will be always valid here?
>
> if (!task)
> return -ENOENT;
No, you're right. It needs (task == NULL) check. Thank you!
--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
WARNING: multiple messages have this Message-ID (diff)
From: Vasiliy Kulikov <segoon@openwall.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
kernel-hardening@lists.openwall.com,
Al Viro <viro@zeniv.linux.org.uk>,
David Rientjes <rientjes@google.com>,
Stephen Wilson <wilsons@start.ca>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, security@kernel.org
Subject: Re: [PATCH v2] proc: fix races against execve() of /proc/PID/fd**
Date: Sun, 28 Aug 2011 13:31:56 +0400 [thread overview]
Message-ID: <20110828093156.GA6291@albatros> (raw)
In-Reply-To: <20110828092520.GA8537@sun>
Hi Cyrill,
On Sun, Aug 28, 2011 at 13:25 +0400, Cyrill Gorcunov wrote:
> On Sat, Aug 27, 2011 at 11:01:47PM +0400, Vasiliy Kulikov wrote:
> ...
> >
> > +static int proc_pid_fd_link_getattr(struct vfsmount *mnt, struct dentry *dentry,
> > + struct kstat *stat)
> > +{
> > + struct inode *inode = dentry->d_inode;
> > + struct task_struct *task = get_proc_task(inode);
> > + int rc;
> > +
>
> Are we sure if the task will be always valid here?
>
> if (!task)
> return -ENOENT;
No, you're right. It needs (task == NULL) check. Thank you!
--
Vasiliy Kulikov
http://www.openwall.com - bringing security into open computing environments
next prev parent reply other threads:[~2011-08-28 9:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 16:20 [kernel-hardening] [PATCH] proc: fix races of /proc/PID/{fd/,fdinfo/,fdinfo/*} Vasiliy Kulikov
2011-08-04 16:20 ` Vasiliy Kulikov
2011-08-23 21:44 ` [kernel-hardening] " Andrew Morton
2011-08-23 21:44 ` Andrew Morton
2011-08-26 13:29 ` [kernel-hardening] [PATCH] proc: fix races against execve() " Vasiliy Kulikov
2011-08-26 13:29 ` Vasiliy Kulikov
2011-08-26 19:40 ` [kernel-hardening] " Andrew Morton
2011-08-26 19:40 ` Andrew Morton
2011-08-27 19:01 ` [kernel-hardening] [PATCH v2] proc: fix races against execve() of /proc/PID/fd** Vasiliy Kulikov
2011-08-27 19:01 ` Vasiliy Kulikov
2011-08-27 19:08 ` [kernel-hardening] " Vasiliy Kulikov
2011-08-27 19:08 ` Vasiliy Kulikov
2011-08-28 9:25 ` [kernel-hardening] " Cyrill Gorcunov
2011-08-28 9:25 ` Cyrill Gorcunov
2011-08-28 9:31 ` Vasiliy Kulikov [this message]
2011-08-28 9:31 ` Vasiliy Kulikov
2011-08-29 18:00 ` [kernel-hardening] [PATCH v3] " Vasiliy Kulikov
2011-08-29 18:00 ` Vasiliy Kulikov
2011-08-29 23:00 ` [kernel-hardening] " Andrew Morton
2011-08-29 23:00 ` Andrew Morton
2011-08-29 23:02 ` [kernel-hardening] " Andrew Morton
2011-08-29 23:02 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110828093156.GA6291@albatros \
--to=segoon@openwall.com \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@gmail.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=security@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wilsons@start.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.