From: Paul Mundt <lethal@linux-sh.org>
To: "Koul, Vinod" <vinod.koul@intel.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Magnus Damm <damm@opensource.se>
Subject: Re: [PATCH] serial: sh-sci: don't filter on DMA device, use only channel ID
Date: Mon, 29 Aug 2011 08:00:47 +0000 [thread overview]
Message-ID: <20110829080047.GJ31809@linux-sh.org> (raw)
In-Reply-To: <1308916071.1536.4.camel@vkoul-udesk3>
On Fri, Jun 24, 2011 at 05:17:51PM +0530, Koul, Vinod wrote:
> On Fri, 2011-06-24 at 13:56 +0200, Guennadi Liakhovetski wrote:
> > On some sh-mobile systems there are more than one DMA controllers, that
> > can be used for serial ports. Specifying a DMA device in sh-sci platform
> > data unnecessarily restricts the driver to only use one DMA controller.
> >
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > ---
> > drivers/tty/serial/sh-sci.c | 25 ++++++++-----------------
> > include/linux/serial_sci.h | 2 --
> > 2 files changed, 8 insertions(+), 19 deletions(-)
> >
> > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> > index ebd8629..8711f4e 100644
> > --- a/drivers/tty/serial/sh-sci.c
> > +++ b/drivers/tty/serial/sh-sci.c
> > @@ -1295,12 +1295,8 @@ static bool filter(struct dma_chan *chan, void *slave)
> > dev_dbg(chan->device->dev, "%s: slave ID %d\n", __func__,
> > param->slave_id);
> >
> > - if (param->dma_dev = chan->device->dev) {
> > - chan->private = param;
> > - return true;
> > - } else {
> > - return false;
> > - }
> > + chan->private = param;
> > + return true;
> You should not assign chan->private.
> Please move this to dma_slave_control API
I haven't seen any reply to this comment and this patch seems to still be
outstanding, is there an updated version of this patch that I've missed?
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: "Koul, Vinod" <vinod.koul@intel.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Magnus Damm <damm@opensource.se>
Subject: Re: [PATCH] serial: sh-sci: don't filter on DMA device, use only channel ID
Date: Mon, 29 Aug 2011 17:00:47 +0900 [thread overview]
Message-ID: <20110829080047.GJ31809@linux-sh.org> (raw)
In-Reply-To: <1308916071.1536.4.camel@vkoul-udesk3>
On Fri, Jun 24, 2011 at 05:17:51PM +0530, Koul, Vinod wrote:
> On Fri, 2011-06-24 at 13:56 +0200, Guennadi Liakhovetski wrote:
> > On some sh-mobile systems there are more than one DMA controllers, that
> > can be used for serial ports. Specifying a DMA device in sh-sci platform
> > data unnecessarily restricts the driver to only use one DMA controller.
> >
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > ---
> > drivers/tty/serial/sh-sci.c | 25 ++++++++-----------------
> > include/linux/serial_sci.h | 2 --
> > 2 files changed, 8 insertions(+), 19 deletions(-)
> >
> > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> > index ebd8629..8711f4e 100644
> > --- a/drivers/tty/serial/sh-sci.c
> > +++ b/drivers/tty/serial/sh-sci.c
> > @@ -1295,12 +1295,8 @@ static bool filter(struct dma_chan *chan, void *slave)
> > dev_dbg(chan->device->dev, "%s: slave ID %d\n", __func__,
> > param->slave_id);
> >
> > - if (param->dma_dev == chan->device->dev) {
> > - chan->private = param;
> > - return true;
> > - } else {
> > - return false;
> > - }
> > + chan->private = param;
> > + return true;
> You should not assign chan->private.
> Please move this to dma_slave_control API
I haven't seen any reply to this comment and this patch seems to still be
outstanding, is there an updated version of this patch that I've missed?
next prev parent reply other threads:[~2011-08-29 8:00 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 11:56 [PATCH] serial: sh-sci: don't filter on DMA device, use only channel Guennadi Liakhovetski
2011-06-24 11:56 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only channel ID Guennadi Liakhovetski
2011-06-24 11:47 ` Koul, Vinod
2011-06-24 11:59 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only Koul, Vinod
2011-08-29 8:00 ` Paul Mundt [this message]
2011-08-29 8:00 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only channel ID Paul Mundt
2011-08-29 8:16 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only Magnus Damm
2011-08-29 8:16 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only channel ID Magnus Damm
2011-08-29 11:55 ` Vinod Koul
2011-08-29 11:56 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only Vinod Koul
2011-08-30 7:54 ` Guennadi Liakhovetski
2011-08-30 7:54 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only channel ID Guennadi Liakhovetski
2011-08-30 10:02 ` Vinod Koul
2011-08-30 10:14 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only Vinod Koul
2011-08-30 11:20 ` Guennadi Liakhovetski
2011-08-30 11:20 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only channel ID Guennadi Liakhovetski
2011-08-30 11:23 ` Vinod Koul
2011-08-30 11:35 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only Vinod Koul
2011-08-30 11:40 ` Guennadi Liakhovetski
2011-08-30 11:40 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only channel ID Guennadi Liakhovetski
2011-09-05 8:04 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only Guennadi Liakhovetski
2011-09-05 8:04 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only channel ID Guennadi Liakhovetski
2011-09-05 13:13 ` Vinod Koul
2011-09-05 13:25 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only Vinod Koul
2011-09-05 13:48 ` Guennadi Liakhovetski
2011-09-05 13:48 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only channel ID Guennadi Liakhovetski
2011-09-05 14:43 ` Vinod Koul
2011-09-05 14:55 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only Vinod Koul
2011-09-05 15:01 ` Guennadi Liakhovetski
2011-09-05 15:01 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only channel ID Guennadi Liakhovetski
2011-09-05 15:08 ` Vinod Koul
2011-09-05 15:20 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only Vinod Koul
2011-09-05 15:21 ` Guennadi Liakhovetski
2011-09-05 15:21 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only channel ID Guennadi Liakhovetski
2011-09-07 18:42 ` Koul, Vinod
2011-09-07 18:54 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only Koul, Vinod
2011-09-07 20:01 ` Guennadi Liakhovetski
2011-09-07 20:01 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only channel ID Guennadi Liakhovetski
2011-09-07 21:37 ` Koul, Vinod
2011-09-07 21:49 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only Koul, Vinod
2011-09-08 1:21 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only channel ID Paul Mundt
2011-09-08 1:21 ` Paul Mundt
2011-09-08 19:31 ` Vinod Koul
2011-09-08 19:43 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only Vinod Koul
2011-09-14 5:16 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only channel ID Vinod Koul
2011-09-14 5:28 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only Vinod Koul
2011-09-14 18:52 ` Alan Cox
2011-09-14 18:52 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only channel ID Alan Cox
2011-09-19 3:13 ` Vinod Koul
2011-09-19 3:25 ` [PATCH] serial: sh-sci: don't filter on DMA device, use only Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110829080047.GJ31809@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=damm@opensource.se \
--cc=dan.j.williams@intel.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.