From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Richard Zhu <richard.zhu@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, jgarzik@pobox.com,
kernel@pengutronix.de, linux-ide@vger.kernel.org,
eric@eukrea.com, eric.miao@linaro.org
Subject: Re: [PATCH V6 2/5] ahci_plt Add the board_ids and pi refer to different features
Date: Mon, 29 Aug 2011 16:12:14 +0400 [thread overview]
Message-ID: <20110829121214.GA15484@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1314602339-18392-2-git-send-email-richard.zhu@linaro.org>
Hello,
On Mon, Aug 29, 2011 at 03:18:55PM +0800, Richard Zhu wrote:
> On imx53 AHCI, soft reset fails with IPMS set when PMP
> is enabled but SATA HDD/ODD is connected to SATA port,
> do soft reset again to port 0.
> So the 'ahci_pmp_retry_srst_ops' is required when imx53
> ahci is present.
>
> Signed-off-by: Richard Zhu <richard.zhu@linaro.org>
> ---
[...]
> struct device *dev = &pdev->dev;
> struct ahci_platform_data *pdata = dev->platform_data;
> - struct ata_port_info pi = {
> - .flags = AHCI_FLAG_COMMON,
> - .pio_mask = ATA_PIO4,
> - .udma_mask = ATA_UDMA6,
> - .port_ops = &ahci_ops,
> - };
> + struct platform_device_id *id_entry = platform_get_device_id(pdev);
> + struct ata_port_info pi = ahci_port_info[id_entry->driver_data];
Why not pass port info via platform_data? It seems to be platform
specific nowadays, so leave the default as is, but let the platforms
pass their own port info through platform_data.
Thanks,
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
WARNING: multiple messages have this Message-ID (diff)
From: cbouatmailru@gmail.com (Anton Vorontsov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V6 2/5] ahci_plt Add the board_ids and pi refer to different features
Date: Mon, 29 Aug 2011 16:12:14 +0400 [thread overview]
Message-ID: <20110829121214.GA15484@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1314602339-18392-2-git-send-email-richard.zhu@linaro.org>
Hello,
On Mon, Aug 29, 2011 at 03:18:55PM +0800, Richard Zhu wrote:
> On imx53 AHCI, soft reset fails with IPMS set when PMP
> is enabled but SATA HDD/ODD is connected to SATA port,
> do soft reset again to port 0.
> So the 'ahci_pmp_retry_srst_ops' is required when imx53
> ahci is present.
>
> Signed-off-by: Richard Zhu <richard.zhu@linaro.org>
> ---
[...]
> struct device *dev = &pdev->dev;
> struct ahci_platform_data *pdata = dev->platform_data;
> - struct ata_port_info pi = {
> - .flags = AHCI_FLAG_COMMON,
> - .pio_mask = ATA_PIO4,
> - .udma_mask = ATA_UDMA6,
> - .port_ops = &ahci_ops,
> - };
> + struct platform_device_id *id_entry = platform_get_device_id(pdev);
> + struct ata_port_info pi = ahci_port_info[id_entry->driver_data];
Why not pass port info via platform_data? It seems to be platform
specific nowadays, so leave the default as is, but let the platforms
pass their own port info through platform_data.
Thanks,
--
Anton Vorontsov
Email: cbouatmailru at gmail.com
next prev parent reply other threads:[~2011-08-29 12:12 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 7:18 [PATCH V6 1/5] AHCI Add the AHCI SATA feature on the MX53 platforms Richard Zhu
2011-08-29 7:18 ` Richard Zhu
2011-08-29 7:18 ` [PATCH V6 2/5] ahci_plt Add the board_ids and pi refer to different features Richard Zhu
2011-08-29 7:18 ` Richard Zhu
2011-08-29 8:31 ` Eric Miao
2011-08-29 8:31 ` Eric Miao
2011-08-29 8:36 ` Wolfram Sang
2011-08-29 8:36 ` Wolfram Sang
2011-08-29 8:51 ` Eric Miao
2011-08-29 8:51 ` Eric Miao
2011-08-29 9:37 ` Wolfram Sang
2011-08-29 9:37 ` Wolfram Sang
2011-08-29 9:54 ` Eric Miao
2011-08-29 9:54 ` Eric Miao
2011-08-29 11:02 ` Wolfram Sang
2011-08-29 11:02 ` Wolfram Sang
2011-08-29 12:12 ` Anton Vorontsov [this message]
2011-08-29 12:12 ` Anton Vorontsov
2011-08-29 12:25 ` Eric Miao
2011-08-29 12:25 ` Eric Miao
2011-08-30 6:21 ` Richard Zhu
2011-08-30 6:21 ` Richard Zhu
2011-08-30 6:35 ` Eric Miao
2011-08-30 6:35 ` Eric Miao
2011-08-30 7:07 ` Richard Zhu
2011-08-30 7:07 ` Richard Zhu
2011-08-30 8:54 ` Richard Zhu
2011-08-30 8:54 ` Richard Zhu
2011-08-30 9:07 ` Eric Miao
2011-08-30 9:07 ` Eric Miao
2011-08-29 7:18 ` [PATCH V6 3/5] MX53 Enable the AHCI SATA on MX53 ARD board Richard Zhu
2011-08-29 7:18 ` Richard Zhu
2011-08-29 8:47 ` Eric Miao
2011-08-29 8:47 ` Eric Miao
2011-08-29 9:16 ` Richard Zhu
2011-08-29 9:16 ` Richard Zhu
2011-08-29 7:18 ` [PATCH V6 4/5] MX53 Enable the AHCI SATA on MX53 LOCO board Richard Zhu
2011-08-29 7:18 ` Richard Zhu
2011-08-29 7:18 ` [PATCH V6 5/5] MX53 Enable the AHCI SATA on MX53 SMD board Richard Zhu
2011-08-29 7:18 ` Richard Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110829121214.GA15484@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=eric.miao@linaro.org \
--cc=eric@eukrea.com \
--cc=jgarzik@pobox.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=richard.zhu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.