From: Kevin O'Connor <kevin@koconnor.net>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Andrew Theurer <habanero@linux.vnet.ibm.com>,
Gleb Natapov <gleb@redhat.com>, seabios <seabios@seabios.org>,
ya su <suya94335@gmail.com>, Alexander Graf <agraf@suse.de>,
qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Probe HPET existence
Date: Mon, 29 Aug 2011 20:35:45 -0400 [thread overview]
Message-ID: <20110830003545.GA17142@morn.localdomain> (raw)
In-Reply-To: <4E5BB532.4010106@siemens.com>
On Mon, Aug 29, 2011 at 05:50:10PM +0200, Jan Kiszka wrote:
> QEMU does not provide a HPET block if it was configured with -no-hpet,
> other machines SeaBIOS runs on may lack a HPET as well. Perform basic
> checks the ID register for a reasonable vendor ID and a clock period
> within the valid range, do not build the HPET table if that fails.
It looks okay to me.
BTW, any particular reason to use 0x05F5E100 instead of 100000000?
-Kevin
next prev parent reply other threads:[~2011-08-30 0:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 15:50 [Qemu-devel] [PATCH] Probe HPET existence Jan Kiszka
2011-08-30 0:35 ` Kevin O'Connor [this message]
2011-08-31 16:45 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110830003545.GA17142@morn.localdomain \
--to=kevin@koconnor.net \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=habanero@linux.vnet.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
--cc=suya94335@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.