From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Joe Thornber <thornber@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
xfs@oss.sgi.com, Christoph Hellwig <hch@infradead.org>,
xfs-masters@oss.sgi.com,
device-mapper development <dm-devel@redhat.com>,
Mikulas Patocka <mpatocka@redhat.com>,
"Alasdair G. Kergon" <agk@redhat.com>
Subject: Re: [xfs-masters] new dm-bufio
Date: Tue, 30 Aug 2011 01:27:55 -0400 [thread overview]
Message-ID: <20110830052755.GA30730@infradead.org> (raw)
In-Reply-To: <20110830014906.GJ3162@dastard>
On Tue, Aug 30, 2011 at 11:49:06AM +1000, Dave Chinner wrote:
>
> It's a relic from the days of Irix that we've kept around and never
> really touched because it's never shown up as a problem. Such code
> is cleaned up as we go along or as problems arise.
>
> As it is, this patchset:
>
> http://thread.gmane.org/gmane.linux.kernel.mm/67326
>
> that I'm currently working on changes the shrinker API to be much
> more sane - the shrinker now has a separate "count objects"
> operation and the "scan objects" operation now returns the number of
> items freed rather than the number of items left in the cache.
I think if you find bugs like that they should be in patches separate
from the main conversion. Especially given that the 3.2 merge window
is getting closer a first batch of patches with these fixes and some
of the preparatory icache/dcache changes that can go into linux-next
ASAP would be nice.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Joe Thornber <thornber@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
xfs@oss.sgi.com, Christoph Hellwig <hch@infradead.org>,
xfs-masters@oss.sgi.com,
device-mapper development <dm-devel@redhat.com>,
Mikulas Patocka <mpatocka@redhat.com>,
"Alasdair G. Kergon" <agk@redhat.com>
Subject: Re: [xfs-masters] [dm-devel] new dm-bufio
Date: Tue, 30 Aug 2011 01:27:55 -0400 [thread overview]
Message-ID: <20110830052755.GA30730@infradead.org> (raw)
In-Reply-To: <20110830014906.GJ3162@dastard>
On Tue, Aug 30, 2011 at 11:49:06AM +1000, Dave Chinner wrote:
>
> It's a relic from the days of Irix that we've kept around and never
> really touched because it's never shown up as a problem. Such code
> is cleaned up as we go along or as problems arise.
>
> As it is, this patchset:
>
> http://thread.gmane.org/gmane.linux.kernel.mm/67326
>
> that I'm currently working on changes the shrinker API to be much
> more sane - the shrinker now has a separate "count objects"
> operation and the "scan objects" operation now returns the number of
> items freed rather than the number of items left in the cache.
I think if you find bugs like that they should be in patches separate
from the main conversion. Especially given that the 3.2 merge window
is getting closer a first batch of patches with these fixes and some
of the preparatory icache/dcache changes that can go into linux-next
ASAP would be nice.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-08-30 5:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 20:05 new dm-bufio Mikulas Patocka
2011-08-23 11:30 ` Joe Thornber
2011-08-23 11:44 ` Alasdair G Kergon
2011-08-23 14:16 ` Mikulas Patocka
2011-08-23 18:54 ` Christoph Hellwig
2011-08-29 18:53 ` Mikulas Patocka
2011-08-29 18:53 ` [dm-devel] " Mikulas Patocka
2011-08-30 1:49 ` [xfs-masters] " Dave Chinner
2011-08-30 1:49 ` [xfs-masters] [dm-devel] " Dave Chinner
2011-08-30 5:27 ` Christoph Hellwig [this message]
2011-08-30 5:27 ` Christoph Hellwig
2011-08-24 11:13 ` Joe Thornber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110830052755.GA30730@infradead.org \
--to=hch@infradead.org \
--cc=agk@redhat.com \
--cc=david@fromorbit.com \
--cc=dm-devel@redhat.com \
--cc=mpatocka@redhat.com \
--cc=snitzer@redhat.com \
--cc=thornber@redhat.com \
--cc=xfs-masters@oss.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.