From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Keerthy <j-keerthy@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Jean Delvare <khali@linux-fr.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver
Date: Wed, 31 Aug 2011 18:49:39 -0700 [thread overview]
Message-ID: <20110901014939.GB21986@ericsson.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1108311810280.26173@utopia.booyaka.com>
On Wed, Aug 31, 2011 at 08:36:43PM -0400, Paul Walmsley wrote:
> Hi
>
> Some comments.
>
> On Wed, 31 Aug 2011, Keerthy wrote:
>
[ ... ]
>
> > +}
> > +
> > +/* Sysfs hook functions */
>
> These should be conditionally compiled out if sysfs isn't compiled in.
>
The whole point of the hwmon subsystem is to expose hardware monitoring information
to userland using sysfs. hwmon without sysfs doesn't make sense.
So, if anything, it might make sense to disable the entire hwmon tree if sysfs is disabled.
But please no conditionals in the code.
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Keerthy <j-keerthy@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Jean Delvare <khali@linux-fr.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] [PATCH 6/6 V4] hwmon: OMAP4: On die temperature
Date: Thu, 01 Sep 2011 01:49:39 +0000 [thread overview]
Message-ID: <20110901014939.GB21986@ericsson.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1108311810280.26173@utopia.booyaka.com>
On Wed, Aug 31, 2011 at 08:36:43PM -0400, Paul Walmsley wrote:
> Hi
>
> Some comments.
>
> On Wed, 31 Aug 2011, Keerthy wrote:
>
[ ... ]
>
> > +}
> > +
> > +/* Sysfs hook functions */
>
> These should be conditionally compiled out if sysfs isn't compiled in.
>
The whole point of the hwmon subsystem is to expose hardware monitoring information
to userland using sysfs. hwmon without sysfs doesn't make sense.
So, if anything, it might make sense to disable the entire hwmon tree if sysfs is disabled.
But please no conditionals in the code.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2011-09-01 1:50 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 17:25 [PATCH 0/6 V4] OMAP4: Temperature sensor driver Keerthy
2011-08-31 17:25 ` [PATCH 1/6 V4] OMAP4: Clock: Associate clocks for OMAP temperature sensor Keerthy
2011-09-01 0:00 ` Paul Walmsley
2011-09-02 7:12 ` Rajendra Nayak
2011-08-31 17:25 ` [PATCH 2/6 V4] OMAP4: Adding the temperature sensor register set bit fields Keerthy
2011-09-01 0:04 ` Paul Walmsley
2011-09-01 2:57 ` J, KEERTHY
2011-08-31 17:25 ` [PATCH 3/6 V4] OMAP4460: Temperature sensor data Keerthy
2011-08-31 17:25 ` [PATCH 4/6 V4] OMAP4: Hwmod: OMAP temperature sensor Keerthy
2011-08-31 23:16 ` Paul Walmsley
2011-09-06 18:24 ` J, KEERTHY
2011-08-31 17:25 ` [PATCH 5/6 V4] OMAP4: Temperature sensor device support Keerthy
2011-09-09 9:28 ` Jean Pihet
2011-08-31 17:25 ` [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver Keerthy
2011-08-31 17:37 ` [lm-sensors] [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor Keerthy
2011-08-31 23:56 ` [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver Paul Walmsley
2011-08-31 23:56 ` [lm-sensors] [PATCH 6/6 V4] hwmon: OMAP4: On die temperature Paul Walmsley
2011-09-06 11:49 ` [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver J, KEERTHY
2011-09-06 11:52 ` [lm-sensors] [PATCH 6/6 V4] hwmon: OMAP4: On die temperature J, KEERTHY
2011-09-01 0:36 ` [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver Paul Walmsley
2011-09-01 0:36 ` [lm-sensors] [PATCH 6/6 V4] hwmon: OMAP4: On die temperature Paul Walmsley
2011-09-01 1:49 ` Guenter Roeck [this message]
2011-09-01 1:49 ` Guenter Roeck
2011-09-01 4:09 ` [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver Paul Walmsley
2011-09-01 4:09 ` [lm-sensors] [PATCH 6/6 V4] hwmon: OMAP4: On die temperature Paul Walmsley
2011-09-01 4:40 ` [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver Guenter Roeck
2011-09-01 4:40 ` [lm-sensors] [PATCH 6/6 V4] hwmon: OMAP4: On die temperature Guenter Roeck
2011-09-06 18:02 ` [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver J, KEERTHY
2011-09-06 18:14 ` [lm-sensors] [PATCH 6/6 V4] hwmon: OMAP4: On die temperature J, KEERTHY
2011-09-06 18:12 ` [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver Guenter Roeck
2011-09-06 18:12 ` [lm-sensors] [PATCH 6/6 V4] hwmon: OMAP4: On die temperature Guenter Roeck
2011-09-06 18:41 ` [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver J, KEERTHY
2011-09-06 18:53 ` [lm-sensors] [PATCH 6/6 V4] hwmon: OMAP4: On die temperature J, KEERTHY
2011-09-07 14:32 ` [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver J, KEERTHY
2011-09-07 14:44 ` [lm-sensors] [PATCH 6/6 V4] hwmon: OMAP4: On die temperature J, KEERTHY
2011-09-08 18:39 ` [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver Mark Brown
2011-09-08 18:39 ` [lm-sensors] [PATCH 6/6 V4] hwmon: OMAP4: On die temperature Mark Brown
2011-09-06 17:57 ` [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver J, KEERTHY
2011-09-06 17:58 ` [lm-sensors] [PATCH 6/6 V4] hwmon: OMAP4: On die temperature J, KEERTHY
2011-09-06 17:50 ` [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver J, KEERTHY
2011-09-06 17:53 ` [lm-sensors] [PATCH 6/6 V4] hwmon: OMAP4: On die temperature J, KEERTHY
2011-09-01 4:38 ` [PATCH 6/6 V4] hwmon: OMAP4: On die temperature sensor driver Guenter Roeck
2011-09-01 4:38 ` [lm-sensors] [PATCH 6/6 V4] hwmon: OMAP4: On die temperature Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110901014939.GB21986@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=j-keerthy@ti.com \
--cc=khali@linux-fr.org \
--cc=linux-omap@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.