From: Tejun Heo <tj@kernel.org>
To: Ripduman Sohan <ripduman.sohan@cl.cam.ac.uk>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org
Subject: Re: [PATCH] workqueue: Restore cpus_allowed mask for sleeping workqueue rescue threads
Date: Fri, 2 Sep 2011 09:29:17 +0900 [thread overview]
Message-ID: <20110902002917.GD2752@htj.dyndns.org> (raw)
In-Reply-To: <1314884193-20454-1-git-send-email-ripduman.sohan@cl.cam.ac.uk>
Hello,
On Thu, Sep 01, 2011 at 02:36:33PM +0100, Ripduman Sohan wrote:
> Rescuer threads may be migrated (and are bound) to particular CPUs when
> active. However, the allowed_cpus mask is not restored when they return
> to sleep rendering inconsistent the presented and actual set of CPUs the
> process may potentially run on. This patch fixes this oversight by
> recording the allowed_cpus mask for rescuer threads when it enters the
> rescuer_thread() main loop and restoring it every time the thread sleeps.
Hmmm... so, currently, rescuer is left bound to the last cpu it worked
on. Why is this a problem?
Thanks.
--
tejun
next prev parent reply other threads:[~2011-09-02 0:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 13:36 [PATCH] workqueue: Restore cpus_allowed mask for sleeping workqueue rescue threads Ripduman Sohan
2011-09-02 0:29 ` Tejun Heo [this message]
2011-09-15 16:14 ` Ripduman Sohan
2011-09-17 0:29 ` Tejun Heo
2011-09-18 6:36 ` Gilad Ben-Yossef
2011-09-24 3:07 ` Tejun Heo
2011-09-25 6:02 ` Gilad Ben-Yossef
2011-09-30 8:09 ` Tejun Heo
2011-09-30 8:54 ` Ripduman Sohan
2011-09-30 8:57 ` Tejun Heo
2011-09-30 8:59 ` Ripduman Sohan
2011-10-01 1:10 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2011-08-31 13:17 Ripduman Sohan
2011-08-31 15:20 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110902002917.GD2752@htj.dyndns.org \
--to=tj@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=ripduman.sohan@cl.cam.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.