From: Ripduman Sohan <Ripduman.Sohan@cl.cam.ac.uk>
To: Tejun Heo <tj@kernel.org>
Cc: Gilad Ben-Yossef <gilad@benyossef.com>,
linux-kernel@vger.kernel.org, peterz@infradead.org
Subject: Re: [PATCH] workqueue: Restore cpus_allowed mask for sleeping workqueue rescue threads
Date: Fri, 30 Sep 2011 09:54:21 +0100 [thread overview]
Message-ID: <20110930085421.GA11756@tusker> (raw)
In-Reply-To: <20110930080914.GM10425@mtj.dyndns.org>
Tejun Heo <tj@kernel.org> wrote:
> Hmmm... indeed. This can cause an unnecessary wakeup / migration on
> an isolated CPU when another CPU asks for the rescuer, so yeah it
> makes sense to change the behavior. BTW, why didn't the original
> patch simply use set_cpus_allowed_ptr(cpu_all_mask)?
>
Because while at present all (bound) rescuer threads have an associated workqueue on each CPU, I didn't want to assume this arrangement would _always_ be the case. It was my thinking that for bound threads, iterating over the CPUs to only set those that have an associated workqueue for the rescuer would insulate agsinst any future case where rescuer threads may be bound to a subset of CPUs.
Kind regards,
--rip
next prev parent reply other threads:[~2011-09-30 8:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 13:36 [PATCH] workqueue: Restore cpus_allowed mask for sleeping workqueue rescue threads Ripduman Sohan
2011-09-02 0:29 ` Tejun Heo
2011-09-15 16:14 ` Ripduman Sohan
2011-09-17 0:29 ` Tejun Heo
2011-09-18 6:36 ` Gilad Ben-Yossef
2011-09-24 3:07 ` Tejun Heo
2011-09-25 6:02 ` Gilad Ben-Yossef
2011-09-30 8:09 ` Tejun Heo
2011-09-30 8:54 ` Ripduman Sohan [this message]
2011-09-30 8:57 ` Tejun Heo
2011-09-30 8:59 ` Ripduman Sohan
2011-10-01 1:10 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2011-08-31 13:17 Ripduman Sohan
2011-08-31 15:20 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110930085421.GA11756@tusker \
--to=ripduman.sohan@cl.cam.ac.uk \
--cc=gilad@benyossef.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.