All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Prasad Joshi <prasadjoshi.linux@gmail.com>
Cc: Chaitanya Kulkarni <chaitanyakulkarni15@gmail.com>,
	xfs@oss.sgi.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] Assume yes when test device is not partitioned
Date: Sat, 3 Sep 2011 13:52:59 -0400	[thread overview]
Message-ID: <20110903175259.GA3461@thunk.org> (raw)
In-Reply-To: <1315038723-2009-1-git-send-email-prasadjoshi.linux@gmail.com>

On Sat, Sep 03, 2011 at 02:02:03PM +0530, Prasad Joshi wrote:
> @@ -333,7 +333,7 @@ _scratch_mkfs_sized()
>  	_scratch_mkfs_xfs -d size=$fssize -b size=$blocksize
>  	;;
>      ext2|ext3|ext4|ext4dev)
> -	/sbin/mkfs.$FSTYP $MKFS_OPTIONS -b $blocksize $SCRATCH_DEV $blocks
> +	yes | ${MKFS_PROG}.$FSTYP $MKFS_OPTIONS -b $blocksize $SCRATCH_DEV $blocks
>  	;;
>      btrfs)
>  	$MKFS_BTRFS_PROG $MKFS_OPTIONS -b $fssize $SCRATCH_DEV

Why don't you just pass -f to mke2fs.ext[234]?

							- Ted

WARNING: multiple messages have this Message-ID (diff)
From: "Ted Ts'o" <tytso@mit.edu>
To: Prasad Joshi <prasadjoshi.linux@gmail.com>
Cc: linux-ext4@vger.kernel.org,
	Chaitanya Kulkarni <chaitanyakulkarni15@gmail.com>,
	xfs@oss.sgi.com
Subject: Re: [PATCH] Assume yes when test device is not partitioned
Date: Sat, 3 Sep 2011 13:52:59 -0400	[thread overview]
Message-ID: <20110903175259.GA3461@thunk.org> (raw)
In-Reply-To: <1315038723-2009-1-git-send-email-prasadjoshi.linux@gmail.com>

On Sat, Sep 03, 2011 at 02:02:03PM +0530, Prasad Joshi wrote:
> @@ -333,7 +333,7 @@ _scratch_mkfs_sized()
>  	_scratch_mkfs_xfs -d size=$fssize -b size=$blocksize
>  	;;
>      ext2|ext3|ext4|ext4dev)
> -	/sbin/mkfs.$FSTYP $MKFS_OPTIONS -b $blocksize $SCRATCH_DEV $blocks
> +	yes | ${MKFS_PROG}.$FSTYP $MKFS_OPTIONS -b $blocksize $SCRATCH_DEV $blocks
>  	;;
>      btrfs)
>  	$MKFS_BTRFS_PROG $MKFS_OPTIONS -b $fssize $SCRATCH_DEV

Why don't you just pass -f to mke2fs.ext[234]?

							- Ted

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2011-09-03 17:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-03  8:32 [PATCH] Assume yes when test device is not partitioned Prasad Joshi
2011-09-03  8:32 ` Prasad Joshi
2011-09-03 17:14 ` Christoph Hellwig
2011-09-03 17:14   ` Christoph Hellwig
2011-09-03 17:52 ` Ted Ts'o [this message]
2011-09-03 17:52   ` Ted Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110903175259.GA3461@thunk.org \
    --to=tytso@mit.edu \
    --cc=chaitanyakulkarni15@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=prasadjoshi.linux@gmail.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.