From: "Ted Ts'o" <tytso@mit.edu>
To: Dan Carpenter <error27@gmail.com>
Cc: "open list:JOURNALLING LAYER..." <linux-ext4@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] jbd2: remove an unneeded NULL check
Date: Sun, 04 Sep 2011 14:15:02 +0000 [thread overview]
Message-ID: <20110904141502.GF3461@thunk.org> (raw)
In-Reply-To: <20110826091931.GM5975@shale.localdomain>
On Fri, Aug 26, 2011 at 12:19:31PM +0300, Dan Carpenter wrote:
> We dereference "transaction" at the start of the function so the NULL
> check isn't needed here. It's not harmful, but it silences a static
> checker warning when we remove this.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Thanks for pointing this out; I've merged in the fix.
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: Ted Ts'o <tytso@mit.edu>
To: Dan Carpenter <error27@gmail.com>
Cc: "open list:JOURNALLING LAYER..." <linux-ext4@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] jbd2: remove an unneeded NULL check
Date: Sun, 4 Sep 2011 10:15:02 -0400 [thread overview]
Message-ID: <20110904141502.GF3461@thunk.org> (raw)
In-Reply-To: <20110826091931.GM5975@shale.localdomain>
On Fri, Aug 26, 2011 at 12:19:31PM +0300, Dan Carpenter wrote:
> We dereference "transaction" at the start of the function so the NULL
> check isn't needed here. It's not harmful, but it silences a static
> checker warning when we remove this.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Thanks for pointing this out; I've merged in the fix.
- Ted
next prev parent reply other threads:[~2011-09-04 14:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 9:19 [patch 1/2] jbd2: remove an unneeded NULL check Dan Carpenter
2011-08-26 9:19 ` Dan Carpenter
2011-09-04 14:15 ` Ted Ts'o [this message]
2011-09-04 14:15 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110904141502.GF3461@thunk.org \
--to=tytso@mit.edu \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.