* [PATCH] ASoC: Add missing platform_device_put in raumfeld_audio_init error path
@ 2011-09-02 13:47 Axel Lin
2011-09-02 14:03 ` Girdwood, Liam
2011-09-04 15:55 ` Mark Brown
0 siblings, 2 replies; 8+ messages in thread
From: Axel Lin @ 2011-09-02 13:47 UTC (permalink / raw)
To: linux-kernel; +Cc: Daniel Mack, Liam Girdwood, Mark Brown, alsa-devel
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/pxa/raumfeld.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/sound/soc/pxa/raumfeld.c b/sound/soc/pxa/raumfeld.c
index 1a591f1..b899a3b 100644
--- a/sound/soc/pxa/raumfeld.c
+++ b/sound/soc/pxa/raumfeld.c
@@ -306,8 +306,10 @@ static int __init raumfeld_audio_init(void)
&snd_soc_raumfeld_connector);
ret = platform_device_add(raumfeld_audio_device);
- if (ret < 0)
+ if (ret < 0) {
+ platform_device_put(raumfeld_audio_device);
return ret;
+ }
raumfeld_enable_audio(true);
return 0;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: Add missing platform_device_put in raumfeld_audio_init error path
2011-09-02 13:47 [PATCH] ASoC: Add missing platform_device_put in raumfeld_audio_init error path Axel Lin
@ 2011-09-02 14:03 ` Girdwood, Liam
2011-09-04 15:55 ` Mark Brown
1 sibling, 0 replies; 8+ messages in thread
From: Girdwood, Liam @ 2011-09-02 14:03 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, Mark Brown, linux-kernel, Daniel Mack
On 2 September 2011 14:47, Axel Lin <axel.lin@gmail.com> wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/pxa/raumfeld.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/pxa/raumfeld.c b/sound/soc/pxa/raumfeld.c
> index 1a591f1..b899a3b 100644
> --- a/sound/soc/pxa/raumfeld.c
> +++ b/sound/soc/pxa/raumfeld.c
> @@ -306,8 +306,10 @@ static int __init raumfeld_audio_init(void)
> &snd_soc_raumfeld_connector);
>
> ret = platform_device_add(raumfeld_audio_device);
> - if (ret < 0)
> + if (ret < 0) {
> + platform_device_put(raumfeld_audio_device);
> return ret;
> + }
>
> raumfeld_enable_audio(true);
> return 0;
> --
> 1.7.4.1
>
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: Add missing platform_device_put in raumfeld_audio_init error path
2011-09-02 13:47 [PATCH] ASoC: Add missing platform_device_put in raumfeld_audio_init error path Axel Lin
@ 2011-09-04 15:55 ` Mark Brown
2011-09-04 15:55 ` Mark Brown
1 sibling, 0 replies; 8+ messages in thread
From: Mark Brown @ 2011-09-04 15:55 UTC (permalink / raw)
To: Axel Lin; +Cc: alsa-devel, linux-kernel, Daniel Mack, Liam Girdwood
On Fri, Sep 02, 2011 at 09:47:41PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: Add missing platform_device_put in raumfeld_audio_init error path
@ 2011-09-04 15:55 ` Mark Brown
0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2011-09-04 15:55 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Daniel Mack, Liam Girdwood, alsa-devel
On Fri, Sep 02, 2011 at 09:47:41PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: Add missing platform_device_put in raumfeld_audio_init error path
2011-09-04 15:55 ` Mark Brown
@ 2011-09-04 16:36 ` Daniel Mack
-1 siblings, 0 replies; 8+ messages in thread
From: Daniel Mack @ 2011-09-04 16:36 UTC (permalink / raw)
To: Mark Brown; +Cc: Axel Lin, linux-kernel, alsa-devel, Liam Girdwood
On Sun, Sep 4, 2011 at 5:55 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Fri, Sep 02, 2011 at 09:47:41PM +0800, Axel Lin wrote:
>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Applied, thanks.
Feel free to add my Acked-by as well, if it's not too late.
Thanks,
Daniel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: Add missing platform_device_put in raumfeld_audio_init error path
@ 2011-09-04 16:36 ` Daniel Mack
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Mack @ 2011-09-04 16:36 UTC (permalink / raw)
To: Mark Brown; +Cc: Axel Lin, linux-kernel, Liam Girdwood, alsa-devel
On Sun, Sep 4, 2011 at 5:55 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Fri, Sep 02, 2011 at 09:47:41PM +0800, Axel Lin wrote:
>> Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Applied, thanks.
Feel free to add my Acked-by as well, if it's not too late.
Thanks,
Daniel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: Add missing platform_device_put in raumfeld_audio_init error path
2011-09-04 16:36 ` Daniel Mack
@ 2011-09-06 1:13 ` Mark Brown
-1 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2011-09-06 1:13 UTC (permalink / raw)
To: Daniel Mack; +Cc: Axel Lin, linux-kernel, alsa-devel, Liam Girdwood
On Sun, Sep 04, 2011 at 06:36:51PM +0200, Daniel Mack wrote:
> Feel free to add my Acked-by as well, if it's not too late.
Done.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: Add missing platform_device_put in raumfeld_audio_init error path
@ 2011-09-06 1:13 ` Mark Brown
0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2011-09-06 1:13 UTC (permalink / raw)
To: Daniel Mack; +Cc: Axel Lin, linux-kernel, Liam Girdwood, alsa-devel
On Sun, Sep 04, 2011 at 06:36:51PM +0200, Daniel Mack wrote:
> Feel free to add my Acked-by as well, if it's not too late.
Done.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-09-06 1:13 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-02 13:47 [PATCH] ASoC: Add missing platform_device_put in raumfeld_audio_init error path Axel Lin
2011-09-02 14:03 ` Girdwood, Liam
2011-09-04 15:55 ` Mark Brown
2011-09-04 15:55 ` Mark Brown
2011-09-04 16:36 ` Daniel Mack
2011-09-04 16:36 ` Daniel Mack
2011-09-06 1:13 ` Mark Brown
2011-09-06 1:13 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.