All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Scott Jiang <scott.jiang.linux@gmail.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	device-drivers-devel@blackfin.uclinux.org,
	uclinux-dist-devel@blackfin.uclinux.org,
	Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH v2 1/2] regmap: Add support for device specific write and read flag masks.
Date: Mon, 5 Sep 2011 14:59:53 -0700	[thread overview]
Message-ID: <20110905215952.GC11107@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1315248393-31791-1-git-send-email-lars@metafoo.de>

On Mon, Sep 05, 2011 at 08:46:32PM +0200, Lars-Peter Clausen wrote:
> Some buses like SPI have no standard notation of read or write operations.
> The general scheme here is to set or clear specific bits in the register
> address to indicate whether the operation is a read or write. We already
> support having a read flag mask per bus, but as there is no standard
> the bits which need to be set or cleared differ between devices and vendors,
> thus we need a mechanism to specify them per device.

So, I tried to apply this to my topic/interface branch (which is where
I'm keeping stuff for merge into other trees) but that won't fly due to
the internal.h change.  What I might do to resolve the merge issues is
to make a commit with the new regmap.h changes alone.  This won't help
in terms of actually running things but it'll keep things buildable
which is more achievable.

Anyway, thanks for doing this - there's a bunch of other devices that
need this.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Liam Girdwood <lrg@ti.com>,
	alsa-devel@alsa-project.org,
	device-drivers-devel@blackfin.uclinux.org,
	uclinux-dist-devel@blackfin.uclinux.org,
	linux-kernel@vger.kernel.org,
	Scott Jiang <scott.jiang.linux@gmail.com>
Subject: Re: [PATCH v2 1/2] regmap: Add support for device specific write and read flag masks.
Date: Mon, 5 Sep 2011 14:59:53 -0700	[thread overview]
Message-ID: <20110905215952.GC11107@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1315248393-31791-1-git-send-email-lars@metafoo.de>

On Mon, Sep 05, 2011 at 08:46:32PM +0200, Lars-Peter Clausen wrote:
> Some buses like SPI have no standard notation of read or write operations.
> The general scheme here is to set or clear specific bits in the register
> address to indicate whether the operation is a read or write. We already
> support having a read flag mask per bus, but as there is no standard
> the bits which need to be set or cleared differ between devices and vendors,
> thus we need a mechanism to specify them per device.

So, I tried to apply this to my topic/interface branch (which is where
I'm keeping stuff for merge into other trees) but that won't fly due to
the internal.h change.  What I might do to resolve the merge issues is
to make a commit with the new regmap.h changes alone.  This won't help
in terms of actually running things but it'll keep things buildable
which is more achievable.

Anyway, thanks for doing this - there's a bunch of other devices that
need this.

  parent reply	other threads:[~2011-09-05 22:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-05 18:46 [PATCH v2 1/2] regmap: Add support for device specific write and read flag masks Lars-Peter Clausen
2011-09-05 18:46 ` Lars-Peter Clausen
2011-09-05 18:46 ` [PATCH v2 2/2] ASoC: ad193x: Setup regmap read and write flag masks for SPI Lars-Peter Clausen
2011-09-05 18:46   ` Lars-Peter Clausen
2011-09-05 21:59 ` Mark Brown [this message]
2011-09-05 21:59   ` [PATCH v2 1/2] regmap: Add support for device specific write and read flag masks Mark Brown
2011-09-06  0:13   ` Girdwood, Liam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110905215952.GC11107@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=device-drivers-devel@blackfin.uclinux.org \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=scott.jiang.linux@gmail.com \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.