All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH 0/4 v9] MSI-X MMIO support for KVM
Date: Tue, 6 Sep 2011 12:30:03 +0300	[thread overview]
Message-ID: <20110906093003.GC16091@redhat.com> (raw)
In-Reply-To: <1315300571.19717.1.camel@lappy>

On Tue, Sep 06, 2011 at 12:16:11PM +0300, Sasha Levin wrote:
> > Back to square #1: We need a device with MSI support and cap bit 8 set
> > in its _MSI_ control word.
> 
> Alright, so I've looked at some of my servers, and one of them has both
> a bunch of MSI-X devices, and some MSI devices which show this:
> 
> 	Capabilities: [60] MSI: Enable+ Count=1/2 Maskable+ 64bit-
> 		Address: 00000020  Data: 0000
> 		Masking: 00000000  Pending: 00000000
> 
> Which would suggest that the support per-vector masking, right?

pciutils has this:

  cap = get_conf_word(d, where + PCI_CAP_FLAGS);

later

  printf("MSI: Enable%c Count=%d/%d Maskable%c 64bit%c\n",
         FLAG(cap, PCI_MSI_FLAGS_ENABLE),
         1 << ((cap & PCI_MSI_FLAGS_QSIZE) >> 4),
         1 << ((cap & PCI_MSI_FLAGS_QMASK) >> 1),
         FLAG(cap, PCI_MSI_FLAGS_MASK_BIT),
         FLAG(cap, PCI_MSI_FLAGS_64BIT));

and
#define  PCI_MSI_FLAGS_MASK_BIT  0x100   /* interrupt masking & reporting supported */

#define PCI_CAP_FLAGS           2       /* Capability defined flags (16 bits) */


So yes, that's bit 8 in control word.


> -- 
> 
> Sasha.

  reply	other threads:[~2011-09-06  9:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-18  8:53 [PATCH 0/4 v9] MSI-X MMIO support for KVM Sheng Yang
2011-02-18  8:53 ` [PATCH 1/4] KVM: Move struct kvm_io_device to kvm_host.h Sheng Yang
2011-02-18  8:53 ` [PATCH 2/4] KVM: Add kvm_io_ext_data to IO handler Sheng Yang
2011-02-18  8:53 ` [PATCH 3/4] KVM: Emulate MSI-X table in kernel Sheng Yang
2011-02-18  8:53 ` [PATCH 4/4] KVM: Add documents for MSI-X MMIO API Sheng Yang
2011-02-22 18:08 ` [PATCH 0/4 v9] MSI-X MMIO support for KVM Marcelo Tosatti
2011-09-01 11:27   ` Jan Kiszka
2011-09-06  7:52     ` Avi Kivity
2011-09-06  8:12       ` Michael S. Tsirkin
2011-09-06  8:36         ` Jan Kiszka
2011-09-06  8:46           ` Sasha Levin
2011-09-06  8:49             ` Jan Kiszka
2011-09-06  9:00               ` Sasha Levin
2011-09-06  9:05                 ` Jan Kiszka
2011-09-06  9:16                   ` Sasha Levin
2011-09-06  9:30                     ` Michael S. Tsirkin [this message]
2011-09-06  8:36       ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110906093003.GC16091@redhat.com \
    --to=mst@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.