All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Avi Kivity <avi@redhat.com>,
	kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH 0/4 v9] MSI-X MMIO support for KVM
Date: Thu, 01 Sep 2011 13:27:28 +0200	[thread overview]
Message-ID: <4E5F6C20.7020701@siemens.com> (raw)
In-Reply-To: <20110222180858.GA5784@amt.cnet>

On 2011-02-22 19:08, Marcelo Tosatti wrote:
> On Fri, Feb 18, 2011 at 04:53:09PM +0800, Sheng Yang wrote:
>> Sorry for the long delay, just come back from vacation...
>>
>> Change from v8:
>> 1. Update struct kvm_run to contain MSI-X routing update exit specific
>> information.
>> 2. Fix a mmio_nr counting bug.
>>
>> Notice this patchset still based on 2.6.37 due to a block bug on assigned
>> device in the upstream now.
>>
>> Sheng Yang (4):
>>   KVM: Move struct kvm_io_device to kvm_host.h
>>   KVM: Add kvm_io_ext_data to IO handler
>>   KVM: Emulate MSI-X table in kernel
>>   KVM: Add documents for MSI-X MMIO API
> 
> Looks good to me.

What happened to this series and [1]? Forgotten because Sheng switched
his job?

I just realized that MSI-X per-vector masking for assigned devices is
not only slow (takes user space exits) but just simply broken (masking
bit is not evaluated and applied to the device).

BTW, the same is also true for that optional per-vector masking of
legacy MSI. Are there devices in the field that actually support this? I
haven't found one so far and tend to consider this feature not worth
implementing.

Jan

[1] http://thread.gmane.org/gmane.comp.emulators.kvm.devel/68144

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

  reply	other threads:[~2011-09-01 11:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-18  8:53 [PATCH 0/4 v9] MSI-X MMIO support for KVM Sheng Yang
2011-02-18  8:53 ` [PATCH 1/4] KVM: Move struct kvm_io_device to kvm_host.h Sheng Yang
2011-02-18  8:53 ` [PATCH 2/4] KVM: Add kvm_io_ext_data to IO handler Sheng Yang
2011-02-18  8:53 ` [PATCH 3/4] KVM: Emulate MSI-X table in kernel Sheng Yang
2011-02-18  8:53 ` [PATCH 4/4] KVM: Add documents for MSI-X MMIO API Sheng Yang
2011-02-22 18:08 ` [PATCH 0/4 v9] MSI-X MMIO support for KVM Marcelo Tosatti
2011-09-01 11:27   ` Jan Kiszka [this message]
2011-09-06  7:52     ` Avi Kivity
2011-09-06  8:12       ` Michael S. Tsirkin
2011-09-06  8:36         ` Jan Kiszka
2011-09-06  8:46           ` Sasha Levin
2011-09-06  8:49             ` Jan Kiszka
2011-09-06  9:00               ` Sasha Levin
2011-09-06  9:05                 ` Jan Kiszka
2011-09-06  9:16                   ` Sasha Levin
2011-09-06  9:30                     ` Michael S. Tsirkin
2011-09-06  8:36       ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E5F6C20.7020701@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=alex.williamson@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.