* 3.0.0: carl9170: drivers/net/wireless/ath/carl9170/tx.c:351 carl9170_tx_status+0x431/0x440 [carl9170]()
@ 2011-09-05 21:53 Justin Piszcz
2011-09-06 15:04 ` Pavel Roskin
0 siblings, 1 reply; 3+ messages in thread
From: Justin Piszcz @ 2011-09-05 21:53 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-wireless, Alan Piszcz
Hello,
Saw this on one of my Linux machines with a Linux (community supported USB
stick):
[88927.073741] ------------[ cut here ]------------
[88927.073762] WARNING: at drivers/net/wireless/ath/carl9170/tx.c:351 carl9170_tx_status+0x431/0x440 [carl9170]()
[88927.073769] Hardware name: X7SPA-HF
[88927.073772] Modules linked in: aes_generic carl9170 mac80211 ath cfg80211 uvcvideo i2c_i801 videodev
[88927.073791] Pid: 0, comm: kworker/0:1 Not tainted 3.0.0 #3
[88927.073796] Call Trace:
[88927.073800] <IRQ> [<ffffffff8103050c>] ? warn_slowpath_common+0x7c/0xc0
[88927.073821] [<ffffffffa00ab461>] ? carl9170_tx_status+0x431/0x440 [carl9170]
[88927.073831] [<ffffffffa00ab7e9>] ? __carl9170_tx_process_status+0x109/0x220 [carl9170]
[88927.073841] [<ffffffff8109f5ed>] ? dma_pool_free+0x1d/0xf0
[88927.073850] [<ffffffffa00abb7e>] ? carl9170_tx_process_status+0x3e/0x80 [carl9170]
[88927.073860] [<ffffffffa00ac7f2>] ? carl9170_handle_command_response+0x382/0x500 [carl9170]
[88927.073870] [<ffffffffa00acbcd>] ? __carl9170_rx+0x25d/0x820 [carl9170]
[88927.073879] [<ffffffff813bc494>] ? ehci_work+0x2f4/0xac0
[88927.073888] [<ffffffffa00ad213>] ? carl9170_rx_stream+0x83/0x3b0 [carl9170]
[88927.073897] [<ffffffffa00a5228>] ? carl9170_usb_tasklet+0x98/0xc0 [carl9170]
[88927.073906] [<ffffffff810353ea>] ? tasklet_hi_action+0x5a/0xc0
[88927.073914] [<ffffffff81035ae0>] ? __do_softirq+0x90/0x120
[88927.073922] [<ffffffff814def4c>] ? call_softirq+0x1c/0x26
[88927.073930] [<ffffffff81003a8d>] ? do_softirq+0x4d/0x80
[88927.073936] [<ffffffff8100394d>] ? do_IRQ+0x5d/0xd0
[88927.073945] [<ffffffff814ddb53>] ? common_interrupt+0x13/0x13
[88927.073949] <EOI> [<ffffffff81008ed1>] ? mwait_idle+0x51/0x70
[88927.073961] [<ffffffff8100072c>] ? cpu_idle+0x4c/0x90
[88927.073967] ---[ end trace e579a118b0825530 ]---
[90635.804554] ieee80211 phy0: invalid plcp cck rate (0).
[91309.613969] ieee80211 phy0: invalid plcp cck rate (0).
I have another host with another one of these sticks as well:
[ 6703.136920] ------------[ cut here ]------------
[ 6703.136955] WARNING: at drivers/net/wireless/ath/carl9170/tx.c:351 carl9170_tx_status+0x398/0x3b0 [carl9170]()
[ 6703.136992] Hardware name: Latitude D630
[ 6703.137012] Modules linked in: aes_generic carl9170 b43 ath mac80211 uvcvideo videodev cfg80211 i2c_i801 ssb
[ 6703.137092] Pid: 0, comm: swapper Not tainted 3.0.0 #4
[ 6703.137117] Call Trace:
[ 6703.137137] [<c102f4f8>] ? warn_slowpath_common+0x78/0xb0
[ 6703.137158] [<f829fb88>] ? carl9170_tx_status+0x398/0x3b0 [carl9170]
[ 6703.137180] [<f829fb88>] ? carl9170_tx_status+0x398/0x3b0 [carl9170]
[ 6703.137201] [<c102f54b>] ? warn_slowpath_null+0x1b/0x20
[ 6703.137221] [<f829fb88>] ? carl9170_tx_status+0x398/0x3b0 [carl9170]
[ 6703.137242] [<c1281dbf>] ? bitmap_release_region+0xf/0x20
[ 6703.137263] [<f829fe01>] ? __carl9170_tx_process_status+0x31/0x1e0 [carl9170]
[ 6703.137295] [<f82a0204>] ? carl9170_tx_process_status+0x44/0x80 [carl9170]
[ 6703.137317] [<f82a0ea5>] ? carl9170_handle_command_response+0x365/0x4e0 [carl9170]
[ 6703.137349] [<f82a1246>] ? __carl9170_rx+0x226/0x7d0 [carl9170]
[ 6703.137369] [<c102b005>] ? load_balance+0x65/0x520
[ 6703.137389] [<f82a185a>] ? carl9170_rx_stream+0x6a/0x360 [carl9170]
[ 6703.137411] [<c1390d41>] ? __usb_unanchor_urb+0x51/0x60
[ 6703.137430] [<f8299db4>] ? carl9170_usb_tasklet+0x94/0xc0 [carl9170]
[ 6703.137452] [<c1033d68>] ? tasklet_hi_action+0x48/0xa0
[ 6703.137471] [<c1034375>] ? __do_softirq+0x75/0x100
[ 6703.137490] [<c1034300>] ? remote_softirq_receive+0x20/0x20
[ 6703.137509] <IRQ> [<c1004306>] ? do_IRQ+0x46/0xc0
[ 6703.137532] [<c12c646a>] ? acpi_hw_read_port+0x32/0x80
[ 6703.137552] [<c14aed29>] ? common_interrupt+0x29/0x30
[ 6703.137572] [<c12d2ead>] ? acpi_idle_enter_bm+0x228/0x25d
[ 6703.137593] [<c13bd757>] ? cpuidle_idle_call+0x67/0xf0
[ 6703.137612] [<c1001535>] ? cpu_idle+0x45/0x70
[ 6703.137630] [<c161f5fe>] ? start_kernel+0x267/0x26c
[ 6703.137648] [<c161f147>] ? loglevel+0x14/0x14
[ 6703.137665] ---[ end trace f3fa3de4b705d3e7 ]---
[14580.577119] ieee80211 phy1: invalid plcp cck rate (0).
[16930.612982] ieee80211 phy1: invalid plcp cck rate (0).
Justin.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 3.0.0: carl9170: drivers/net/wireless/ath/carl9170/tx.c:351 carl9170_tx_status+0x431/0x440 [carl9170]()
2011-09-05 21:53 3.0.0: carl9170: drivers/net/wireless/ath/carl9170/tx.c:351 carl9170_tx_status+0x431/0x440 [carl9170]() Justin Piszcz
@ 2011-09-06 15:04 ` Pavel Roskin
2011-09-06 18:39 ` Justin Piszcz
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Roskin @ 2011-09-06 15:04 UTC (permalink / raw)
To: Justin Piszcz; +Cc: linux-wireless, Alan Piszcz
On Mon, 5 Sep 2011 17:53:06 -0400 (EDT)
Justin Piszcz <jpiszcz@lucidpixels.com> wrote:
> Hello,
>
> Saw this on one of my Linux machines with a Linux (community
> supported USB stick):
>
> [88927.073741] ------------[ cut here ]------------
> [88927.073762] WARNING: at drivers/net/wireless/ath/carl9170/tx.c:351
I'm dropping LKML from cc, no need to write there if there is a specialized
mailing list.
It looks like the bitmap code in carl9170 needs reviewing. I spotted
one error immediately. bitmap_zero() takes the number of bits, not the
number of long integers.
Chances are not very high that it would help in your case, but here's
the patch. I hope to give carl9170 some good testing before submitting
that patch formally.
carl9170: fix bitmap initialization
From: Pavel Roskin <proski@gnu.org>
bitmap_zero() takes the number of bits, not the long integers used to
keep them.
Signed-off-by: Pavel Roskin <proski@gnu.org>
---
drivers/net/wireless/ath/carl9170/main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/carl9170/main.c b/drivers/net/wireless/ath/carl9170/main.c
index af351ec..2f68747 100644
--- a/drivers/net/wireless/ath/carl9170/main.c
+++ b/drivers/net/wireless/ath/carl9170/main.c
@@ -1411,7 +1411,7 @@ static int carl9170_op_ampdu_action(struct ieee80211_hw *hw,
sta_info->stats[tid].req = false;
if (tid_info) {
- bitmap_zero(tid_info->bitmap, CARL9170_BAW_SIZE);
+ bitmap_zero(tid_info->bitmap, CARL9170_BAW_BITS);
tid_info->state = CARL9170_TID_STATE_IDLE;
}
rcu_read_unlock();
--
Regards,
Pavel Roskin
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: 3.0.0: carl9170: drivers/net/wireless/ath/carl9170/tx.c:351 carl9170_tx_status+0x431/0x440 [carl9170]()
2011-09-06 15:04 ` Pavel Roskin
@ 2011-09-06 18:39 ` Justin Piszcz
0 siblings, 0 replies; 3+ messages in thread
From: Justin Piszcz @ 2011-09-06 18:39 UTC (permalink / raw)
To: Pavel Roskin; +Cc: linux-wireless, Alan Piszcz
On Tue, 6 Sep 2011, Pavel Roskin wrote:
> On Mon, 5 Sep 2011 17:53:06 -0400 (EDT)
> Justin Piszcz <jpiszcz@lucidpixels.com> wrote:
>
>> Hello,
>>
>> Saw this on one of my Linux machines with a Linux (community
>> supported USB stick):
>>
>> [88927.073741] ------------[ cut here ]------------
>> [88927.073762] WARNING: at drivers/net/wireless/ath/carl9170/tx.c:351
>
> I'm dropping LKML from cc, no need to write there if there is a specialized
> mailing list.
>
> It looks like the bitmap code in carl9170 needs reviewing. I spotted
> one error immediately. bitmap_zero() takes the number of bits, not the
> number of long integers.
>
> Chances are not very high that it would help in your case, but here's
> the patch. I hope to give carl9170 some good testing before submitting
> that patch formally.
>
> carl9170: fix bitmap initialization
>
> From: Pavel Roskin <proski@gnu.org>
>
> bitmap_zero() takes the number of bits, not the long integers used to
> keep them.
>
> Signed-off-by: Pavel Roskin <proski@gnu.org>
> ---
>
> drivers/net/wireless/ath/carl9170/main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> diff --git a/drivers/net/wireless/ath/carl9170/main.c b/drivers/net/wireless/ath/carl9170/main.c
> index af351ec..2f68747 100644
> --- a/drivers/net/wireless/ath/carl9170/main.c
> +++ b/drivers/net/wireless/ath/carl9170/main.c
> @@ -1411,7 +1411,7 @@ static int carl9170_op_ampdu_action(struct ieee80211_hw *hw,
> sta_info->stats[tid].req = false;
>
> if (tid_info) {
> - bitmap_zero(tid_info->bitmap, CARL9170_BAW_SIZE);
> + bitmap_zero(tid_info->bitmap, CARL9170_BAW_BITS);
> tid_info->state = CARL9170_TID_STATE_IDLE;
> }
> rcu_read_unlock();
>
> --
> Regards,
> Pavel Roskin
>
Hi,
Patch applied to both hosts, rebooted and both running again, will let you
know if I see anything further errors, thanks.
d630:/usr/src/linux# patch -p1 < ../c
patching file drivers/net/wireless/ath/carl9170/main.c
Hunk #1 succeeded at 1360 (offset -51 lines).
atom:/usr/src/linux# patch -p1 < ../c
patching file drivers/net/wireless/ath/carl9170/main.c
Hunk #1 succeeded at 1360 (offset -51 lines).
Applied against linux-3.0.
Justin.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-06 18:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-05 21:53 3.0.0: carl9170: drivers/net/wireless/ath/carl9170/tx.c:351 carl9170_tx_status+0x431/0x440 [carl9170]() Justin Piszcz
2011-09-06 15:04 ` Pavel Roskin
2011-09-06 18:39 ` Justin Piszcz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.