From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Scott Jiang <scott.jiang.linux@gmail.com>
Cc: uclinux-dist-devel@blackfin.uclinux.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH] [PATCH]ASoC:blackfin:add ad73311 card driver name
Date: Tue, 6 Sep 2011 16:19:48 +0100 [thread overview]
Message-ID: <20110906151948.GB18090@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1315338369-4251-1-git-send-email-scott.jiang.linux@gmail.com>
On Tue, Sep 06, 2011 at 03:46:09PM -0400, Scott Jiang wrote:
> ASoC doesn't copy codec name to card driver now.
> ALSA lib need this info to find the proper card config.
> So add card name in snd_soc_card, asoc will copy this name to snd_card.
Your changelog doesn't correspond to your code:
> static struct snd_soc_card bf5xx_ad73311 = {
> .name = "bfin-ad73311",
> + .driver_name = "AD73311",
You're not adding a card name, you're adding a driver name, and the
existing card name already contains the name of the CODEC. There
should already be enough information available to userspace to identify
that the card is a Blackfin card with ad73311. Since the driver_name
you're setting only contains the name of the CODEC it looks likely to
cause more collisions anyway as other systems may use the same CODEC.
next prev parent reply other threads:[~2011-09-06 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 19:46 [PATCH] [PATCH]ASoC:blackfin:add ad73311 card driver name Scott Jiang
2011-09-06 15:19 ` Mark Brown [this message]
2011-09-07 5:42 ` Scott Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110906151948.GB18090@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=scott.jiang.linux@gmail.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.