Re: [PATCH] [PATCH]ASoC:blackfin:add ad73311 card driver name

Re: [PATCH] [PATCH]ASoC:blackfin:add ad73311 card driver name

[Mark Brown]

On Tue, Sep 06, 2011 at 03:46:09PM -0400, Scott Jiang wrote:
> ASoC doesn't copy codec name to card driver now.
> ALSA lib need this info to find the proper card config.
> So add card name in snd_soc_card, asoc will copy this name to snd_card.

Your changelog doesn't correspond to your code:

>  static struct snd_soc_card bf5xx_ad73311 = {
>  	.name = "bfin-ad73311",
> +	.driver_name = "AD73311",

You're not adding a card name, you're adding a driver name, and the
existing card name already contains the name of the CODEC.  There
should already be enough information available to userspace to identify
that the card is a Blackfin card with ad73311.  Since the driver_name
you're setting only contains the name of the CODEC it looks likely to
cause more collisions anyway as other systems may use the same CODEC.

[PATCH] [PATCH]ASoC:blackfin:add ad73311 card driver name

[Scott Jiang]

ASoC doesn't copy codec name to card driver now.
ALSA lib need this info to find the proper card config.
So add card name in snd_soc_card, asoc will copy this name to snd_card.

Signed-off-by: Scott Jiang <scott.jiang.linux@gmail.com>
---
 sound/soc/blackfin/bf5xx-ad73311.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/soc/blackfin/bf5xx-ad73311.c b/sound/soc/blackfin/bf5xx-ad73311.c
index 732a247..975c6e8 100644
--- a/sound/soc/blackfin/bf5xx-ad73311.c
+++ b/sound/soc/blackfin/bf5xx-ad73311.c
@@ -192,6 +192,7 @@ static struct snd_soc_dai_link bf5xx_ad73311_dai[] = {
 
 static struct snd_soc_card bf5xx_ad73311 = {
 	.name = "bfin-ad73311",
+	.driver_name = "AD73311",
 	.probe = bf5xx_probe,
 	.dai_link = &bf5xx_ad73311_dai[CONFIG_SND_BF5XX_SPORT_NUM],
 	.num_links = 1,
-- 
1.7.0.4

Re: [PATCH] [PATCH]ASoC:blackfin:add ad73311 card driver name

[Scott Jiang]

2011/9/6 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> On Tue, Sep 06, 2011 at 03:46:09PM -0400, Scott Jiang wrote:
>> ASoC doesn't copy codec name to card driver now.
>> ALSA lib need this info to find the proper card config.
>> So add card name in snd_soc_card, asoc will copy this name to snd_card.
>
> Your changelog doesn't correspond to your code:
>
>>  static struct snd_soc_card bf5xx_ad73311 = {
>>       .name = "bfin-ad73311",
>> +     .driver_name = "AD73311",
>
>There should already be enough information available to userspace to identify
> that the card is a Blackfin card with ad73311.
>
Yes, card name contains enough info, but alsa lib doesn't use it.
My alsa lib version is 1.0.24. It uses driver name to find card config
not short name nor long name.

> Since the driver_name you're setting only contains the name of the CODEC it looks likely to
> cause more collisions anyway as other systems may use the same CODEC.
>
It is a historical result. all cards config of blackfin in alsa lib
use these names.

one more question, I found nobody changed this in their drivers.
Do their cards config in alsa lib acctually take effect?