From: Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
To: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Sebastian Andrzej Siewior
<bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Dirk Brandewie
<dirk.brandewie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH RESEND] i2c-pxa2xx: return proper error code in ce4100_i2c_probe error paths
Date: Wed, 7 Sep 2011 00:09:01 +0100 [thread overview]
Message-ID: <20110906230901.GA25655@freya.fluff.org> (raw)
In-Reply-To: <1314686257.3270.2.camel@phoenix>
On Tue, Aug 30, 2011 at 02:37:37PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Acked-by: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
A message in the patch description body is always useful.
Will apply.
> ---
> Hi Ben,
> Seems this patch is not yet upstream. Here is the resend.
>
> Axel
>
> drivers/i2c/busses/i2c-pxa-pci.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-pxa-pci.c b/drivers/i2c/busses/i2c-pxa-pci.c
> index 6659d26..b73da6c 100644
> --- a/drivers/i2c/busses/i2c-pxa-pci.c
> +++ b/drivers/i2c/busses/i2c-pxa-pci.c
> @@ -109,12 +109,15 @@ static int __devinit ce4100_i2c_probe(struct pci_dev *dev,
> return -EINVAL;
> }
> sds = kzalloc(sizeof(*sds), GFP_KERNEL);
> - if (!sds)
> + if (!sds) {
> + ret = -ENOMEM;
> goto err_mem;
> + }
>
> for (i = 0; i < ARRAY_SIZE(sds->pdev); i++) {
> sds->pdev[i] = add_i2c_device(dev, i);
> if (IS_ERR(sds->pdev[i])) {
> + ret = PTR_ERR(sds->pdev[i]);
> while (--i >= 0)
> platform_device_unregister(sds->pdev[i]);
> goto err_dev_add;
> --
> 1.7.4.1
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben-i2c@fluff.org>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Dirk Brandewie <dirk.brandewie@gmail.com>,
Jean Delvare <khali@linux-fr.org>,
Ben Dooks <ben-linux@fluff.org>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH RESEND] i2c-pxa2xx: return proper error code in ce4100_i2c_probe error paths
Date: Wed, 7 Sep 2011 00:09:01 +0100 [thread overview]
Message-ID: <20110906230901.GA25655@freya.fluff.org> (raw)
In-Reply-To: <1314686257.3270.2.camel@phoenix>
On Tue, Aug 30, 2011 at 02:37:37PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
A message in the patch description body is always useful.
Will apply.
> ---
> Hi Ben,
> Seems this patch is not yet upstream. Here is the resend.
>
> Axel
>
> drivers/i2c/busses/i2c-pxa-pci.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-pxa-pci.c b/drivers/i2c/busses/i2c-pxa-pci.c
> index 6659d26..b73da6c 100644
> --- a/drivers/i2c/busses/i2c-pxa-pci.c
> +++ b/drivers/i2c/busses/i2c-pxa-pci.c
> @@ -109,12 +109,15 @@ static int __devinit ce4100_i2c_probe(struct pci_dev *dev,
> return -EINVAL;
> }
> sds = kzalloc(sizeof(*sds), GFP_KERNEL);
> - if (!sds)
> + if (!sds) {
> + ret = -ENOMEM;
> goto err_mem;
> + }
>
> for (i = 0; i < ARRAY_SIZE(sds->pdev); i++) {
> sds->pdev[i] = add_i2c_device(dev, i);
> if (IS_ERR(sds->pdev[i])) {
> + ret = PTR_ERR(sds->pdev[i]);
> while (--i >= 0)
> platform_device_unregister(sds->pdev[i]);
> goto err_dev_add;
> --
> 1.7.4.1
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-09-06 23:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 6:37 [PATCH RESEND] i2c-pxa2xx: return proper error code in ce4100_i2c_probe error paths Axel Lin
2011-08-30 6:37 ` Axel Lin
2011-09-06 23:09 ` Ben Dooks [this message]
2011-09-06 23:09 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110906230901.GA25655@freya.fluff.org \
--to=ben-i2c-elnmno+kys3ytjvyw6ydsg@public.gmane.org \
--cc=axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=dirk.brandewie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.