From: Joel Becker <jlbec@evilplan.org>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] block64 failure
Date: Wed, 7 Sep 2011 10:57:49 -0700 [thread overview]
Message-ID: <20110907175748.GA17687@noexit.corp.google.com> (raw)
In-Reply-To: <4E67A593.70302@oracle.com>
On Wed, Sep 07, 2011 at 10:10:43AM -0700, Sunil Mushran wrote:
> All,
>
> So the patches added to allow mounting volumes > 16TB has a problem.
> The feature check of the jbd2 superblock is being done before the
> jbd2 superblock is actually read.
>
> It is being done after the journal_init_inode() which is incorrect.
>
> ocfs2_check_volume()
> ocfs2_journal_init()
> jbd2_journal_init_inode()
> ocfs2_journal_addressable() <=== check
> ...
>
> Currently the journal sb is first read during load_journal. Too late for us.
> And journal_get_superblock() is not exported.
I'm confused. jbd2_journal_check_used_features() reads the
journal superblock if needed. Why does this not satisfy?
Joel
--
"The one important thing i have learned over the years is the
difference between taking one's work seriously and taking one's self
seriously. The first is imperative and the second is disastrous."
-Margot Fonteyn
http://www.jlbec.org/
jlbec at evilplan.org
next prev parent reply other threads:[~2011-09-07 17:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 17:10 [Ocfs2-devel] block64 failure Sunil Mushran
2011-09-07 17:57 ` Joel Becker [this message]
2011-09-07 18:08 ` Sunil Mushran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110907175748.GA17687@noexit.corp.google.com \
--to=jlbec@evilplan.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.