All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yong Zhang <yong.zhang0@gmail.com>
To: TAO HU <tghk48@motorola.com>
Cc: peterz@infradead.org, Ingo Molnar <mingo@elte.hu>,
	linux-omap <linux-omap@vger.kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: Tasks schedule/migration issue with CPU hotplug?
Date: Thu, 8 Sep 2011 15:39:43 +0800	[thread overview]
Message-ID: <20110908073943.GC11124@zhy> (raw)
In-Reply-To: <20110908072801.GA11124@zhy>

On Thu, Sep 08, 2011 at 03:28:01PM +0800, Yong Zhang wrote:
> On Thu, Sep 08, 2011 at 02:47:08PM +0800, TAO HU wrote:
> > Resend with linux-kernel mail list included.
> 
> Hmm, could you give a try with commit da7a735e?
> 
> Thanks,
> Yong
> 
> ---
> commit da7a735e51f9622eb3e1672594d4a41da01d7e4f
> Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Date:   Mon Jan 17 17:03:27 2011 +0100
> 
>     sched: Fix switch_from_fair()
>     
>     When a task is taken out of the fair class we must ensure the vruntime
>     is properly normalized because when we put it back in it will assume
>     to be normalized.
>     
>     The case that goes wrong is when changing away from the fair class
>     while sleeping. Sleeping tasks have non-normalized vruntime in order
>     to make sleeper-fairness work. So treat the switch away from fair as a
>     wakeup and preserve the relative vruntime.
>     
>     Also update sysrq-n to call the ->switch_{to,from} methods.
>     
>     Reported-by: Onkalo Samu <samu.p.onkalo@nokia.com>
>     Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
>     LKML-Reference: <new-submission>
>     Signed-off-by: Ingo Molnar <mingo@elte.hu>
> 
> > 
> > On Wed, Sep 7, 2011 at 10:22 PM, TAO HU <tghk48@motorola.com> wrote:
> > > <4>[ 6950.136230] cfs_rq[0]:/
> > > <4>[ 6950.136230] ? .exec_clock ? ? ? ? ? ? ? ? ? ?: 6520265.283900
> > > <4>[ 6950.136260] ? .MIN_vruntime ? ? ? ? ? ? ? ? ?: 2223057.428522
> > > <4>[ 6950.136260] ? .min_vruntime ? ? ? ? ? ? ? ? ?: 2223057.428522
> > > <4>[ 6950.136291] ? .max_vruntime ? ? ? ? ? ? ? ? ?: 2223114.709956
> > > <4>[ 6950.136291] ? .spread ? ? ? ? ? ? ? ? ? ? ? ?: 57.281434
> > > <4>[ 6950.136291] ? .spread0 ? ? ? ? ? ? ? ? ? ? ? : 0.000000
> > > <4>[ 6950.136322] ? .nr_running ? ? ? ? ? ? ? ? ? ?: 212
> > > <4>[ 6950.136322] ? .load ? ? ? ? ? ? ? ? ? ? ? ? ?: 217650
> > > <4>[ 6950.136352] ? .nr_spread_over ? ? ? ? ? ? ? ?: 125034
> > > <4>[ 6950.136352] ? .shares ? ? ? ? ? ? ? ? ? ? ? ?: 0
> > > <4>[ 6950.136352]
> > > <4>[ 6950.136566] runnable tasks:
> > > <4>[ 6950.136566] ? ? ? ? ? ? task ? PID ? ? ? ? tree-key ?switches
> > > prio ? ? exec-runtime ? ? ? ? sum-exec ? ? ? ?sum-sleep
> > > <4>[ 6950.136596]
> > > ----------------------------------------------------------------------------------------------------------
> > > <4>[ 6950.136627] ? ? ?omap2_mcspi ? ?21 ? 2223062.886210 ?29451523

The tree-key(2223062.886210) almost equals to cfs_rq.min_vruntime,
so maybe you hit the bug which is cured by the mentioned commit.

Thanks,
Yong

WARNING: multiple messages have this Message-ID (diff)
From: yong.zhang0@gmail.com (Yong Zhang)
To: linux-arm-kernel@lists.infradead.org
Subject: Tasks schedule/migration issue with CPU hotplug?
Date: Thu, 8 Sep 2011 15:39:43 +0800	[thread overview]
Message-ID: <20110908073943.GC11124@zhy> (raw)
In-Reply-To: <20110908072801.GA11124@zhy>

On Thu, Sep 08, 2011 at 03:28:01PM +0800, Yong Zhang wrote:
> On Thu, Sep 08, 2011 at 02:47:08PM +0800, TAO HU wrote:
> > Resend with linux-kernel mail list included.
> 
> Hmm, could you give a try with commit da7a735e?
> 
> Thanks,
> Yong
> 
> ---
> commit da7a735e51f9622eb3e1672594d4a41da01d7e4f
> Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Date:   Mon Jan 17 17:03:27 2011 +0100
> 
>     sched: Fix switch_from_fair()
>     
>     When a task is taken out of the fair class we must ensure the vruntime
>     is properly normalized because when we put it back in it will assume
>     to be normalized.
>     
>     The case that goes wrong is when changing away from the fair class
>     while sleeping. Sleeping tasks have non-normalized vruntime in order
>     to make sleeper-fairness work. So treat the switch away from fair as a
>     wakeup and preserve the relative vruntime.
>     
>     Also update sysrq-n to call the ->switch_{to,from} methods.
>     
>     Reported-by: Onkalo Samu <samu.p.onkalo@nokia.com>
>     Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
>     LKML-Reference: <new-submission>
>     Signed-off-by: Ingo Molnar <mingo@elte.hu>
> 
> > 
> > On Wed, Sep 7, 2011 at 10:22 PM, TAO HU <tghk48@motorola.com> wrote:
> > > <4>[ 6950.136230] cfs_rq[0]:/
> > > <4>[ 6950.136230] ? .exec_clock ? ? ? ? ? ? ? ? ? ?: 6520265.283900
> > > <4>[ 6950.136260] ? .MIN_vruntime ? ? ? ? ? ? ? ? ?: 2223057.428522
> > > <4>[ 6950.136260] ? .min_vruntime ? ? ? ? ? ? ? ? ?: 2223057.428522
> > > <4>[ 6950.136291] ? .max_vruntime ? ? ? ? ? ? ? ? ?: 2223114.709956
> > > <4>[ 6950.136291] ? .spread ? ? ? ? ? ? ? ? ? ? ? ?: 57.281434
> > > <4>[ 6950.136291] ? .spread0 ? ? ? ? ? ? ? ? ? ? ? : 0.000000
> > > <4>[ 6950.136322] ? .nr_running ? ? ? ? ? ? ? ? ? ?: 212
> > > <4>[ 6950.136322] ? .load ? ? ? ? ? ? ? ? ? ? ? ? ?: 217650
> > > <4>[ 6950.136352] ? .nr_spread_over ? ? ? ? ? ? ? ?: 125034
> > > <4>[ 6950.136352] ? .shares ? ? ? ? ? ? ? ? ? ? ? ?: 0
> > > <4>[ 6950.136352]
> > > <4>[ 6950.136566] runnable tasks:
> > > <4>[ 6950.136566] ? ? ? ? ? ? task ? PID ? ? ? ? tree-key ?switches
> > > prio ? ? exec-runtime ? ? ? ? sum-exec ? ? ? ?sum-sleep
> > > <4>[ 6950.136596]
> > > ----------------------------------------------------------------------------------------------------------
> > > <4>[ 6950.136627] ? ? ?omap2_mcspi ? ?21 ? 2223062.886210 ?29451523

The tree-key(2223062.886210) almost equals to cfs_rq.min_vruntime,
so maybe you hit the bug which is cured by the mentioned commit.

Thanks,
Yong

WARNING: multiple messages have this Message-ID (diff)
From: Yong Zhang <yong.zhang0@gmail.com>
To: TAO HU <tghk48@motorola.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	peterz@infradead.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-omap <linux-omap@vger.kernel.org>
Subject: Re: Tasks schedule/migration issue with CPU hotplug?
Date: Thu, 8 Sep 2011 15:39:43 +0800	[thread overview]
Message-ID: <20110908073943.GC11124@zhy> (raw)
In-Reply-To: <20110908072801.GA11124@zhy>

On Thu, Sep 08, 2011 at 03:28:01PM +0800, Yong Zhang wrote:
> On Thu, Sep 08, 2011 at 02:47:08PM +0800, TAO HU wrote:
> > Resend with linux-kernel mail list included.
> 
> Hmm, could you give a try with commit da7a735e?
> 
> Thanks,
> Yong
> 
> ---
> commit da7a735e51f9622eb3e1672594d4a41da01d7e4f
> Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Date:   Mon Jan 17 17:03:27 2011 +0100
> 
>     sched: Fix switch_from_fair()
>     
>     When a task is taken out of the fair class we must ensure the vruntime
>     is properly normalized because when we put it back in it will assume
>     to be normalized.
>     
>     The case that goes wrong is when changing away from the fair class
>     while sleeping. Sleeping tasks have non-normalized vruntime in order
>     to make sleeper-fairness work. So treat the switch away from fair as a
>     wakeup and preserve the relative vruntime.
>     
>     Also update sysrq-n to call the ->switch_{to,from} methods.
>     
>     Reported-by: Onkalo Samu <samu.p.onkalo@nokia.com>
>     Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
>     LKML-Reference: <new-submission>
>     Signed-off-by: Ingo Molnar <mingo@elte.hu>
> 
> > 
> > On Wed, Sep 7, 2011 at 10:22 PM, TAO HU <tghk48@motorola.com> wrote:
> > > <4>[ 6950.136230] cfs_rq[0]:/
> > > <4>[ 6950.136230] ? .exec_clock ? ? ? ? ? ? ? ? ? ?: 6520265.283900
> > > <4>[ 6950.136260] ? .MIN_vruntime ? ? ? ? ? ? ? ? ?: 2223057.428522
> > > <4>[ 6950.136260] ? .min_vruntime ? ? ? ? ? ? ? ? ?: 2223057.428522
> > > <4>[ 6950.136291] ? .max_vruntime ? ? ? ? ? ? ? ? ?: 2223114.709956
> > > <4>[ 6950.136291] ? .spread ? ? ? ? ? ? ? ? ? ? ? ?: 57.281434
> > > <4>[ 6950.136291] ? .spread0 ? ? ? ? ? ? ? ? ? ? ? : 0.000000
> > > <4>[ 6950.136322] ? .nr_running ? ? ? ? ? ? ? ? ? ?: 212
> > > <4>[ 6950.136322] ? .load ? ? ? ? ? ? ? ? ? ? ? ? ?: 217650
> > > <4>[ 6950.136352] ? .nr_spread_over ? ? ? ? ? ? ? ?: 125034
> > > <4>[ 6950.136352] ? .shares ? ? ? ? ? ? ? ? ? ? ? ?: 0
> > > <4>[ 6950.136352]
> > > <4>[ 6950.136566] runnable tasks:
> > > <4>[ 6950.136566] ? ? ? ? ? ? task ? PID ? ? ? ? tree-key ?switches
> > > prio ? ? exec-runtime ? ? ? ? sum-exec ? ? ? ?sum-sleep
> > > <4>[ 6950.136596]
> > > ----------------------------------------------------------------------------------------------------------
> > > <4>[ 6950.136627] ? ? ?omap2_mcspi ? ?21 ? 2223062.886210 ?29451523

The tree-key(2223062.886210) almost equals to cfs_rq.min_vruntime,
so maybe you hit the bug which is cured by the mentioned commit.

Thanks,
Yong

  reply	other threads:[~2011-09-08  7:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-07 14:22 Tasks schedule/migration issue with CPU hotplug? TAO HU
2011-09-07 14:22 ` TAO HU
2011-09-08  6:47 ` TAO HU
2011-09-08  6:47   ` TAO HU
2011-09-08  6:47   ` TAO HU
2011-09-08  7:28   ` Yong Zhang
2011-09-08  7:28     ` Yong Zhang
2011-09-08  7:28     ` Yong Zhang
2011-09-08  7:39     ` Yong Zhang [this message]
2011-09-08  7:39       ` Yong Zhang
2011-09-08  7:39       ` Yong Zhang
2011-09-15  2:38       ` TAO HU
2011-09-15  2:38         ` TAO HU
2011-09-15  2:38         ` TAO HU
2011-09-08 12:55   ` Peter Zijlstra
2011-09-08 12:55     ` Peter Zijlstra
2011-09-08 12:55     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110908073943.GC11124@zhy \
    --to=yong.zhang0@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=tghk48@motorola.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.