[PATCH] mips: mm: tlbex.c: Fix compiler warnings

[PATCH] mips: mm: tlbex.c: Fix compiler warnings

[Maxin B. John]

 CC      arch/mips/mm/tlbex.o
cc1: warnings being treated as errors
arch/mips/mm/tlbex.c: In function 'build_r3000_tlb_modify_handler':
arch/mips/mm/tlbex.c:1769: error: 'wr.r1' is used uninitialized in this function
arch/mips/mm/tlbex.c:1769: error: 'wr.r2' is used uninitialized in this function
arch/mips/mm/tlbex.c:1769: error: 'wr.r3' is used uninitialized in this function
make[2]: *** [arch/mips/mm/tlbex.o] Error 1
make[1]: *** [arch/mips/mm] Error 2
make: *** [arch/mips] Error 2

Signed-off-by: Maxin B. John <maxin.john@gmail.com>
---
diff --git a/arch/mips/mm/tlbex.c b/arch/mips/mm/tlbex.c
index b6e1cff..ab51b83 100644
--- a/arch/mips/mm/tlbex.c
+++ b/arch/mips/mm/tlbex.c
@@ -1764,6 +1764,7 @@ static void __cpuinit build_r3000_tlb_modify_handler(void)
 	memset(handle_tlbm, 0, sizeof(handle_tlbm));
 	memset(labels, 0, sizeof(labels));
 	memset(relocs, 0, sizeof(relocs));
+	memset(&wr, 0, sizeof(wr));
 
 	build_r3000_tlbchange_handler_head(&p, K0, K1);
 	build_pte_modifiable(&p, &r, wr.r1, wr.r2,  wr.r3, label_nopage_tlbm);

Re: [PATCH] mips: mm: tlbex.c: Fix compiler warnings

[Ralf Baechle]

On Fri, Sep 09, 2011 at 01:06:00AM +0300, Maxin B. John wrote:

>  CC      arch/mips/mm/tlbex.o
> cc1: warnings being treated as errors
> arch/mips/mm/tlbex.c: In function 'build_r3000_tlb_modify_handler':
> arch/mips/mm/tlbex.c:1769: error: 'wr.r1' is used uninitialized in this function
> arch/mips/mm/tlbex.c:1769: error: 'wr.r2' is used uninitialized in this function
> arch/mips/mm/tlbex.c:1769: error: 'wr.r3' is used uninitialized in this function
> make[2]: *** [arch/mips/mm/tlbex.o] Error 1
> make[1]: *** [arch/mips/mm] Error 2
> make: *** [arch/mips] Error 2

This was fixed by 949cb4ca0aa53e97ea5f524536593ad2d2946b73.  The real
fix to not pass the wr members to build_pte_modifiable() because they
just are not needed.

Thanks,

  Ralf

Re: [PATCH] mips: mm: tlbex.c: Fix compiler warnings

[Grant Likely]

On Wed, Sep 14, 2011 at 9:04 AM, Ralf Baechle <ralf@linux-mips.org> wrote:
> On Fri, Sep 09, 2011 at 01:06:00AM +0300, Maxin B. John wrote:
>
>>  CC      arch/mips/mm/tlbex.o
>> cc1: warnings being treated as errors
>> arch/mips/mm/tlbex.c: In function 'build_r3000_tlb_modify_handler':
>> arch/mips/mm/tlbex.c:1769: error: 'wr.r1' is used uninitialized in this function
>> arch/mips/mm/tlbex.c:1769: error: 'wr.r2' is used uninitialized in this function
>> arch/mips/mm/tlbex.c:1769: error: 'wr.r3' is used uninitialized in this function
>> make[2]: *** [arch/mips/mm/tlbex.o] Error 1
>> make[1]: *** [arch/mips/mm] Error 2
>> make: *** [arch/mips] Error 2
>
> This was fixed by 949cb4ca0aa53e97ea5f524536593ad2d2946b73.  The real
> fix to not pass the wr members to build_pte_modifiable() because they
> just are not needed.

Which tree is this fix getting merged via?  Will it be in v3.1?

g.