From: Sughosh Ganu <urwithsughosh@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
Date: Mon, 12 Sep 2011 16:35:27 +0530 [thread overview]
Message-ID: <20110912110527.GA19853@Hardy> (raw)
In-Reply-To: <4E69D68E.4090504@denx.de>
hi Stefano,
On Fri Sep 09, 2011 at 11:04:14AM +0200, Stefano Babic wrote:
> On 09/09/2011 09:36 AM, Wolfgang Denk wrote:
<snip>
> >
> >> +# from comon directory
> >> +$(obj)memsize.c:
> >> + @rm -f $@
> >> + ln -s $(TOPDIR)/common/memsize.c $@
> >
> > Can we not rather compile the file in the common directory instead?
>
> This is only for nand_spl, not for u-boot. The nand_spl/board/Makefile
> has the list of files that must be compiled. Of course, the file was
> already compiled in common for u-boot.bin.
>
> Not sure why this issue appears now. Rebuilding all ARM boards I see
> that hawkboard is broken, I have not bisect to check when it happened.
Sorry for not having caught this earlier. I ran git bisect on this,
and the commit "401bb30b6d replace CONFIG_PRELOADER with
CONFIG_SPL_BUILD" seems to be causing the build break.
The issue seems to be that the code in board/davinci/common/misc.c
gets conditionally compiled based on definition of CONFIG_PRELOADER
symbol, which was removed in this commit, and replaced by
CONFIG_SPL_BUILD. I think we should correspondingly change this
check in misc.c, so that it would not be required to compile in
memsize.c. Let me know, and i will test this change and send out a
patch. Thanks.
-sughosh
next prev parent reply other threads:[~2011-09-12 11:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 7:17 [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl Stefano Babic
2011-09-09 7:36 ` Wolfgang Denk
2011-09-09 9:04 ` Stefano Babic
2011-09-12 11:05 ` Sughosh Ganu [this message]
2011-09-12 13:16 ` Stefano Babic
2011-09-09 9:23 ` Stefano Babic
2011-09-09 9:36 ` Stefano Babic
2011-09-09 9:37 ` [U-Boot] [PATCH] ARM: hawkboard_nand: " Stefano Babic
2011-09-09 11:40 ` Wolfgang Denk
2011-09-09 12:40 ` Stefano Babic
2011-09-09 13:09 ` [U-Boot] [PATCH V2] " Stefano Babic
2011-09-10 14:13 ` Wolfgang Denk
2011-09-11 16:19 ` Albert ARIBAUD
2011-09-09 20:34 ` [U-Boot] [PATCH] ARM: hawkboard: " Paulraj, Sandeep
-- strict thread matches above, loose matches on Subject: below --
2011-09-10 20:28 Wolfgang Denk
2011-09-10 20:46 ` Wolfgang Denk
2011-09-11 15:59 ` Albert ARIBAUD
2011-09-11 16:11 ` Albert ARIBAUD
2011-09-11 18:04 ` Wolfgang Denk
2011-09-11 18:03 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110912110527.GA19853@Hardy \
--to=urwithsughosh@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.