From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl
Date: Mon, 12 Sep 2011 15:16:22 +0200 [thread overview]
Message-ID: <4E6E0626.2050103@denx.de> (raw)
In-Reply-To: <20110912110527.GA19853@Hardy>
On 09/12/2011 01:05 PM, Sughosh Ganu wrote:
> hi Stefano,
>
> On Fri Sep 09, 2011 at 11:04:14AM +0200, Stefano Babic wrote:
>> On 09/09/2011 09:36 AM, Wolfgang Denk wrote:
>
> <snip>
Hi Sughosh,
>
> Sorry for not having caught this earlier. I ran git bisect on this,
> and the commit "401bb30b6d replace CONFIG_PRELOADER with
> CONFIG_SPL_BUILD" seems to be causing the build break.
>
> The issue seems to be that the code in board/davinci/common/misc.c
> gets conditionally compiled based on definition of CONFIG_PRELOADER
> symbol, which was removed in this commit, and replaced by
> CONFIG_SPL_BUILD.
Yes, right.
> I think we should correspondingly change this
> check in misc.c, so that it would not be required to compile in
> memsize.c. Let me know, and i will test this change and send out a
> patch. Thanks.
Agree. This is the right solution.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2011-09-12 13:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 7:17 [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl Stefano Babic
2011-09-09 7:36 ` Wolfgang Denk
2011-09-09 9:04 ` Stefano Babic
2011-09-12 11:05 ` Sughosh Ganu
2011-09-12 13:16 ` Stefano Babic [this message]
2011-09-09 9:23 ` Stefano Babic
2011-09-09 9:36 ` Stefano Babic
2011-09-09 9:37 ` [U-Boot] [PATCH] ARM: hawkboard_nand: " Stefano Babic
2011-09-09 11:40 ` Wolfgang Denk
2011-09-09 12:40 ` Stefano Babic
2011-09-09 13:09 ` [U-Boot] [PATCH V2] " Stefano Babic
2011-09-10 14:13 ` Wolfgang Denk
2011-09-11 16:19 ` Albert ARIBAUD
2011-09-09 20:34 ` [U-Boot] [PATCH] ARM: hawkboard: " Paulraj, Sandeep
-- strict thread matches above, loose matches on Subject: below --
2011-09-10 20:28 Wolfgang Denk
2011-09-10 20:46 ` Wolfgang Denk
2011-09-11 15:59 ` Albert ARIBAUD
2011-09-11 16:11 ` Albert ARIBAUD
2011-09-11 18:04 ` Wolfgang Denk
2011-09-11 18:03 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6E0626.2050103@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.