From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] xfs: improve ioend error handling
Date: Mon, 12 Sep 2011 10:49:29 -0400 [thread overview]
Message-ID: <20110912144929.GA2127@infradead.org> (raw)
In-Reply-To: <1315838435.2916.41.camel@doink>
On Mon, Sep 12, 2011 at 09:40:35AM -0500, Alex Elder wrote:
> On Wed, 2011-08-24 at 01:59 -0400, Christoph Hellwig wrote:
> > Return unwritten extent conversion errors to aio_complete.
>
> It might have been good to call attention to the fact that
> you were fixing it so ioend->io_error is consistently a
> negative errno value now, thereby making the above change
> possible.
Indeed, freel free to fix up the commit message if you want.
> Are we going to drop the last argument to aio_complete() now?
I don't think anything related to it changed. The argument is passed
on directly to userspace, and the usb gadget caller actually sets it.
No idea what the point of it is.
> Anyway, this looks good, and as you privately requested
> I will commit this patch without waiting for resolution
> of issues in the other two in this series.
The other two in this series are postponed - this one just happened to
be in the series because I found the issues while working on the other
two.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-09-12 14:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 5:59 [PATCH 0/3] RFC: log all i_size updates Christoph Hellwig
2011-08-24 5:59 ` [PATCH 1/3] xfs: improve ioend error handling Christoph Hellwig
2011-09-02 0:19 ` Dave Chinner
2011-09-12 14:40 ` Alex Elder
2011-09-12 14:49 ` Christoph Hellwig [this message]
2011-08-24 5:59 ` [PATCH 2/3] xfs: use per-filesystem I/O completion workqueues Christoph Hellwig
2011-08-25 0:48 ` Dave Chinner
2011-08-25 5:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110912144929.GA2127@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.