All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Thornber <thornber@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: dm-devel@redhat.com
Subject: Re: [PATCH] dm-thin: Fix multiple bugs with reference management
Date: Mon, 12 Sep 2011 18:08:18 +0100	[thread overview]
Message-ID: <20110912170817.GA26619@ubuntu> (raw)
In-Reply-To: <Pine.LNX.4.64.1109121125480.10597@hs20-bc2-1.build.redhat.com>

On Mon, Sep 12, 2011 at 12:03:31PM -0400, Mikulas Patocka wrote:
> Hi
> 
> This is a major cleanup+bugfix of reference count management. Test it with 
> your testsuite.

Right, we've got 2 patches here really.

The first replaces a spinlock with a mutex and lifts it to remove a
couple of race conditions.  All good, I've prefixed the functions that
should be called with this lock held with '__' as usual.

The second moves registration to the constructor and destructor rather
than suspend/resume.  I know you were asking about this earlier, and I
think this was a hang over from when the pool and target objects were
the same thing, and we couldn't have two targets registered at once
when reloading a table.  Your change is clearly simpler.

All tests pass.  Merged and pushed.

Thanks,

- Joe

      reply	other threads:[~2011-09-12 17:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-12 16:03 [PATCH] dm-thin: Fix multiple bugs with reference management Mikulas Patocka
2011-09-12 17:08 ` Joe Thornber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110912170817.GA26619@ubuntu \
    --to=thornber@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.