From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
David Brown <davidb@codeaurora.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Stepan Moskovchenko <stepanm@codeaurora.org>
Subject: Re: [PATCH 3/3] iommu/core: split mapping to page sizes as supported by the hardware
Date: Tue, 13 Sep 2011 12:44:33 +0200 [thread overview]
Message-ID: <20110913104433.GL11701@amd.com> (raw)
In-Reply-To: <CAK=WgbbhdFpAHTt=Bku-v1ZOCf48+u+XB-f4yO=5EDojv1kCJg@mail.gmail.com>
On Tue, Sep 13, 2011 at 06:34:23AM -0400, Ohad Ben-Cohen wrote:
> Hi Joerg,
>
> On Tue, Sep 13, 2011 at 1:10 PM, Roedel, Joerg <Joerg.Roedel@amd.com> wrote:
> > Please split this patch into the core-change and patches for the
> > individual iommu-drivers and post this as a seperate patch-set.
>
> But we'll be breaking bisectibility this way, no?
Not necessarily. You could implement this side-by-side with the old code
until all drivers are converted and remove the old code then. This keeps
bisectability.
> > Intel IOMMU does not support arbitrary page-sizes, afaik.
>
> It does; besides the usual 4K it has "super page sizes" support of
> 2MB, 1GB, 512GB and 1TB.
But the value ~0xfffUL indicates support for 4k, 8k, 16k .. 2^63, no?
>
> >> + pr_debug("map: iova 0x%lx pa 0x%lx size 0x%lx\n", iova,
> >> + (unsigned long)paddr, size);
> >
> > Please keep the debug-code in a seperate patch in your dev-tree. No need
> > for it to be merged upstream.
>
> It's actually useful sometimes to have those around - it's off by
> default, and can be enabled only when needed (CONFIG_DYNAMIC_DEBUG).
>
> But I don't mind removing them.
Ah right, it is just debug, so I am fine keeping it.
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
WARNING: multiple messages have this Message-ID (diff)
From: Joerg.Roedel@amd.com (Roedel, Joerg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] iommu/core: split mapping to page sizes as supported by the hardware
Date: Tue, 13 Sep 2011 12:44:33 +0200 [thread overview]
Message-ID: <20110913104433.GL11701@amd.com> (raw)
In-Reply-To: <CAK=WgbbhdFpAHTt=Bku-v1ZOCf48+u+XB-f4yO=5EDojv1kCJg@mail.gmail.com>
On Tue, Sep 13, 2011 at 06:34:23AM -0400, Ohad Ben-Cohen wrote:
> Hi Joerg,
>
> On Tue, Sep 13, 2011 at 1:10 PM, Roedel, Joerg <Joerg.Roedel@amd.com> wrote:
> > Please split this patch into the core-change and patches for the
> > individual iommu-drivers and post this as a seperate patch-set.
>
> But we'll be breaking bisectibility this way, no?
Not necessarily. You could implement this side-by-side with the old code
until all drivers are converted and remove the old code then. This keeps
bisectability.
> > Intel IOMMU does not support arbitrary page-sizes, afaik.
>
> It does; besides the usual 4K it has "super page sizes" support of
> 2MB, 1GB, 512GB and 1TB.
But the value ~0xfffUL indicates support for 4k, 8k, 16k .. 2^63, no?
>
> >> + ? ? ? pr_debug("map: iova 0x%lx pa 0x%lx size 0x%lx\n", iova,
> >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? (unsigned long)paddr, size);
> >
> > Please keep the debug-code in a seperate patch in your dev-tree. No need
> > for it to be merged upstream.
>
> It's actually useful sometimes to have those around - it's off by
> default, and can be enabled only when needed (CONFIG_DYNAMIC_DEBUG).
>
> But I don't mind removing them.
Ah right, it is just debug, so I am fine keeping it.
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
WARNING: multiple messages have this Message-ID (diff)
From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: "iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
David Brown <davidb@codeaurora.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Stepan Moskovchenko <stepanm@codeaurora.org>
Subject: Re: [PATCH 3/3] iommu/core: split mapping to page sizes as supported by the hardware
Date: Tue, 13 Sep 2011 12:44:33 +0200 [thread overview]
Message-ID: <20110913104433.GL11701@amd.com> (raw)
In-Reply-To: <CAK=WgbbhdFpAHTt=Bku-v1ZOCf48+u+XB-f4yO=5EDojv1kCJg@mail.gmail.com>
On Tue, Sep 13, 2011 at 06:34:23AM -0400, Ohad Ben-Cohen wrote:
> Hi Joerg,
>
> On Tue, Sep 13, 2011 at 1:10 PM, Roedel, Joerg <Joerg.Roedel@amd.com> wrote:
> > Please split this patch into the core-change and patches for the
> > individual iommu-drivers and post this as a seperate patch-set.
>
> But we'll be breaking bisectibility this way, no?
Not necessarily. You could implement this side-by-side with the old code
until all drivers are converted and remove the old code then. This keeps
bisectability.
> > Intel IOMMU does not support arbitrary page-sizes, afaik.
>
> It does; besides the usual 4K it has "super page sizes" support of
> 2MB, 1GB, 512GB and 1TB.
But the value ~0xfffUL indicates support for 4k, 8k, 16k .. 2^63, no?
>
> >> + pr_debug("map: iova 0x%lx pa 0x%lx size 0x%lx\n", iova,
> >> + (unsigned long)paddr, size);
> >
> > Please keep the debug-code in a seperate patch in your dev-tree. No need
> > for it to be merged upstream.
>
> It's actually useful sometimes to have those around - it's off by
> default, and can be enabled only when needed (CONFIG_DYNAMIC_DEBUG).
>
> But I don't mind removing them.
Ah right, it is just debug, so I am fine keeping it.
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2011-09-13 10:44 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 18:53 [PATCH 1/3] iommu/core: add fault reporting mechanism Ohad Ben-Cohen
2011-09-07 18:53 ` Ohad Ben-Cohen
2011-09-07 18:53 ` Ohad Ben-Cohen
2011-09-07 18:53 ` [PATCH 2/3] iommu/omap: migrate to the generic fault report mechanism Ohad Ben-Cohen
2011-09-07 18:53 ` Ohad Ben-Cohen
2011-09-07 18:53 ` Ohad Ben-Cohen
2011-09-07 18:53 ` [PATCH 3/3] iommu/core: split mapping to page sizes as supported by the hardware Ohad Ben-Cohen
2011-09-07 18:53 ` Ohad Ben-Cohen
2011-09-07 18:53 ` Ohad Ben-Cohen
2011-09-07 18:53 ` Ohad Ben-Cohen
2011-09-13 10:10 ` Roedel, Joerg
2011-09-13 10:10 ` Roedel, Joerg
2011-09-13 10:10 ` Roedel, Joerg
2011-09-13 10:34 ` Ohad Ben-Cohen
2011-09-13 10:34 ` Ohad Ben-Cohen
2011-09-13 10:34 ` Ohad Ben-Cohen
2011-09-13 10:44 ` Roedel, Joerg [this message]
2011-09-13 10:44 ` Roedel, Joerg
2011-09-13 10:44 ` Roedel, Joerg
2011-09-13 12:48 ` Ohad Ben-Cohen
2011-09-13 12:48 ` Ohad Ben-Cohen
2011-09-13 12:48 ` Ohad Ben-Cohen
2011-09-12 16:02 ` [PATCH 1/3] iommu/core: add fault reporting mechanism Roedel, Joerg
2011-09-12 16:02 ` Roedel, Joerg
2011-09-12 16:21 ` Ohad Ben-Cohen
2011-09-12 16:21 ` Ohad Ben-Cohen
2011-09-12 16:21 ` Ohad Ben-Cohen
2011-09-13 10:00 ` Roedel, Joerg
2011-09-13 10:00 ` Roedel, Joerg
2011-09-13 10:00 ` Roedel, Joerg
2011-09-13 10:19 ` Ohad Ben-Cohen
2011-09-13 10:19 ` Ohad Ben-Cohen
2011-09-13 10:19 ` Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110913104433.GL11701@amd.com \
--to=joerg.roedel@amd.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=arnd@arndb.de \
--cc=davidb@codeaurora.org \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=kvm@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=stepanm@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.