All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: alsa-devel@alsa-project.org, Sangbeom Kim <sbkim73@samsung.com>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	linux-kernel@vger.kernel.org, Ben Dooks <ben@simtec.co.uk>,
	Liam Girdwood <lrg@ti.com>,
	Christian Pellegrin <chripell@evolware.org>
Subject: Re: [PATCH] ASoC: samsung: Fix checking return value of clk_get
Date: Tue, 13 Sep 2011 16:14:20 +0100	[thread overview]
Message-ID: <20110913151420.GA23782@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1315925062.6042.1.camel@phoenix>

On Tue, Sep 13, 2011 at 10:44:22PM +0800, Axel Lin wrote:
> clk_get() returns a pointer to the struct clk or an ERR_PTR().

Are you sure that the Samsung clock implementation actually does this?

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Christian Pellegrin <chripell@evolware.org>,
	Ben Dooks <ben@simtec.co.uk>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Sangbeom Kim <sbkim73@samsung.com>, Liam Girdwood <lrg@ti.com>,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: samsung: Fix checking return value of clk_get
Date: Tue, 13 Sep 2011 16:14:20 +0100	[thread overview]
Message-ID: <20110913151420.GA23782@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1315925062.6042.1.camel@phoenix>

On Tue, Sep 13, 2011 at 10:44:22PM +0800, Axel Lin wrote:
> clk_get() returns a pointer to the struct clk or an ERR_PTR().

Are you sure that the Samsung clock implementation actually does this?

  parent reply	other threads:[~2011-09-13 15:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-13 14:44 [PATCH] ASoC: samsung: Fix checking return value of clk_get Axel Lin
2011-09-13 14:54 ` Liam Girdwood
2011-09-13 14:54   ` Liam Girdwood
2011-09-13 15:14 ` Mark Brown [this message]
2011-09-13 15:14   ` Mark Brown
2011-09-14  2:05   ` Axel Lin
2011-09-15  2:17 ` Sangbeom Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110913151420.GA23782@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=axel.lin@gmail.com \
    --cc=ben@simtec.co.uk \
    --cc=chripell@evolware.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=sbkim73@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.