From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Avi Kivity <avi@redhat.com>
Cc: hpoussin@reactos.org, "Andreas Färber" <planche2k@googlemail.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] mips_malta: move i8259 initialization after piix4 initialization
Date: Wed, 14 Sep 2011 22:52:00 +0200 [thread overview]
Message-ID: <20110914205200.GD17136@zapo> (raw)
In-Reply-To: <4E710BF2.9060404@redhat.com>
On Wed, Sep 14, 2011 at 11:17:54PM +0300, Avi Kivity wrote:
> On 09/14/2011 07:19 PM, Andreas Färber wrote:
> >>
> >> Can this please be reviewed? It's in the front of the memory queue
> >> logjam.
> >
> >With or without this patch, the mips and mipsel test images on qemu.org
> >produce no output at all, on x64 host.
> >
>
> AFAICT this problem predates the memory API. I'm looking more for
> criticism on the approach.
Hi, i think the images on the wiki are meant to run on a -M mips board.
Maybe the scripts predate a change to Malta as default board, don't know.
The patch looks OK to me to, but you could maybe put a comment in the code
to explain the indirection.
Cheers
next prev parent reply other threads:[~2011-09-14 20:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-12 13:07 [Qemu-devel] [PATCH] mips_malta: move i8259 initialization after piix4 initialization Avi Kivity
2011-09-14 12:00 ` Avi Kivity
2011-09-14 16:19 ` Andreas Färber
2011-09-14 19:03 ` Stefan Weil
2011-09-14 20:17 ` Avi Kivity
2011-09-14 20:52 ` Edgar E. Iglesias [this message]
2011-09-15 5:23 ` Stefan Weil
2011-09-18 12:04 ` Avi Kivity
2011-09-15 5:56 ` Stefan Weil
2011-09-14 20:32 ` Richard Henderson
2011-09-14 20:37 ` Avi Kivity
2011-09-14 20:40 ` Richard Henderson
2011-09-16 13:19 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110914205200.GD17136@zapo \
--to=edgar.iglesias@gmail.com \
--cc=avi@redhat.com \
--cc=hpoussin@reactos.org \
--cc=planche2k@googlemail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.