All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Tarun Kanti DebBarma <tarun.kanti@ti.com>
Cc: linux-omap@vger.kernel.org, khilman@ti.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v15 06/12] OMAP: dmtimer: switch-over to platform device driver
Date: Wed, 14 Sep 2011 15:24:03 -0700	[thread overview]
Message-ID: <20110914222403.GR24252@atomide.com> (raw)
In-Reply-To: <20110914214533.GA30941@atomide.com>

* Tony Lindgren <tony@atomide.com> [110914 14:12]:
> 
> Also, as we don't need the support for different register offsets
> for the first two omap4 timers, please rather implement support
> for the new timers and the timeouts directly in plat-omap/dmtimer.c.
> 
> That way we can still keep the minimal timer support simple
> for clocksource and clockevent. Of course this means that we'll
> be only supporting the first two timers as system timers on
> omap4, but that's fine.

Since you already have the struct timer_regs, you can make use
of that in dmtimer.c. Then maybe make the inline functions to
something like this instead:

static inline u32 __omap_dm_timer_read(void __iomem *base, u8 reg,
						u8 pend, int posted);

Where you pass the timer->context.pend depending on the pending
register offset for the timer.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v15 06/12] OMAP: dmtimer: switch-over to platform device driver
Date: Wed, 14 Sep 2011 15:24:03 -0700	[thread overview]
Message-ID: <20110914222403.GR24252@atomide.com> (raw)
In-Reply-To: <20110914214533.GA30941@atomide.com>

* Tony Lindgren <tony@atomide.com> [110914 14:12]:
> 
> Also, as we don't need the support for different register offsets
> for the first two omap4 timers, please rather implement support
> for the new timers and the timeouts directly in plat-omap/dmtimer.c.
> 
> That way we can still keep the minimal timer support simple
> for clocksource and clockevent. Of course this means that we'll
> be only supporting the first two timers as system timers on
> omap4, but that's fine.

Since you already have the struct timer_regs, you can make use
of that in dmtimer.c. Then maybe make the inline functions to
something like this instead:

static inline u32 __omap_dm_timer_read(void __iomem *base, u8 reg,
						u8 pend, int posted);

Where you pass the timer->context.pend depending on the pending
register offset for the timer.

Regards,

Tony

  reply	other threads:[~2011-09-14 22:24 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-08 21:08 [PATCH v15 00/12] OMAP: dmtimer: adaptation to platform_driver Tarun Kanti DebBarma
2011-09-08 21:08 ` Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 01/12] OMAP2+: dmtimer: add device names to flck nodes Tarun Kanti DebBarma
2011-09-08 21:08   ` Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 02/12] OMAP4: hwmod data: add dmtimer version information Tarun Kanti DebBarma
2011-09-08 21:08   ` Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 03/12] OMAP1: dmtimer: conversion to platform devices Tarun Kanti DebBarma
2011-09-08 21:08   ` Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 04/12] OMAP2+: dmtimer: convert " Tarun Kanti DebBarma
2011-09-08 21:08   ` Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 05/12] OMAP: dmtimer: platform driver Tarun Kanti DebBarma
2011-09-08 21:08   ` Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 06/12] OMAP: dmtimer: switch-over to platform device driver Tarun Kanti DebBarma
2011-09-08 21:08   ` Tarun Kanti DebBarma
2011-09-14 21:45   ` Tony Lindgren
2011-09-14 21:45     ` Tony Lindgren
2011-09-14 22:24     ` Tony Lindgren [this message]
2011-09-14 22:24       ` Tony Lindgren
2011-09-15  5:42     ` DebBarma, Tarun Kanti
2011-09-15  5:42       ` DebBarma, Tarun Kanti
2011-09-15  8:46       ` Mohammed, Afzal
2011-09-15  8:46         ` Mohammed, Afzal
2011-09-15 16:58         ` Tony Lindgren
2011-09-15 16:58           ` Tony Lindgren
2011-09-15 17:05           ` Tony Lindgren
2011-09-15 17:05             ` Tony Lindgren
2011-09-16  3:54             ` DebBarma, Tarun Kanti
2011-09-16  3:54               ` DebBarma, Tarun Kanti
2011-09-16  9:30               ` DebBarma, Tarun Kanti
2011-09-16  9:30                 ` DebBarma, Tarun Kanti
2011-09-17  1:35                 ` [PATCH] ARM: OMAP: Add support for dmtimer v2 ip (Re: [PATCH v15 06/12] OMAP: dmtimer: switch-over to platform device driver) Tony Lindgren
2011-09-17  1:35                   ` Tony Lindgren
2011-09-18 12:27                   ` DebBarma, Tarun Kanti
2011-09-18 12:27                     ` DebBarma, Tarun Kanti
2011-09-19 17:43                     ` Tony Lindgren
2011-09-19 17:43                       ` Tony Lindgren
2011-09-19  4:06                   ` Pedanekar, Hemant
2011-09-19  4:06                     ` Pedanekar, Hemant
2011-09-19 17:40                     ` Tony Lindgren
2011-09-19 17:40                       ` Tony Lindgren
2011-09-19 23:41                       ` Pedanekar, Hemant
2011-09-19 23:41                         ` Pedanekar, Hemant
2011-09-19  5:22                   ` Mohammed, Afzal
2011-09-19  5:22                     ` Mohammed, Afzal
2011-09-19 17:43                     ` Tony Lindgren
2011-09-19 17:43                       ` Tony Lindgren
2011-09-08 21:08 ` [PATCH v15 07/12] OMAP: dmtimer: pm_runtime support Tarun Kanti DebBarma
2011-09-08 21:08   ` Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 08/12] OMAP: dmtimer: add timeout to low-level routines Tarun Kanti DebBarma
2011-09-08 21:08   ` Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 09/12] OMAP: dmtimer: mark clocksource and clockevent timers reserved Tarun Kanti DebBarma
2011-09-08 21:08   ` Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 10/12] OMAP: dmtimer: low-power mode support Tarun Kanti DebBarma
2011-09-08 21:08   ` Tarun Kanti DebBarma
2011-09-08 21:08 ` [PATCH v15 11/12] OMAP: dmtimer: extend spinlock to exported APIs Tarun Kanti DebBarma
2011-09-08 21:08   ` Tarun Kanti DebBarma
2011-09-13 23:15   ` Tony Lindgren
2011-09-13 23:15     ` Tony Lindgren
2011-09-14  4:58     ` DebBarma, Tarun Kanti
2011-09-14  4:58       ` DebBarma, Tarun Kanti
2011-09-08 21:08 ` [PATCH v15 12/12] OMAP: dmtimer: add error handling to export APIs Tarun Kanti DebBarma
2011-09-08 21:08   ` Tarun Kanti DebBarma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110914222403.GR24252@atomide.com \
    --to=tony@atomide.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tarun.kanti@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.