From: Tony Lindgren <tony@atomide.com>
To: "Koyamangalath, Abhilash" <abhilash.kv@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] OMAP3: powerdomains: Match silicon revision to select the correct "core_pwrdm" definition
Date: Wed, 14 Sep 2011 17:27:19 -0700 [thread overview]
Message-ID: <20110915002719.GB30941@atomide.com> (raw)
In-Reply-To: <FCCFB4CDC6E5564B9182F639FC3560870370A4D985@dbde02.ent.ti.com>
* Koyamangalath, Abhilash <abhilash.kv@ti.com> [110812 00:12]:
> Hi
>
> > @@ -58,6 +59,24 @@ static struct powerdomain *_pwrdm_lookup(const char *name)
> >
> > list_for_each_entry(temp_pwrdm, &pwrdm_list, node) {
> > if (!strcmp(name, temp_pwrdm->name)) {
> > + if (!strcmp(name, "core_pwrdm") && cpu_is_omap3630()) {
> > + if (omap_rev() > OMAP3630_REV_ES1_0) {
> > + /*
> > + * match omap_chip info for OMAP3630
> > + * Rev ES1.1, ES1.2 or higher
> > + */
> > + if (!(temp_pwrdm->omap_chip.oc
> > + & CHIP_GE_OMAP3630ES1_1))
> > + continue;
> > + } else {
> > + /* match omap_chip info for OMAP3630
> > + * Rev ES1.0
> > + */
> > + if (!(temp_pwrdm->omap_chip.oc
> > + & CHIP_IS_OMAP3630ES1))
> > + continue;
> > + }
> > + }
> > pwrdm = temp_pwrdm;
> > break;
> > }
>
> Any comments ?
Can you please check if this is still needed after Paul's
CHIP_IS removal patches? You can find them at:
git://git.pwsan.com/linux-2.6 omap_chip_remove_cleanup_3.2
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] OMAP3: powerdomains: Match silicon revision to select the correct "core_pwrdm" definition
Date: Wed, 14 Sep 2011 17:27:19 -0700 [thread overview]
Message-ID: <20110915002719.GB30941@atomide.com> (raw)
In-Reply-To: <FCCFB4CDC6E5564B9182F639FC3560870370A4D985@dbde02.ent.ti.com>
* Koyamangalath, Abhilash <abhilash.kv@ti.com> [110812 00:12]:
> Hi
>
> > @@ -58,6 +59,24 @@ static struct powerdomain *_pwrdm_lookup(const char *name)
> >
> > list_for_each_entry(temp_pwrdm, &pwrdm_list, node) {
> > if (!strcmp(name, temp_pwrdm->name)) {
> > + if (!strcmp(name, "core_pwrdm") && cpu_is_omap3630()) {
> > + if (omap_rev() > OMAP3630_REV_ES1_0) {
> > + /*
> > + * match omap_chip info for OMAP3630
> > + * Rev ES1.1, ES1.2 or higher
> > + */
> > + if (!(temp_pwrdm->omap_chip.oc
> > + & CHIP_GE_OMAP3630ES1_1))
> > + continue;
> > + } else {
> > + /* match omap_chip info for OMAP3630
> > + * Rev ES1.0
> > + */
> > + if (!(temp_pwrdm->omap_chip.oc
> > + & CHIP_IS_OMAP3630ES1))
> > + continue;
> > + }
> > + }
> > pwrdm = temp_pwrdm;
> > break;
> > }
>
> Any comments ?
Can you please check if this is still needed after Paul's
CHIP_IS removal patches? You can find them at:
git://git.pwsan.com/linux-2.6 omap_chip_remove_cleanup_3.2
Regards,
Tony
next prev parent reply other threads:[~2011-09-15 0:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 11:44 [PATCH v2] OMAP3: powerdomains: Match silicon revision to select the correct "core_pwrdm" definition Abhilash K V
2011-07-15 11:44 ` Abhilash K V
2011-07-15 11:44 ` Abhilash K V
2011-08-12 7:41 ` Koyamangalath, Abhilash
2011-08-12 7:41 ` Koyamangalath, Abhilash
2011-09-15 0:27 ` Tony Lindgren [this message]
2011-09-15 0:27 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110915002719.GB30941@atomide.com \
--to=tony@atomide.com \
--cc=abhilash.kv@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.