[meta-handheld][PATCH] linux-kexecboot.inc: hardcode loglevel=3 to keep bootlogo intact

[meta-handheld][PATCH] linux-kexecboot.inc: hardcode loglevel=3 to keep bootlogo intact

[Andrea Adami]

* debug must be enabled explicitely as it is necessary to add
* more arguments e.g. earlyprintk and even enable PRINTK and debug
* in Zaurus defconfigs

Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
---
 recipes-kernel/linux/linux-kexecboot.inc |   19 ++++++++-----------
 1 files changed, 8 insertions(+), 11 deletions(-)

diff --git a/recipes-kernel/linux/linux-kexecboot.inc b/recipes-kernel/linux/linux-kexecboot.inc
index fb9760a..ea0bbd6 100644
--- a/recipes-kernel/linux/linux-kexecboot.inc
+++ b/recipes-kernel/linux/linux-kexecboot.inc
@@ -1,5 +1,5 @@
 # We set INC_PR here, since a change in the kexecboot recipe will need to get picked up by *all* the kernels:
-INC_PR = "r43"
+INC_PR = "r44"
 
 inherit kernel siteinfo
 
@@ -19,16 +19,13 @@ DEPENDS += "xz-native"
 LOGO_SIZE ?= "."
 SRC_URI = "file://${LOGO_SIZE}/logo_linux_clut224.ppm.bz2"
 
-# Set the verbosity of kernel messages during runtime
-CMDLINE_DEBUG ?= '${@base_contains("IMAGE_FEATURES", "debug-tweaks", "debug", "loglevel=3", d)}'
-
-# Note how we set master console on serial to protect bootlogo.
-CMDLINE_c7x0 = "console=tty1 console=ttyS0,115200n8 ${CMDLINE_DEBUG}"
-CMDLINE_tosa = "console=tty1 console=ttyS0,115200n8 ${CMDLINE_DEBUG}"
-CMDLINE_poodle = "console=tty1 console=ttyS0,115200n8 fbcon=rotate:1 ${CMDLINE_DEBUG}"
-CMDLINE_akita = "console=tty1 console=ttyS0,115200n8 fbcon=rotate:1 ${CMDLINE_DEBUG}"
-CMDLINE_collie = "console=tty1 console=ttySA0,115200n8 fbcon=rotate:1 mem=64M ${CMDLINE_DEBUG}"
-CMDLINE_spitz = "console=tty1 console=ttyS0,115200n8 fbcon=rotate:1 ${CMDLINE_DEBUG}"
+# Note how we set loglevel=3 and master console on serial to protect bootlogo.
+CMDLINE_c7x0 = "console=tty1 console=ttyS0,115200n8 loglevel=3"
+CMDLINE_tosa = "console=tty1 console=ttyS0,115200n8 loglevel=3"
+CMDLINE_poodle = "console=tty1 console=ttyS0,115200n8 fbcon=rotate:1 loglevel=3"
+CMDLINE_akita = "console=tty1 console=ttyS0,115200n8 fbcon=rotate:1 loglevel=3"
+CMDLINE_collie = "console=tty1 console=ttySA0,115200n8 fbcon=rotate:1 mem=64M loglevel=3"
+CMDLINE_spitz = "console=tty1 console=ttyS0,115200n8 fbcon=rotate:1 loglevel=3"
 
 PACKAGES = ""
 PROVIDES = ""
-- 
1.7.3.4

Re: [meta-handheld][PATCH] linux-kexecboot.inc: hardcode loglevel=3 to keep bootlogo intact

[Paul Eggleton]

On Thursday 08 September 2011 23:00:41 Andrea Adami wrote:
> * debug must be enabled explicitely as it is necessary to add
> * more arguments e.g. earlyprintk and even enable PRINTK and debug
> * in Zaurus defconfigs

This message is a little confusing, is the patch about keeping loglevel=3 for 
the bootlogo or the fact that loglevel=3 is insufficient for debugging, or both? 
Would you mind expanding the commit message?

Thanks,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

[meta-handheld][PATCH v2] linux-kexecboot.inc: hardcode loglevel=3 to keep bootlogo intact

[Andrea Adami]

* Being a second-stage bootloader we don't expect any output on screen.
* Adding 'debug' as commandline arg is pointless because
* linux-kexecboot is compiled without debug and printk in order
* to minimize the size.
* Full debug implies not only editing the commandline (e.g. earlyprintk)
* but re-enabling full debug options in the defconfigs.

Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
---
 recipes-kernel/linux/linux-kexecboot.inc |   19 ++++++++-----------
 1 files changed, 8 insertions(+), 11 deletions(-)

diff --git a/recipes-kernel/linux/linux-kexecboot.inc b/recipes-kernel/linux/linux-kexecboot.inc
index fb9760a..ea0bbd6 100644
--- a/recipes-kernel/linux/linux-kexecboot.inc
+++ b/recipes-kernel/linux/linux-kexecboot.inc
@@ -1,5 +1,5 @@
 # We set INC_PR here, since a change in the kexecboot recipe will need to get picked up by *all* the kernels:
-INC_PR = "r43"
+INC_PR = "r44"
 
 inherit kernel siteinfo
 
@@ -19,16 +19,13 @@ DEPENDS += "xz-native"
 LOGO_SIZE ?= "."
 SRC_URI = "file://${LOGO_SIZE}/logo_linux_clut224.ppm.bz2"
 
-# Set the verbosity of kernel messages during runtime
-CMDLINE_DEBUG ?= '${@base_contains("IMAGE_FEATURES", "debug-tweaks", "debug", "loglevel=3", d)}'
-
-# Note how we set master console on serial to protect bootlogo.
-CMDLINE_c7x0 = "console=tty1 console=ttyS0,115200n8 ${CMDLINE_DEBUG}"
-CMDLINE_tosa = "console=tty1 console=ttyS0,115200n8 ${CMDLINE_DEBUG}"
-CMDLINE_poodle = "console=tty1 console=ttyS0,115200n8 fbcon=rotate:1 ${CMDLINE_DEBUG}"
-CMDLINE_akita = "console=tty1 console=ttyS0,115200n8 fbcon=rotate:1 ${CMDLINE_DEBUG}"
-CMDLINE_collie = "console=tty1 console=ttySA0,115200n8 fbcon=rotate:1 mem=64M ${CMDLINE_DEBUG}"
-CMDLINE_spitz = "console=tty1 console=ttyS0,115200n8 fbcon=rotate:1 ${CMDLINE_DEBUG}"
+# Note how we set loglevel=3 and master console on serial to protect bootlogo.
+CMDLINE_c7x0 = "console=tty1 console=ttyS0,115200n8 loglevel=3"
+CMDLINE_tosa = "console=tty1 console=ttyS0,115200n8 loglevel=3"
+CMDLINE_poodle = "console=tty1 console=ttyS0,115200n8 fbcon=rotate:1 loglevel=3"
+CMDLINE_akita = "console=tty1 console=ttyS0,115200n8 fbcon=rotate:1 loglevel=3"
+CMDLINE_collie = "console=tty1 console=ttySA0,115200n8 fbcon=rotate:1 mem=64M loglevel=3"
+CMDLINE_spitz = "console=tty1 console=ttyS0,115200n8 fbcon=rotate:1 loglevel=3"
 
 PACKAGES = ""
 PROVIDES = ""
-- 
1.7.3.4

Re: [meta-handheld][PATCH v2] linux-kexecboot.inc: hardcode loglevel=3 to keep bootlogo intact

[Paul Eggleton]

On Thursday 15 September 2011 21:43:32 Andrea Adami wrote:
> * Being a second-stage bootloader we don't expect any output on screen.
> * Adding 'debug' as commandline arg is pointless because
> * linux-kexecboot is compiled without debug and printk in order
> * to minimize the size.
> * Full debug implies not only editing the commandline (e.g. earlyprintk)
> * but re-enabling full debug options in the defconfigs.
> 
> Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> ---
>  recipes-kernel/linux/linux-kexecboot.inc |   19 ++++++++-----------
>  1 files changed, 8 insertions(+), 11 deletions(-)
> 
> diff --git a/recipes-kernel/linux/linux-kexecboot.inc
> b/recipes-kernel/linux/linux-kexecboot.inc index fb9760a..ea0bbd6 100644
> --- a/recipes-kernel/linux/linux-kexecboot.inc
> +++ b/recipes-kernel/linux/linux-kexecboot.inc
> @@ -1,5 +1,5 @@
>  # We set INC_PR here, since a change in the kexecboot recipe will need to
> get picked up by *all* the kernels: -INC_PR = "r43"
> +INC_PR = "r44"
> 
>  inherit kernel siteinfo
> 
> @@ -19,16 +19,13 @@ DEPENDS += "xz-native"
>  LOGO_SIZE ?= "."
>  SRC_URI = "file://${LOGO_SIZE}/logo_linux_clut224.ppm.bz2"
> 
> -# Set the verbosity of kernel messages during runtime
> -CMDLINE_DEBUG ?= '${@base_contains("IMAGE_FEATURES", "debug-tweaks",
> "debug", "loglevel=3", d)}' -
> -# Note how we set master console on serial to protect bootlogo.
> -CMDLINE_c7x0 = "console=tty1 console=ttyS0,115200n8 ${CMDLINE_DEBUG}"
> -CMDLINE_tosa = "console=tty1 console=ttyS0,115200n8 ${CMDLINE_DEBUG}"
> -CMDLINE_poodle = "console=tty1 console=ttyS0,115200n8 fbcon=rotate:1
> ${CMDLINE_DEBUG}" -CMDLINE_akita = "console=tty1 console=ttyS0,115200n8
> fbcon=rotate:1 ${CMDLINE_DEBUG}" -CMDLINE_collie = "console=tty1
> console=ttySA0,115200n8 fbcon=rotate:1 mem=64M ${CMDLINE_DEBUG}"
> -CMDLINE_spitz = "console=tty1 console=ttyS0,115200n8 fbcon=rotate:1
> ${CMDLINE_DEBUG}" +# Note how we set loglevel=3 and master console on
> serial to protect bootlogo. +CMDLINE_c7x0 = "console=tty1
> console=ttyS0,115200n8 loglevel=3"
> +CMDLINE_tosa = "console=tty1 console=ttyS0,115200n8 loglevel=3"
> +CMDLINE_poodle = "console=tty1 console=ttyS0,115200n8 fbcon=rotate:1
> loglevel=3" +CMDLINE_akita = "console=tty1 console=ttyS0,115200n8
> fbcon=rotate:1 loglevel=3" +CMDLINE_collie = "console=tty1
> console=ttySA0,115200n8 fbcon=rotate:1 mem=64M loglevel=3" +CMDLINE_spitz
> = "console=tty1 console=ttyS0,115200n8 fbcon=rotate:1 loglevel=3"
> 
>  PACKAGES = ""
>  PROVIDES = ""

Merged to meta-handheld master, thanks.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre