All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: George Dunlap <dunlapg@umich.edu>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 6 of 9] xenpaging: add evict_pages function
Date: Thu, 15 Sep 2011 11:17:23 +0200	[thread overview]
Message-ID: <20110915091723.GA18591@aepfle.de> (raw)
In-Reply-To: <CAFLBxZaPWFSEj_apLtEn=CiZHiep0RMNd6iz_Ypc8Ep2X_Qjhw@mail.gmail.com>

On Thu, Sep 15, George Dunlap wrote:

> On Thu, Sep 15, 2011 at 9:16 AM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> > On Thu, 2011-09-15 at 02:16 -0400, Olaf Hering wrote:
> >> # HG changeset patch
> >> # User Olaf Hering <olaf@aepfle.de>
> >> # Date 1316067230 -7200
> >> # Node ID 3a3a5979b799d948802183d10d65894ee84a872f
> >> # Parent  6beca8cbc2c92900859712f8738db17084bcebdb
> >> xenpaging: add evict_pages function
> >>
> >> Add new function to evict a couple of pages.
> >
> > Do you really mean "a couple" here? (that generally means exactly two).
> 
> LIterally "couple" means two, but at least in US idiom, "a couple of
> [foo]" means a small indeterminate number, usually 2-4.
> 
> In any case, a more precise description seems like a better idea -- it
> looks like it takes an argument for the number of pages to evict; and
> it's not adding a new function, it's pulling existing code into a
> function.  So, "Pull eviction loop into a function" would probably be
> a better description.


Thanks to both of you, I will improve the description.

Olaf

  reply	other threads:[~2011-09-15  9:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-15  6:16 [PATCH 0 of 9] xenpaging fixes for xen-unstable Olaf Hering
2011-09-15  6:16 ` [PATCH 1 of 9] xenpaging: install into LIBEXEC dir Olaf Hering
2011-09-15  6:16 ` [PATCH 2 of 9] xenpaging: remove filename from comment Olaf Hering
2011-09-15  6:16 ` [PATCH 3 of 9] xenpaging: update xenpaging_init Olaf Hering
2011-09-15  6:16 ` [PATCH 4 of 9] xenpaging: remove xc_dominfo_t from paging_t Olaf Hering
2011-09-15  6:16 ` [PATCH 5 of 9] xenpaging: track the number of paged-out pages Olaf Hering
2011-09-15  6:16 ` [PATCH 6 of 9] xenpaging: add evict_pages function Olaf Hering
2011-09-15  8:16   ` Ian Campbell
2011-09-15  9:05     ` George Dunlap
2011-09-15  9:17       ` Olaf Hering [this message]
2011-09-28 16:14         ` Ian Jackson
2011-09-28 16:19           ` Olaf Hering
2011-09-15  6:16 ` [PATCH 7 of 9] xenpaging: add resume_pages function Olaf Hering
2011-09-15  9:15   ` George Dunlap
2011-09-15  6:16 ` [PATCH 8 of 9] xenpaging: compare both token and path when checking for @releaseDomain event Olaf Hering
2011-09-15  6:16 ` [PATCH 9 of 9] xenpaging: watch the domains /xenpaging/num_pages xenstore value Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110915091723.GA18591@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=Ian.Campbell@citrix.com \
    --cc=dunlapg@umich.edu \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.