From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Liam Girdwood <lrg@ti.com>
Subject: Re: ASoC: uninitialized variable i used in wait_for_dc_servo
Date: Thu, 15 Sep 2011 10:54:28 +0100 [thread overview]
Message-ID: <20110915095427.GB7988@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1316055154.3496.6.camel@phoenix>
On Thu, Sep 15, 2011 at 10:52:34AM +0800, Axel Lin wrote:
> @@ -722,7 +723,7 @@ static void wait_for_dc_servo(struct snd_soc_codec *codec, u16 mask)
>
> } else {
> msleep(1);
> - if (--i) {
> + if (--i == 0) {
You should avoid making random stylistic changes that aren't needed when
doing things like this.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Liam Girdwood <lrg@ti.com>
Subject: Re: ASoC: uninitialized variable i used in wait_for_dc_servo
Date: Thu, 15 Sep 2011 10:54:28 +0100 [thread overview]
Message-ID: <20110915095427.GB7988@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1316055154.3496.6.camel@phoenix>
On Thu, Sep 15, 2011 at 10:52:34AM +0800, Axel Lin wrote:
> @@ -722,7 +723,7 @@ static void wait_for_dc_servo(struct snd_soc_codec *codec, u16 mask)
>
> } else {
> msleep(1);
> - if (--i) {
> + if (--i == 0) {
You should avoid making random stylistic changes that aren't needed when
doing things like this.
next prev parent reply other threads:[~2011-09-15 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 2:52 ASoC: uninitialized variable i used in wait_for_dc_servo Axel Lin
2011-09-15 9:54 ` Mark Brown [this message]
2011-09-15 9:54 ` Mark Brown
2011-09-15 11:13 ` Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110915095427.GB7988@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.