From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>, Avi Kivity <avi@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH 1/2] KVM: emulate lapic tsc deadline timer for guest
Date: Thu, 15 Sep 2011 09:15:14 -0300 [thread overview]
Message-ID: <20110915121514.GA6230@amt.cnet> (raw)
In-Reply-To: <BC00F5384FCFC9499AF06F92E8B78A9E25448A9D46@shsmsx502.ccr.corp.intel.com>
On Thu, Sep 15, 2011 at 02:22:58PM +0800, Liu, Jinsong wrote:
> Marcelo Tosatti wrote:
> >> diff --git a/arch/x86/include/asm/apicdef.h
> >> b/arch/x86/include/asm/apicdef.h
> >> index 34595d5..3925d80 100644
> >> --- a/arch/x86/include/asm/apicdef.h
> >> +++ b/arch/x86/include/asm/apicdef.h
> >> @@ -100,7 +100,9 @@
> >> #define APIC_TIMER_BASE_CLKIN 0x0
> >> #define APIC_TIMER_BASE_TMBASE 0x1
> >> #define APIC_TIMER_BASE_DIV 0x2
> >> +#define APIC_LVT_TIMER_ONESHOT (0 << 17)
> >> #define APIC_LVT_TIMER_PERIODIC (1 << 17)
> >> +#define APIC_LVT_TIMER_TSCDEADLINE (2 << 17)
> >> #define APIC_LVT_MASKED (1 << 16)
> >> #define APIC_LVT_LEVEL_TRIGGER (1 << 15)
> >> #define APIC_LVT_REMOTE_IRR (1 << 14)
> >
> > Please have a separate, introductory patch for definitions that are
> > not KVM specific.
> >
>
> OK, will present a separate patch. BTW, will the separate patch still be send to kvm@vger.kernel.org?
Yes.
>
> >> +++ b/arch/x86/include/asm/kvm_host.h
> >> @@ -671,6 +671,8 @@ u8 kvm_get_guest_memory_type(struct kvm_vcpu
> >> *vcpu, gfn_t gfn);
> >>
> >> extern bool tdp_enabled;
> >>
> >> +extern u64 vcpu_tsc_khz(struct kvm_vcpu *vcpu);
> >> +
> >
> > No need for extern.
> >
>
> Any special concern, or, for coding style? a little curious :)
It is not necessary.
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>, Avi Kivity <avi@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/2] KVM: emulate lapic tsc deadline timer for guest
Date: Thu, 15 Sep 2011 09:15:14 -0300 [thread overview]
Message-ID: <20110915121514.GA6230@amt.cnet> (raw)
In-Reply-To: <BC00F5384FCFC9499AF06F92E8B78A9E25448A9D46@shsmsx502.ccr.corp.intel.com>
On Thu, Sep 15, 2011 at 02:22:58PM +0800, Liu, Jinsong wrote:
> Marcelo Tosatti wrote:
> >> diff --git a/arch/x86/include/asm/apicdef.h
> >> b/arch/x86/include/asm/apicdef.h
> >> index 34595d5..3925d80 100644
> >> --- a/arch/x86/include/asm/apicdef.h
> >> +++ b/arch/x86/include/asm/apicdef.h
> >> @@ -100,7 +100,9 @@
> >> #define APIC_TIMER_BASE_CLKIN 0x0
> >> #define APIC_TIMER_BASE_TMBASE 0x1
> >> #define APIC_TIMER_BASE_DIV 0x2
> >> +#define APIC_LVT_TIMER_ONESHOT (0 << 17)
> >> #define APIC_LVT_TIMER_PERIODIC (1 << 17)
> >> +#define APIC_LVT_TIMER_TSCDEADLINE (2 << 17)
> >> #define APIC_LVT_MASKED (1 << 16)
> >> #define APIC_LVT_LEVEL_TRIGGER (1 << 15)
> >> #define APIC_LVT_REMOTE_IRR (1 << 14)
> >
> > Please have a separate, introductory patch for definitions that are
> > not KVM specific.
> >
>
> OK, will present a separate patch. BTW, will the separate patch still be send to kvm@vger.kernel.org?
Yes.
>
> >> +++ b/arch/x86/include/asm/kvm_host.h
> >> @@ -671,6 +671,8 @@ u8 kvm_get_guest_memory_type(struct kvm_vcpu
> >> *vcpu, gfn_t gfn);
> >>
> >> extern bool tdp_enabled;
> >>
> >> +extern u64 vcpu_tsc_khz(struct kvm_vcpu *vcpu);
> >> +
> >
> > No need for extern.
> >
>
> Any special concern, or, for coding style? a little curious :)
It is not necessary.
next prev parent reply other threads:[~2011-09-15 12:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 14:36 [PATCH 1/2] KVM: emulate lapic tsc deadline timer for guest Liu, Jinsong
2011-09-13 14:36 ` [Qemu-devel] " Liu, Jinsong
2011-09-14 11:45 ` Marcelo Tosatti
2011-09-14 11:45 ` [Qemu-devel] " Marcelo Tosatti
2011-09-15 6:22 ` Liu, Jinsong
2011-09-15 6:22 ` [Qemu-devel] " Liu, Jinsong
2011-09-15 12:15 ` Marcelo Tosatti [this message]
2011-09-15 12:15 ` Marcelo Tosatti
2011-09-15 8:17 ` Liu, Jinsong
2011-09-15 8:17 ` [Qemu-devel] " Liu, Jinsong
2011-09-15 11:45 ` Marcelo Tosatti
2011-09-15 11:45 ` [Qemu-devel] " Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110915121514.GA6230@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=jinsong.liu@intel.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.