From: Ben Widawsky <ben@bwidawsk.net>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/5] drm/i915: clean up ring id/semaphore sync index magic
Date: Thu, 15 Sep 2011 19:11:00 -0700 [thread overview]
Message-ID: <20110915191100.779dca67@bwidawsk.net> (raw)
In-Reply-To: <1316138941-6537-2-git-send-email-ben@bwidawsk.net>
On Thu, 15 Sep 2011 19:08:57 -0700
Ben Widawsky <ben@bwidawsk.net> wrote:
> From: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> The calculation of the semaphore sync register index is obfuscated
> by some pointer calculation to get at the ring id (RCS, VCS and BCS).
> Now we already have a ring->id field, but that contains a flag value
> usefull for ORing together multiple rings - that's what the flushing
> code as the user of this field needs.
>
> So change the meaning of ring->id to be the real id, add a tiny
> helper for those that actually want a flag and use ring->id in the
> semaphore index calculations.
>
> Also extract the inverse function intel_sync_index_to_ring_id and
> move it right next to intel_ring_sync_index.
>
> v2: Simplify RING_SYNC macro as suggested by Chris Wilson.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Crap, I forgot:
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
next prev parent reply other threads:[~2011-09-16 2:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 2:08 Semaphore cleanups Ben Widawsky
2011-09-16 2:08 ` [PATCH 1/5] drm/i915: clean up ring id/semaphore sync index magic Ben Widawsky
2011-09-16 2:11 ` Ben Widawsky [this message]
2011-09-16 2:08 ` [PATCH 2/5] drm/i915: semaphore wait cleanup Ben Widawsky
2011-09-16 2:08 ` [PATCH 3/5] drm/i915: semaphore signal cleanup Ben Widawsky
2011-09-16 2:09 ` [PATCH 4/5] drm/i915: more semaphore cleanup Ben Widawsky
2011-09-16 5:12 ` Zou, Nanhai
2011-09-16 2:09 ` [PATCH 5/5] drm/i915: tracepoints for semaphores Ben Widawsky
2011-09-16 7:58 ` Daniel Vetter
2011-09-16 8:37 ` Chris Wilson
2011-09-16 9:07 ` Daniel Vetter
2011-09-16 9:45 ` Chris Wilson
2011-09-16 7:39 ` Semaphore cleanups Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110915191100.779dca67@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.