From: Chris Wilson <chris@chris-wilson.co.uk>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Ben Widawsky <ben@bwidawsk.net>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/5] drm/i915: tracepoints for semaphores
Date: Fri, 16 Sep 2011 10:45:34 +0100 [thread overview]
Message-ID: <c55c5d$gu85s@AZSMGA002.ch.intel.com> (raw)
In-Reply-To: <20110916090729.GC2873@phenom.ffwll.local>
On Fri, 16 Sep 2011 11:07:29 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Fri, Sep 16, 2011 at 09:37:41AM +0100, Chris Wilson wrote:
> > On Fri, 16 Sep 2011 09:58:53 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> > > We already have trace_i915_gem_request_add in i915_add_request which is
> > > essentially giving out the same information (well, minus the hopefully
> > > correct singal_mbox reg addresses). I think we can drop this one.
> >
> > I thought that as well, but then realised that a complete set of ring
> > tracepoints would be useful independent of the request/object
> > tracepoints.
> >
> > A couple of tracepoints on the gen6 paths is insufficients. ;-)
>
> Well, I've quickly reviewed them and I think we're mostly covered. Many of
> the tracepoints are called from generic code i915_gem.c right before/after
> calling into the chipset-specific ringbuffer functions.
It's just the difference of being able to watch only i915:intel_ring* to
reduce the amount of noise if that is all you are interested in. And you
don't have to remember the relationship between a particular
i915_gem_request and its effect upon the ring.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-09-16 9:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 2:08 Semaphore cleanups Ben Widawsky
2011-09-16 2:08 ` [PATCH 1/5] drm/i915: clean up ring id/semaphore sync index magic Ben Widawsky
2011-09-16 2:11 ` Ben Widawsky
2011-09-16 2:08 ` [PATCH 2/5] drm/i915: semaphore wait cleanup Ben Widawsky
2011-09-16 2:08 ` [PATCH 3/5] drm/i915: semaphore signal cleanup Ben Widawsky
2011-09-16 2:09 ` [PATCH 4/5] drm/i915: more semaphore cleanup Ben Widawsky
2011-09-16 5:12 ` Zou, Nanhai
2011-09-16 2:09 ` [PATCH 5/5] drm/i915: tracepoints for semaphores Ben Widawsky
2011-09-16 7:58 ` Daniel Vetter
2011-09-16 8:37 ` Chris Wilson
2011-09-16 9:07 ` Daniel Vetter
2011-09-16 9:45 ` Chris Wilson [this message]
2011-09-16 7:39 ` Semaphore cleanups Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='c55c5d$gu85s@AZSMGA002.ch.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.