All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amos Kong <akong@redhat.com>
To: seabios@seabios.org
Cc: kvm@vger.kernel.org, mst@redhat.com, jasowang@redhat.com,
	mtosatti@redhat.com, alex.williamson@redhat.com,
	kevin@koconnor.net
Subject: [SeaBIOS PATCH 1/2] Fix regression of commit 87b533bf
Date: Mon, 19 Sep 2011 14:53:38 +0800	[thread overview]
Message-ID: <20110919065338.22802.48911.stgit@t> (raw)
In-Reply-To: <20110919065307.22802.51309.stgit@t>

After adding more device entries in ACPI DSDT tables,
the filesize of bios.bin changed from 128K to 256K.
But bios could not initialize successfully.

This is a regression since seabios commit 87b533bf. Prior to
that commit, seabios did not mark the early 32bit initialization
code as init code. However, a side effect of marking that code
(handle_post) as init code is that it is more likely the linker
could place the code at an address less than 0xe0000.
The patch (just a hack) would cover up the issue.

Signed-off-by: Amos Kong <akong@redhat.com>
---
 0 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/src/post.c b/src/post.c
index e195e89..bc2e548 100644
--- a/src/post.c
+++ b/src/post.c
@@ -336,7 +336,7 @@ reloc_init(void)
 // Start of Power On Self Test (POST) - the BIOS initilization phase.
 // This function does the setup needed for code relocation, and then
 // invokes the relocation and main setup code.
-void VISIBLE32INIT
+void VISIBLE32FLAT
 handle_post(void)
 {
     debug_serial_setup();
@@ -356,6 +356,14 @@ handle_post(void)
 
     // Allow writes to modify bios area (0xf0000)
     make_bios_writable();
+
+    void handle_post2(void);
+    handle_post2();
+}
+
+void VISIBLE32INIT
+handle_post2(void)
+{
     HaveRunPost = 1;
 
     // Detect ram and setup internal malloc.


  reply	other threads:[~2011-09-19  6:53 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-19  6:53 [SEABIOS PATCH 0/2] fix of hotplug multi-func device Amos Kong
2011-09-19  6:53 ` Amos Kong [this message]
2011-09-19  7:27   ` [SeaBIOS PATCH 2/2] hotplug: Add device per func in ACPI DSDT tables Amos Kong
2011-09-19  9:57     ` [SeaBIOS] " Gleb Natapov
2011-09-19 10:02       ` Michael S. Tsirkin
2011-09-19 10:12         ` Gleb Natapov
2011-09-19 10:32           ` Gleb Natapov
2011-09-19 12:18             ` [SeaBIOS] " Michael S. Tsirkin
2011-09-19 16:27         ` Marcelo Tosatti
2011-09-19 19:08           ` Michael S. Tsirkin
2011-09-20 10:45             ` [SeaBIOS PATCH v2] " Amos Kong
2011-09-20 11:47               ` Marcelo Tosatti
2011-09-21  1:48               ` Kevin O'Connor
2011-09-21  5:39                 ` Amos Kong
2011-09-21 11:09                   ` Michael S. Tsirkin
2011-09-21 12:47                     ` Kevin O'Connor
2011-09-21 13:14                       ` Michael S. Tsirkin
2011-12-06  5:39                         ` [SeaBIOS PATCH v3] " Amos Kong
2011-12-06 11:36                           ` Michael S. Tsirkin
2011-12-07  0:32                             ` Amos Kong
2011-12-14  1:06                               ` Kevin O'Connor
2011-12-19  8:45                                 ` Amos Kong
2012-05-09  7:24                                 ` [RESEND PATCH v3] hotplug: add " Amos Kong
2012-05-09  7:24                                   ` [Qemu-devel] " Amos Kong
2012-05-09  7:35                                   ` Amos Kong
2012-05-09  8:46                                   ` Michael S. Tsirkin
2012-05-09  8:46                                     ` [Qemu-devel] " Michael S. Tsirkin
2012-05-09  8:59                                     ` Amos Kong
2012-05-09  9:53                                       ` Amos Kong
2012-05-09 13:47                                   ` Alex Williamson
2012-05-09 13:47                                     ` [Qemu-devel] " Alex Williamson
2012-05-09 16:08                                     ` Amos Kong
2012-05-10 16:50                                     ` Jiang Liu
2012-05-10 16:50                                       ` [Qemu-devel] " Jiang Liu
2012-05-10 17:03                                       ` Michael S. Tsirkin
2012-05-10 17:03                                         ` [Qemu-devel] " Michael S. Tsirkin
2012-05-10 17:17                                   ` Jiang Liu
2012-05-10 17:17                                     ` [Qemu-devel] " Jiang Liu
2012-05-10 17:42                                     ` Michael S. Tsirkin
2012-05-10 17:42                                       ` [Qemu-devel] " Michael S. Tsirkin
2012-05-10 17:46                                       ` Jiang Liu
2012-05-10 17:46                                         ` [Qemu-devel] " Jiang Liu
2012-05-10 23:40                                         ` Amos Kong
2012-05-10 23:40                                           ` Amos Kong
2012-05-11 10:14                                         ` [SeaBIOS] " Gleb Natapov
2012-05-11 10:14                                           ` [Qemu-devel] " Gleb Natapov
2012-05-11 15:44                                           ` Jiang Liu
2012-05-11 15:44                                             ` [Qemu-devel] " Jiang Liu
2012-05-11 17:04                                             ` Gleb Natapov
2012-05-11 17:04                                               ` [Qemu-devel] " Gleb Natapov
2011-09-20 10:44           ` [SeaBIOS PATCH] hotplug: Add " Amos Kong
2011-09-20 11:42             ` Marcelo Tosatti
2011-09-20  8:00   ` [SeaBIOS PATCH v2] Fix regression of commit 87b533bf Amos Kong
2011-09-20 23:52     ` Kevin O'Connor
     [not found] ` <20110919065347.22802.53640.stgit@t>
     [not found]   ` <20110919093644.GC4501@redhat.com>
2011-09-19  9:49     ` [SeaBIOS PATCH 2/2] hotplug: Add device per func in ACPI DSDT tables Michael S. Tsirkin
2011-09-19 10:04     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110919065338.22802.48911.stgit@t \
    --to=akong@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=seabios@seabios.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.